Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

profiler: ensure that CPU profile records profiler work #1485

Merged
merged 6 commits into from
Sep 30, 2022

Commits on Sep 28, 2022

  1. profiler: ensure that CPU profile records profiler work

    Our profiler library does post-processing of profiles, such as computing
    deltas for heap, block, and mutex profiles, which has non-zero CPU
    overhead. Right now there's no guarantee that that work will be captured
    in the CPU profile. Add synchronization so that the CPU profiler will
    only be stopped after all other profiles are completed.
    nsrip-dd committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    770f799 View commit details
    Browse the repository at this point in the history
  2. profiler: start CPU profile at the end of the period

    If the CPU profile duration is less than the profiling period, make sure
    that the CPU profile happens at the end rather than the beginning of
    the profile period. That way, we respect the shorter CPU duration but
    still capture the profiler library work.
    nsrip-dd committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    2118c20 View commit details
    Browse the repository at this point in the history
  3. profiler: remove TODO

    nsrip-dd committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    3778957 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2022

  1. profiler: use sync.WaitGroup to signal when CPU profiling shoulds stop

    Simpler than a map of channels
    nsrip-dd committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    0fe598f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c917d48 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2022

  1. Configuration menu
    Copy the full SHA
    566b8d6 View commit details
    Browse the repository at this point in the history