Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

appsec/waf: enable linux and darwin on arm64 targets #1494

Merged
merged 7 commits into from
Oct 4, 2022

Conversation

Julio-Guerra
Copy link
Contributor

Support linux/arm64 and darwin/arm64 targets.

…4 targets

Note that I restored the stripping of the linux libraries so that we strip
the C++ library that got linked too. This one is safe to do since we stay
on the same toolchain and ABI than the binutils' strip one.
@Julio-Guerra Julio-Guerra added this to the 1.43.0 milestone Oct 4, 2022
@Julio-Guerra Julio-Guerra requested a review from a team as a code owner October 4, 2022 11:13
@Julio-Guerra Julio-Guerra requested a review from a team as a code owner October 4, 2022 11:56
Hellzy
Hellzy previously approved these changes Oct 4, 2022
Copy link
Contributor

@Hellzy Hellzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nit on copyright for the new vendor.go file.

internal/appsec/waf/lib/linux-arm64/vendor.go Show resolved Hide resolved
@Julio-Guerra Julio-Guerra merged commit c07d238 into main Oct 4, 2022
@Julio-Guerra Julio-Guerra deleted the julio.guerra/libddwaf-arm64 branch October 4, 2022 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants