Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

contrib/globalsign/mgo: add mongodb collection tag #1725

Merged
merged 3 commits into from
Feb 21, 2023
Merged

contrib/globalsign/mgo: add mongodb collection tag #1725

merged 3 commits into from
Feb 21, 2023

Conversation

rarguelloF
Copy link
Contributor

@rarguelloF rarguelloF commented Feb 10, 2023 •
edited
Loading

What does this PR do?

  • Adds db.mongodb.collection for contrib/globalsign/mgo integration.
  • Fix issue for contrib/globalsign/mgo where tags where not being propagated for some commands (Bulk and Iter).

Motivation

Unify span tags across tracers.

Describe how to test/QA your changes

Reviewer's Checklist

  • If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • Changed code has unit tests for its functionality.
  • If this interacts with the agent in a new way, a system test has been added.

@pr-commenter
Copy link

pr-commenter bot commented Feb 10, 2023 •
edited
Loading

Benchmarks

Comparing candidate commit da75548 in PR branch rarguelloF/mgo-add-collection-tag with baseline commit 69d4e3b in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 6 cases.

@rarguelloF rarguelloF added this to the Triage milestone Feb 10, 2023
@rarguelloF rarguelloF marked this pull request as ready for review February 10, 2023 12:53
@rarguelloF rarguelloF requested review from a team and zarirhamza February 10, 2023 12:53
zarirhamza
zarirhamza previously approved these changes Feb 10, 2023
View reviewed changes
Copy link
Contributor

@zarirhamza zarirhamza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - good stuff propagating the tabs

ahmed-mez
ahmed-mez previously approved these changes Feb 13, 2023
View reviewed changes
@ahmed-mez ahmed-mez modified the milestones: Triage, v1.48.0 Feb 21, 2023
@rarguelloF rarguelloF dismissed stale reviews from ahmed-mez and zarirhamza via da75548 February 21, 2023 09:23
@rarguelloF rarguelloF force-pushed the rarguelloF/mgo-add-collection-tag branch from 1b20b44 to da75548 Compare February 21, 2023 09:23
@ahmed-mez ahmed-mez merged commit 075fbd2 into main Feb 21, 2023
@ahmed-mez ahmed-mez deleted the rarguelloF/mgo-add-collection-tag branch February 21, 2023 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmed-mez ahmed-mez ahmed-mez approved these changes

@zarirhamza zarirhamza zarirhamza left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.48.0
Development

Successfully merging this pull request may close these issues.
3 participants
@rarguelloF @ahmed-mez @zarirhamza