database/sql: Export TracedConn, as we need it when using the db.Conn Raw() API call. #1779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We would prefer to be able to type assert to this interface type, but we cannot type assert without the type being exported. The alternative would be to use reflection here. In addition, we want to be able to, on occasion, access the underlying connection object, hence the addition of the WrappedConn() function. Signed-off-by: Alec Warner <alec.warner@panther.io>
|
Hi @samsm ! Thanks for the contribution! The CI is failing because exported methods and structs don't have comments https://github.com/DataDog/dd-trace-go/actions/runs/4344226735/jobs/7587359442 - please update the PR accordingly! |
3 tasks
ahmed-mez
reviewed
Mar 6, 2023
Co-authored-by: Ahmed Mezghani <38987709+ahmed-mez@users.noreply.github.com>
ahmed-mez
reviewed
Mar 6, 2023
Co-authored-by: Ahmed Mezghani <38987709+ahmed-mez@users.noreply.github.com>
ahmed-mez
approved these changes
Mar 6, 2023
ahmed-mez
changed the title
|
Thanks for finishing this up! it ended up being lower priority on our side but glad to see it merged ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We would prefer to be able to type assert to this interface type, but we cannot type assert without the type being exported. The alternative would be to use reflection here.
In addition, we want to be able to, on occasion, access the underlying connection object, hence the addition of the WrappedConn() function.
This is an up-to-date-version of #1566 , you can read this change there.