Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: run pull request workflows for merge groups #1809

Merged
merged 1 commit into from
Mar 16, 2023

Conversation

nsrip-dd
Copy link
Contributor

What does this PR do?

Enables our pull request CI checks to also run on "merge groups", which are
what GitHub does to implement a merge queue.

See the official docs

Motivation

If we want to enable a merge queue, we should have our CI also run on PR
that get added to the queue. If CI fails, the PR will be removed from
the queue. Right now we require a PR to be up-to-date with main, and
have green CI, before merging into main. This basically replicates that
requirement for merge queues.

Describe how to test/QA your changes

Reviewer's Checklist

  • If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • Changed code has unit tests for its functionality.
  • If this interacts with the agent in a new way, a system test has been added.

If we want to enable a merge queue, we should have our CI also run on PR
that get added to the queue. If CI fails, the PR will be removed from
the queue. Right now we require a PR to be up-to-date with main, and
have green CI, before merging into main. This basically replicates that
requirement for merge queues.
@nsrip-dd nsrip-dd requested review from a team as code owners March 16, 2023 14:31
@pr-commenter
Copy link

pr-commenter bot commented Mar 16, 2023

Benchmarks

Comparing candidate commit 9fce400 in PR branch nick.ripley/run-checks-on-merge-queue with baseline commit 1de4e96 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 18 metrics, 0 unstable metrics.

@nsrip-dd nsrip-dd added this to the v1.49.0 milestone Mar 16, 2023
@nsrip-dd nsrip-dd merged commit 68bff5f into main Mar 16, 2023
@nsrip-dd nsrip-dd deleted the nick.ripley/run-checks-on-merge-queue branch March 16, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants