Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contrib/globalsign/mgo: err always nil. #2269

Merged
merged 4 commits into from
Nov 2, 2023
Merged

Conversation

tttoad
Copy link
Contributor

@tttoad tttoad commented Oct 14, 2023

Fixes #2165

@tttoad tttoad requested a review from a team October 14, 2023 18:47
@ajgajg1134
Copy link
Contributor

👋 Thanks for the contribution! One thing I think we should add here is a small unit test to verify this change (and make sure we don't regress later)

@ajgajg1134 ajgajg1134 added the apm:ecosystem contrib/* related feature requests or bugs label Oct 16, 2023
@darccio
Copy link
Member

darccio commented Oct 23, 2023

@tttoad Can you add a unit test to detect future regressions? Thanks!

@tttoad
Copy link
Contributor Author

tttoad commented Oct 23, 2023

Sorry, I didn't notice the your replies(@ajgajg1134). The unit test has been added @darccio .

@darccio darccio merged commit 6ec6751 into DataDog:main Nov 2, 2023
61 checks passed
@darccio
Copy link
Member

darccio commented Nov 2, 2023

@tttoad After merging this, we have a question about this library/integration. It's fairly old, last release in 2018, and we are not aware of any alternative. Looking around it seems that juju/mgo is a well maintained fork.

What is the current state of MongoDB drivers from your point of view? Is there any reason to keep using globalsign/mgo?

@tttoad
Copy link
Contributor Author

tttoad commented Nov 3, 2023

@darccio Sorry, I can't give advice... I hardly use mongodb, I just saw the problem and fixed it.

@darccio
Copy link
Member

darccio commented Nov 3, 2023

Don't worry. Thanks for the feedback and the fix, @tttoad!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:ecosystem contrib/* related feature requests or bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

contrib/globalsign/mgo: err always nil.
3 participants