Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contrib: header_tags support on julienschmidt/httprouter #2331

Merged
merged 4 commits into from
Nov 15, 2023

Conversation

mtoffl01
Copy link
Contributor

@mtoffl01 mtoffl01 commented Nov 2, 2023

What does this PR do?

Implements global and integration-level support for dd_trace_header_tags on the julienschmidt/httprouter integration

Motivation

Fixes #2251

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • There is a benchmark for any new code, or changes to existing code.
  • [N/A] If this interacts with the agent in a new way, a system test has been added.

For Datadog employees:

  • If this PR touches code that handles credentials of any kind, such as Datadog API keys, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

@mtoffl01 mtoffl01 requested a review from a team November 2, 2023 18:49
@github-actions github-actions bot added the apm:ecosystem contrib/* related feature requests or bugs label Nov 2, 2023
@mtoffl01 mtoffl01 marked this pull request as draft November 2, 2023 18:54
@pr-commenter
Copy link

pr-commenter bot commented Nov 2, 2023

Benchmarks

Benchmark execution time: 2023-11-02 19:08:16

Comparing candidate commit 3ab24bf in PR branch mtoff/httprouter-dd_trace_headers with baseline commit d082416 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 39 metrics, 2 unstable metrics.

@mtoffl01 mtoffl01 marked this pull request as ready for review November 2, 2023 19:14
@ajgajg1134 ajgajg1134 enabled auto-merge (squash) November 15, 2023 15:19
@ajgajg1134 ajgajg1134 merged commit c8cfc0c into main Nov 15, 2023
50 checks passed
@ajgajg1134 ajgajg1134 deleted the mtoff/httprouter-dd_trace_headers branch November 15, 2023 15:24
@darccio darccio restored the mtoff/httprouter-dd_trace_headers branch November 16, 2023 10:37
@darccio darccio deleted the mtoff/httprouter-dd_trace_headers branch November 16, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:ecosystem contrib/* related feature requests or bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

contrib/julienschmidt/httprouter and DD_* environment variables
3 participants