Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tracer: improve debug message for propagating tag length limit reached #2405

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

katiehockman
Copy link
Contributor

What does this PR do?

Adds additional context to the debug message that is sent if the propagating tag exceeds the maximum configured length.

Motivation

This should make it easier for customers to decide how much they need to increase DD_TRACE_X_DATADOG_TAGS_MAX_LENGTH.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.

For Datadog employees:

  • If this PR touches code that handles credentials of any kind, such as Datadog API keys, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

@katiehockman katiehockman marked this pull request as ready for review November 30, 2023 16:52
@katiehockman katiehockman requested a review from a team November 30, 2023 16:52
@pr-commenter
Copy link

pr-commenter bot commented Nov 30, 2023

Benchmarks

Benchmark execution time: 2023-11-30 17:06:06

Comparing candidate commit 1608ebc in PR branch katie.hockman/improve-debug-message with baseline commit 2a84dea in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 39 metrics, 2 unstable metrics.

@katiehockman katiehockman merged commit d2016f2 into main Nov 30, 2023
51 of 52 checks passed
@katiehockman katiehockman deleted the katie.hockman/improve-debug-message branch November 30, 2023 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants