Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Only mark PRs as stale #2423

Merged
merged 2 commits into from
Dec 13, 2023
Merged

CI: Only mark PRs as stale #2423

merged 2 commits into from
Dec 13, 2023

Conversation

ajgajg1134
Copy link
Contributor

What does this PR do?

Need to manually set issue-stale to -1 so that we don't mark issues as stale (We only want to mark PRs as stale)

Motivation

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.

For Datadog employees:

  • If this PR touches code that handles credentials of any kind, such as Datadog API keys, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

Need to manually set issue-stale to -1 so that we don't mark issues as stale (We only want to mark PRs as stale)
@ajgajg1134 ajgajg1134 marked this pull request as ready for review December 11, 2023 14:09
@ajgajg1134 ajgajg1134 requested a review from a team as a code owner December 11, 2023 14:09
@pr-commenter
Copy link

pr-commenter bot commented Dec 11, 2023

Benchmarks

Benchmark execution time: 2023-12-11 14:24:26

Comparing candidate commit 4480c70 in PR branch andrew.glaude/fixStale with baseline commit ef3fbf1 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 39 metrics, 2 unstable metrics.

days-before-pr-stale: 20
days-before-issue-stale: -1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As an alternative, I believe you can use the on field at the top to limit this to only PRs.
e.g. https://github.com/DataDog/dd-trace-go/blob/main/.github/workflows/ecosystems-label.yml#L2

@ajgajg1134 ajgajg1134 enabled auto-merge (squash) December 13, 2023 18:50
@ajgajg1134 ajgajg1134 merged commit 417a56e into main Dec 13, 2023
53 checks passed
@ajgajg1134 ajgajg1134 deleted the andrew.glaude/fixStale branch December 13, 2023 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants