-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
w3c: ensure _dd.parent_id is set using x-datadog-parent-id #2696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksBenchmark execution time: 2024-05-24 19:09:47 Comparing candidate commit 5596e58 in PR branch Found 0 performance improvements and 1 performance regressions! Performance is the same for 45 metrics, 1 unstable metrics. scenario:BenchmarkStartSpanConcurrent-24
|
mabdinur
force-pushed
the
munir/w3c-phase-3
branch
from
May 16, 2024 22:58
4ba569e
to
1901b58
Compare
dianashevchenko
requested changes
May 21, 2024
dianashevchenko
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Improves support for w3c tracecontext propagation. If the last datadog parent id can not be set using the
p
key in tracestate set_dd.parent_id
using the x-datadog-parent-id header.Motivation
The
_dd.parent_id
tag is used as a back up parent_id. If Span.parent_id can not be found then_dd.parent_id
will be used to generate trace flamegraphs. This will reduce the frequency of broken traces in the Datadog UIPassing the following system tests: https://github.com/DataDog/system-tests/blob/main/tests/parametric/test_headers_tracecontext.py#L717-%23L809
Reviewer's Checklist
Unsure? Have a question? Request a review!