contrib/sql: Changing Span Type from db to sql
#281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 26, 2018 13:43
The SQL integration was sending the wrong span type which impacts functionality.
Updated SQL tests so that when there is a tag mismatch between the expected tag value and the actual tag value, the tag name is printed. This is to help with debugging.
The unit tests were expected `db` for the Span Type. They should expect `sql`.
palazzem
changed the title
db to sqldb to sql
palazzem
approved these changes
Jul 26, 2018
mingrammer
pushed a commit
to mingrammer/dd-trace-go
that referenced
this pull request
Dec 22, 2020
* contrib/database/sql: changed the span type from `db` to `sql` The SQL integration was sending the wrong span type which impacts functionality. * /contrib/internal/sqltest: print out the Tag name Updated SQL tests so that when there is a tag mismatch between the expected tag value and the actual tag value, the tag name is printed. This is to help with debugging. * contrib/database/sql&contrib/jmoiron/sqlx fixed expected spantypes. The unit tests were expected `db` for the Span Type. They should expect `sql`. * contrib/databases/sql: Fixed a typo in a comment. * contrib/database/sql: Changed SQLSpanType to const.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Span Type being set for SQL traces was
db, this is incorrect, it ought to besql. Having the wrong SpanType impedes certain functionality.