Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

contrib/tidwall/buntdb: add buntdb integration #304

Merged
merged 11 commits into from
Sep 12, 2018
Merged

contrib/tidwall/buntdb: add buntdb integration #304

merged 11 commits into from
Sep 12, 2018

Conversation

dd-caleb
Copy link
Contributor

@dd-caleb dd-caleb commented Aug 6, 2018

Fixes #303

I had to wrap all the Tx methods and a few of the DB methods. I also added WithContext methods and a WithContext option.

@dd-caleb dd-caleb added apm:ecosystem contrib/* related feature requests or bugs feature-request labels Aug 8, 2018
@dd-caleb dd-caleb requested a review from gbbr August 8, 2018 13:48
@gbbr gbbr added this to the 1.3.0 milestone Sep 11, 2018
gbbr
gbbr approved these changes Sep 12, 2018
View reviewed changes
Copy link
Contributor

@gbbr gbbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, like all your PRs, thanks!

@gbbr gbbr merged commit 0f584c5 into v1 Sep 12, 2018
@gbbr gbbr deleted the caleb/buntdb branch September 12, 2018 14:36
mingrammer pushed a commit to mingrammer/dd-trace-go that referenced this pull request Dec 22, 2020
@dd-caleb @mingrammer
contrib/tidwall/buntdb: add buntdb integration (DataDog#304)
75aee83
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbbr gbbr gbbr approved these changes

Assignees
No one assigned
Labels
apm:ecosystem contrib/* related feature requests or bugs
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@dd-caleb @gbbr