contrib/go-redis/redis: make go-redis traced Client a true redis.Cmdable #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous prototype of Pipeline would yield an error when trying to use the client as a redis.Cmdable. Now Pipeline returns an interface and not a concrete type.
ufoot
commented
Sep 11, 2018
| @@ -21,12 +21,16 @@ type Client struct { | |||
| *params | |||
| } | |||
|
|
|||
| var _ redis.Cmdable = (*Client)(nil) | |||
There was a problem hiding this comment.
This does not compile without changing the prototype of Pipeline().
ufoot
commented
Sep 11, 2018
| @@ -59,7 +59,7 @@ func TestPipeline(t *testing.T) { | |||
| pipeline.Expire("pipeline_counter", time.Hour) | |||
|
|
|||
| // Exec with context test | |||
| pipeline.ExecWithContext(context.Background()) | |||
| pipeline.(*Pipeliner).ExecWithContext(context.Background()) | |||
There was a problem hiding this comment.
Breaking change, test needed to be updated...
gbbr
changed the title
gbbr
approved these changes
Sep 11, 2018
gbbr
pushed a commit
that referenced
this pull request
Sep 11, 2018
Previous prototype of Pipeline would yield an error when trying to use the client as a redis.Cmdable. Now Pipeline returns an interface and not a concrete type.
mingrammer
pushed a commit
to mingrammer/dd-trace-go
that referenced
this pull request
Dec 22, 2020
Previous prototype of Pipeline would yield an error when trying to use the client as a redis.Cmdable. Now Pipeline returns an interface and not a concrete type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm experiencing problems using a traced client. The baseline is: I try to have the same code running when it's traced and when it's not, keeping an option "I want to trace this or not" at runtime.
As I view it one option is to consider the client is just a https://godoc.org/github.com/go-redis/redis#Cmdable be it traced or not.
Now I hit a problem, the
Pipeline()func has the wrong prototype. While it's true*Pipelinerimplementsredis.Pipeliner, the signature is different and just because of that detail it's impossible to useClientas a generic Cmdable.This patch changes the prototype. It is a breaking change, as I had to update a test. Indeed, caller
can not assume
Pipeline()returns a concrete*Pipeliner. So a cast is required. But OTOH the client is a truely genericredis.Cmdable...