-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
contrib/emicklei/go-restful: add go-restful integration #331
Conversation
71bc3fb
to
7ce4318
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for doing this! It's looking great. I'm happy to merge it after addressing these minor style related comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the changes and for your patience. Just a couple more nits.
If you could allow me to edit your PR, I could take a look at that test and see if we can merge them into one single test. Here's a link on how to do that: https://help.github.com/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork/ |
I already allowed edits from maintainer, so feel free to modify it as you see fit |
e308d47
to
77fcfa3
Compare
Thanks @anggorodewanto! I'm happy enough if you address all comments except the one with the sub-tests. I don't feel so strongly about it. |
38a73e4
to
cb56e7b
Compare
No prob! I've addressed them and squashed the commits |
Thanks a lot! I will review again soon and it should be good to go! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last thing to improve on the example.
cb56e7b
to
a4a4f85
Compare
Updated the example and squashed the commits |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done! Thanks for your patience.
For future reference, it might be best not to squash the commits until the review is complete because it makes it easier to see changes made after addressing some comments.
GitHub also has the "Squash & Merge" UI feature which will do it for you automatically before merging.
Thanks again for your work. Are you using this yourself?
Sorry about that! Yeah we just signed the contract with Datadog last week |
No description provided.