contrib/google.golang.org/grpc: Fix adding errors to spans and traces #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbbr
reviewed
Feb 18, 2019
| } | ||
| sid := span.SpanID() |
There was a problem hiding this comment.
Thx, forgotten from debugging :)
| @@ -335,6 +339,50 @@ func TestPreservesMetadata(t *testing.T) { | |||
| "existing metadata should be preserved") | |||
| } | |||
|
|
|||
| func TestStreamSendsErrorCode(t *testing.T) { | |||
There was a problem hiding this comment.
👍 great! Thanks for adding a test.
- Put finishWithError calls inside clojure functions because the deferred function's arguments are evaluated when the defer statement is evaluated. More at https://golang.org/doc/effective_go.html#defer Before this commit, `finishWithError` deferred with nil error and any other changes of the initial value were not added to span. This bug affects only grpc streaming. - Clean tagCode in case that error was disregarded. - Add tests for checking if span contains error.
|
Updated and ready for review again. |
gbbr
added
bug
mingrammer
pushed a commit
to mingrammer/dd-trace-go
that referenced
this pull request
Dec 22, 2020
…DataDog#396) - Put finishWithError calls inside clojure functions because the deferred function's arguments are evaluated when the defer statement is evaluated. More at https://golang.org/doc/effective_go.html#defer Before this commit, `finishWithError` deferred with nil error and any other changes of the initial value were not added to span. This bug affects only grpc streaming. - Clean tagCode in case that error was disregarded. - Add tests for checking if span contains error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
finishWithErrorcalls inside closure functions because the deferredfunction's arguments are evaluated when the defer statement is
evaluated. More at https://golang.org/doc/effective_go.html#defer
Before this commit,
finishWithErrordeferred with nil error (initial value)and any other changes of the initial value were not added to span. This bug
affects only grpc streaming.
tagCodein case of disregarded error.