grpc: Use provided service name for all spans #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conorbranagan
force-pushed
the
conor/grpc-server
branch
from
53fd830
to
4e79a73
Compare
LotharSee
reviewed
May 15, 2017
tracer/contrib/tracegrpc/grpc.go
Outdated
| service = method[start:idx] | ||
| method = method[idx+1:] | ||
| return service, method | ||
| return method[idx+1:] |
There was a problem hiding this comment.
If we put all behind the same service, I guess we could keep the entire method as a resource name.
conorbranagan
force-pushed
the
conor/grpc-server
branch
from
16e3ad1
to
f3e02e9
Compare
clutchski
approved these changes
May 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were parsing the service from the rpc endpoint but we were never actually using the service name that was provided.
Note that while the API doesn't change this will rename every service so we may want make this an option instead to enable it going forward. I'm open to whichever is preferred!