Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add meta about lang in the payload header #98

Merged
merged 3 commits into from
Aug 3, 2017
Merged

Add meta about lang in the payload header #98

merged 3 commits into from
Aug 3, 2017

Conversation

gabsn
Copy link

@gabsn gabsn commented Aug 2, 2017 •
edited by palazzem
Loading

Adds the following headers so that Trace Agent can report it as a metrics:

            'Datadog-Meta-Lang': 'go',
            'Datadog-Meta-Lang-Version': 'go1.7',
            'Datadog-Meta-Lang-Interpreter': 'gc',
            'Datadog-Meta-Tracer-Version': 'v0.5.0',

@gabsn gabsn requested a review from talwai August 2, 2017 18:27
@palazzem palazzem self-requested a review August 3, 2017 07:46
palazzem
palazzem reviewed Aug 3, 2017
View reviewed changes
tracer/ext/tracer.go Outdated

const (
Lang = "go"
Interpreter = runtime.Compiler
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at this https://golang.org/pkg/runtime/#pkg-constants, it seems that GOARCH and GOOS are more interesting that Compiler. Can you use both?

Copy link
Author

@gabsn gabsn Aug 3, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can concatenate them like this: gc_linux But I'm not sure adding amd64 will be helpful, it'll just add noise.

tracer/ext/tracer.go Outdated
const (
Lang = "go"
Interpreter = runtime.Compiler
TracerVersion = "v0.5.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Side note: we should remember to update this value after each release, so it may be better to write this somewhere.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, should we put it in the readme?

palazzem
palazzem approved these changes Aug 3, 2017
View reviewed changes
Copy link
Contributor

@palazzem palazzem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Let's merge it and cut a "release" after we tested it. Thank you!

tracer/ext/tracer.go Outdated

const (
Lang = "go"
Interpreter = runtime.Compiler + "_" + runtime.GOOS + "_" + runtime.GOARCH
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@gabsn gabsn merged commit 9cb9c5d into master Aug 3, 2017
@palazzem palazzem deleted the gabin/meta branch August 7, 2017 07:46
@palazzem palazzem added this to the 0.5.1 milestone Sep 22, 2017
jdgordon pushed a commit to jdgordon/dd-trace-go that referenced this pull request May 31, 2022
@yutachaos @arbll
fix a few typos (DataDog#98)
a6cca73
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palazzem palazzem palazzem approved these changes

@talwai talwai Awaiting requested review from talwai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.5.1
Development

Successfully merging this pull request may close these issues.
2 participants
@gabsn @palazzem