Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move resolveEvaluateAt method to CapturedContext #5060

Merged
merged 1 commit into from
Apr 12, 2023
Merged

move resolveEvaluateAt method to CapturedContext #5060

merged 1 commit into from
Apr 12, 2023

Conversation

jpbempel
Copy link
Member

What Does This Do

Motivation

#5048 (comment)

Additional Notes

@jpbempel jpbempel added tag: no release notes Changes to exclude from release notes type: refactoring comp: debugger Dynamic Instrumentation labels Apr 12, 2023
@jpbempel jpbempel requested a review from a team as a code owner April 12, 2023 18:15
@jpbempel jpbempel requested review from shatzi and removed request for a team April 12, 2023 18:15
shatzi
shatzi approved these changes Apr 12, 2023
View reviewed changes
Copy link
Contributor

@shatzi shatzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@jpbempel jpbempel merged commit f36b046 into master Apr 12, 2023
@jpbempel jpbempel deleted the jpbempel/refacto-resolve-evaluateat branch April 12, 2023 20:45
@github-actions github-actions bot added this to the 1.12.0 milestone Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shatzi shatzi shatzi approved these changes

Assignees
No one assigned
Labels
comp: debugger Dynamic Instrumentation tag: no release notes Changes to exclude from release notes type: refactoring
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jpbempel @shatzi