Upgrade to ddprof 0.79.0 #5965

richardstartin · 2023-09-29T12:24:17Z

What Does This Do

Contains miscellaneous minor bug fixes

Motivation

Additional Notes

pr-commenter · 2023-09-29T13:09:58Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
commit	1.22.0-SNAPSHOT~531a4830ac	1.22.0-SNAPSHOT~a7de06f368
config	baseline	candidate

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
module	Agent	Agent
parent	None	None
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 62 cases.

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.22.0-SNAPSHOT~a7de06f368, baseline=1.22.0-SNAPSHOT~531a4830ac

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.004 s) : 0, 1003746
Total [baseline] (8.639 s) : 0, 8638532
Agent [candidate] (1.021 s) : 0, 1020708
Total [candidate] (8.656 s) : 0, 8656389
section appsec
Agent [baseline] (1.102 s) : 0, 1101827
Total [baseline] (8.735 s) : 0, 8734855
Agent [candidate] (1.095 s) : 0, 1095021
Total [candidate] (8.721 s) : 0, 8721489
section iast
Agent [baseline] (1.141 s) : 0, 1140801
Total [baseline] (9.277 s) : 0, 9276779
Agent [candidate] (1.141 s) : 0, 1141207
Total [candidate] (9.267 s) : 0, 9267480
section profiling
Agent [baseline] (1.184 s) : 0, 1183894
Total [baseline] (8.893 s) : 0, 8892658
Agent [candidate] (1.184 s) : 0, 1184418
Total [candidate] (8.914 s) : 0, 8914052

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.004 s	-
Agent	appsec	1.102 s	98.081 ms (9.8%)
Agent	iast	1.141 s	137.055 ms (13.7%)
Agent	profiling	1.184 s	180.148 ms (17.9%)
Total	tracing	8.639 s	-
Total	appsec	8.735 s	96.323 ms (1.1%)
Total	iast	9.277 s	638.246 ms (7.4%)
Total	profiling	8.893 s	254.126 ms (2.9%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.021 s	-
Agent	appsec	1.095 s	74.313 ms (7.3%)
Agent	iast	1.141 s	120.499 ms (11.8%)
Agent	profiling	1.184 s	163.71 ms (16.0%)
Total	tracing	8.656 s	-
Total	appsec	8.721 s	65.099 ms (0.8%)
Total	iast	9.267 s	611.091 ms (7.1%)
Total	profiling	8.914 s	257.663 ms (3.0%)

gantt
    title insecure-bank - break down per module: candidate=1.22.0-SNAPSHOT~a7de06f368, baseline=1.22.0-SNAPSHOT~531a4830ac

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (621.923 ms) : 0, 621923
BytebuddyAgent [candidate] (631.714 ms) : 0, 631714
GlobalTracer [baseline] (292.15 ms) : 0, 292150
GlobalTracer [candidate] (297.764 ms) : 0, 297764
AppSec [baseline] (48.862 ms) : 0, 48862
AppSec [candidate] (49.682 ms) : 0, 49682
Remote Config [baseline] (662.617 µs) : 0, 663
Remote Config [candidate] (695.604 µs) : 0, 696
Telemetry [baseline] (5.964 ms) : 0, 5964
Telemetry [candidate] (6.077 ms) : 0, 6077
section appsec
BytebuddyAgent [baseline] (628.37 ms) : 0, 628370
BytebuddyAgent [candidate] (623.43 ms) : 0, 623430
GlobalTracer [baseline] (294.439 ms) : 0, 294439
GlobalTracer [candidate] (293.34 ms) : 0, 293340
AppSec [baseline] (137.925 ms) : 0, 137925
AppSec [candidate] (137.607 ms) : 0, 137607
Remote Config [baseline] (654.681 µs) : 0, 655
Remote Config [candidate] (649.905 µs) : 0, 650
Telemetry [baseline] (5.88 ms) : 0, 5880
Telemetry [candidate] (5.783 ms) : 0, 5783
section iast
BytebuddyAgent [baseline] (754.958 ms) : 0, 754958
BytebuddyAgent [candidate] (754.651 ms) : 0, 754651
GlobalTracer [baseline] (282.276 ms) : 0, 282276
GlobalTracer [candidate] (282.44 ms) : 0, 282440
AppSec [baseline] (47.001 ms) : 0, 47001
AppSec [candidate] (47.742 ms) : 0, 47742
Remote Config [baseline] (572.091 µs) : 0, 572
Remote Config [candidate] (571.769 µs) : 0, 572
Telemetry [baseline] (5.891 ms) : 0, 5891
Telemetry [candidate] (5.896 ms) : 0, 5896
IAST [baseline] (14.745 ms) : 0, 14745
IAST [candidate] (14.668 ms) : 0, 14668
section profiling
BytebuddyAgent [baseline] (638.566 ms) : 0, 638566
BytebuddyAgent [candidate] (639.297 ms) : 0, 639297
GlobalTracer [baseline] (355.388 ms) : 0, 355388
GlobalTracer [candidate] (355.331 ms) : 0, 355331
AppSec [baseline] (49.072 ms) : 0, 49072
AppSec [candidate] (49.0 ms) : 0, 49000
Remote Config [baseline] (648.691 µs) : 0, 649
Remote Config [candidate] (653.44 µs) : 0, 653
Telemetry [baseline] (6.141 ms) : 0, 6141
Telemetry [candidate] (6.114 ms) : 0, 6114
ProfilingAgent [baseline] (80.716 ms) : 0, 80716
ProfilingAgent [candidate] (81.156 ms) : 0, 81156
Profiling [baseline] (80.74 ms) : 0, 80740
Profiling [candidate] (81.18 ms) : 0, 81180

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.22.0-SNAPSHOT~a7de06f368, baseline=1.22.0-SNAPSHOT~531a4830ac

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.004 s) : 0, 1004094
Total [baseline] (9.191 s) : 0, 9190846
Agent [candidate] (1.014 s) : 0, 1013571
Total [candidate] (9.205 s) : 0, 9205320
section appsec
Agent [baseline] (1.094 s) : 0, 1093768
Total [baseline] (9.356 s) : 0, 9356387
Agent [candidate] (1.092 s) : 0, 1091688
Total [candidate] (9.288 s) : 0, 9288451
section iast
Agent [baseline] (1.129 s) : 0, 1129363
Total [baseline] (9.424 s) : 0, 9424401
Agent [candidate] (1.118 s) : 0, 1118280
Total [candidate] (9.414 s) : 0, 9414382
section profiling
Agent [baseline] (1.186 s) : 0, 1186050
Total [baseline] (9.477 s) : 0, 9477279
Agent [candidate] (1.18 s) : 0, 1179692
Total [candidate] (9.435 s) : 0, 9434516

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.004 s	-
Agent	appsec	1.094 s	89.674 ms (8.9%)
Agent	iast	1.129 s	125.269 ms (12.5%)
Agent	profiling	1.186 s	181.956 ms (18.1%)
Total	tracing	9.191 s	-
Total	appsec	9.356 s	165.541 ms (1.8%)
Total	iast	9.424 s	233.555 ms (2.5%)
Total	profiling	9.477 s	286.433 ms (3.1%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.014 s	-
Agent	appsec	1.092 s	78.117 ms (7.7%)
Agent	iast	1.118 s	104.71 ms (10.3%)
Agent	profiling	1.18 s	166.121 ms (16.4%)
Total	tracing	9.205 s	-
Total	appsec	9.288 s	83.131 ms (0.9%)
Total	iast	9.414 s	209.062 ms (2.3%)
Total	profiling	9.435 s	229.195 ms (2.5%)

gantt
    title petclinic - break down per module: candidate=1.22.0-SNAPSHOT~a7de06f368, baseline=1.22.0-SNAPSHOT~531a4830ac

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (622.392 ms) : 0, 622392
BytebuddyAgent [candidate] (627.652 ms) : 0, 627652
GlobalTracer [baseline] (292.062 ms) : 0, 292062
GlobalTracer [candidate] (295.434 ms) : 0, 295434
AppSec [baseline] (48.726 ms) : 0, 48726
AppSec [candidate] (49.286 ms) : 0, 49286
Remote Config [baseline] (675.692 µs) : 0, 676
Remote Config [candidate] (672.982 µs) : 0, 673
Telemetry [baseline] (6.014 ms) : 0, 6014
Telemetry [candidate] (6.034 ms) : 0, 6034
section appsec
BytebuddyAgent [baseline] (623.61 ms) : 0, 623610
BytebuddyAgent [candidate] (621.248 ms) : 0, 621248
GlobalTracer [baseline] (292.456 ms) : 0, 292456
GlobalTracer [candidate] (292.408 ms) : 0, 292408
AppSec [baseline] (137.071 ms) : 0, 137071
AppSec [candidate] (137.543 ms) : 0, 137543
Remote Config [baseline] (652.673 µs) : 0, 653
Remote Config [candidate] (645.046 µs) : 0, 645
Telemetry [baseline] (5.796 ms) : 0, 5796
Telemetry [candidate] (5.77 ms) : 0, 5770
section iast
BytebuddyAgent [baseline] (747.059 ms) : 0, 747059
BytebuddyAgent [candidate] (738.781 ms) : 0, 738781
GlobalTracer [baseline] (279.689 ms) : 0, 279689
GlobalTracer [candidate] (277.644 ms) : 0, 277644
AppSec [baseline] (46.72 ms) : 0, 46720
AppSec [candidate] (46.479 ms) : 0, 46479
Remote Config [baseline] (560.896 µs) : 0, 561
Remote Config [candidate] (557.651 µs) : 0, 558
Telemetry [baseline] (5.823 ms) : 0, 5823
Telemetry [candidate] (5.789 ms) : 0, 5789
IAST [baseline] (14.523 ms) : 0, 14523
IAST [candidate] (14.377 ms) : 0, 14377
section profiling
BytebuddyAgent [baseline] (639.049 ms) : 0, 639049
BytebuddyAgent [candidate] (636.471 ms) : 0, 636471
GlobalTracer [baseline] (355.193 ms) : 0, 355193
GlobalTracer [candidate] (353.31 ms) : 0, 353310
AppSec [baseline] (49.643 ms) : 0, 49643
AppSec [candidate] (49.355 ms) : 0, 49355
Remote Config [baseline] (665.432 µs) : 0, 665
Remote Config [candidate] (644.845 µs) : 0, 645
Telemetry [baseline] (6.183 ms) : 0, 6183
Telemetry [candidate] (6.1 ms) : 0, 6100
ProfilingAgent [baseline] (81.789 ms) : 0, 81789
ProfilingAgent [candidate] (80.784 ms) : 0, 80784
Profiling [baseline] (81.814 ms) : 0, 81814
Profiling [candidate] (80.808 ms) : 0, 80808

Load

Parameters

	Baseline	Candidate
commit	1.22.0-SNAPSHOT~531a4830ac	1.22.0-SNAPSHOT~a7de06f368
config	baseline	candidate
end_time	2023-09-29T12:46:39	2023-09-29T13:04:45
start_time	2023-09-29T12:46:20	2023-09-29T13:04:27

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 cases.

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.22.0-SNAPSHOT~a7de06f368, baseline=1.22.0-SNAPSHOT~531a4830ac
    dateFormat X
    axisFormat %s
section baseline
no_agent (360.363 µs) : 340, 381
.   : milestone, 360,
appsec (698.864 µs) : 678, 720
.   : milestone, 699,
iast (453.968 µs) : 433, 475
.   : milestone, 454,
iast_FULL (522.23 µs) : 501, 543
.   : milestone, 522,
iast_INACTIVE (430.876 µs) : 410, 452
.   : milestone, 431,
profiling (438.225 µs) : 418, 459
.   : milestone, 438,
tracing (428.092 µs) : 407, 449
.   : milestone, 428,
section candidate
no_agent (366.93 µs) : 345, 389
.   : milestone, 367,
appsec (681.108 µs) : 661, 701
.   : milestone, 681,
iast (454.547 µs) : 434, 475
.   : milestone, 455,
iast_FULL (520.924 µs) : 500, 542
.   : milestone, 521,
iast_INACTIVE (429.666 µs) : 409, 450
.   : milestone, 430,
profiling (433.864 µs) : 413, 455
.   : milestone, 434,
tracing (427.668 µs) : 407, 448
.   : milestone, 428,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	360.363 µs [339.855 µs, 380.87 µs]	-
appsec	698.864 µs [678.121 µs, 719.608 µs]	338.502 µs (93.9%)
iast	453.968 µs [433.132 µs, 474.803 µs]	93.605 µs (26.0%)
iast_FULL	522.23 µs [501.444 µs, 543.017 µs]	161.868 µs (44.9%)
iast_INACTIVE	430.876 µs [409.715 µs, 452.036 µs]	70.513 µs (19.6%)
profiling	438.225 µs [417.714 µs, 458.737 µs]	77.863 µs (21.6%)
tracing	428.092 µs [407.359 µs, 448.825 µs]	67.73 µs (18.8%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	366.93 µs [345.101 µs, 388.76 µs]	-
appsec	681.108 µs [660.948 µs, 701.268 µs]	314.178 µs (85.6%)
iast	454.547 µs [433.612 µs, 475.482 µs]	87.617 µs (23.9%)
iast_FULL	520.924 µs [500.302 µs, 541.547 µs]	153.994 µs (42.0%)
iast_INACTIVE	429.666 µs [408.924 µs, 450.407 µs]	62.735 µs (17.1%)
profiling	433.864 µs [412.822 µs, 454.907 µs]	66.934 µs (18.2%)
tracing	427.668 µs [407.001 µs, 448.334 µs]	60.737 µs (16.6%)

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.22.0-SNAPSHOT~a7de06f368, baseline=1.22.0-SNAPSHOT~531a4830ac
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.323 ms) : 1304, 1342
.   : milestone, 1323,
appsec (1.695 ms) : 1670, 1719
.   : milestone, 1695,
iast (1.46 ms) : 1436, 1484
.   : milestone, 1460,
profiling (1.481 ms) : 1455, 1507
.   : milestone, 1481,
tracing (1.466 ms) : 1442, 1490
.   : milestone, 1466,
section candidate
no_agent (1.335 ms) : 1316, 1354
.   : milestone, 1335,
appsec (1.648 ms) : 1624, 1672
.   : milestone, 1648,
iast (1.445 ms) : 1420, 1469
.   : milestone, 1445,
profiling (1.457 ms) : 1432, 1481
.   : milestone, 1457,
tracing (1.437 ms) : 1413, 1461
.   : milestone, 1437,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.323 ms [1.304 ms, 1.342 ms]	-
appsec	1.695 ms [1.67 ms, 1.719 ms]	371.466 µs (28.1%)
iast	1.46 ms [1.436 ms, 1.484 ms]	137.039 µs (10.4%)
profiling	1.481 ms [1.455 ms, 1.507 ms]	157.558 µs (11.9%)
tracing	1.466 ms [1.442 ms, 1.49 ms]	143.016 µs (10.8%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.335 ms [1.316 ms, 1.354 ms]	-
appsec	1.648 ms [1.624 ms, 1.672 ms]	312.714 µs (23.4%)
iast	1.445 ms [1.42 ms, 1.469 ms]	109.697 µs (8.2%)
profiling	1.457 ms [1.432 ms, 1.481 ms]	121.739 µs (9.1%)
tracing	1.437 ms [1.413 ms, 1.461 ms]	102.239 µs (7.7%)

Upgrade to ddprof 0.79.0

a7de06f

richardstartin requested a review from a team as a code owner September 29, 2023 12:24

richardstartin requested review from mcculls, PerfectSlayer and a team September 29, 2023 12:24

jbachorik approved these changes Sep 29, 2023

View reviewed changes

richardstartin merged commit 86ca385 into master Sep 29, 2023
70 checks passed

richardstartin deleted the rgs/ddprof-0.79.0 branch September 29, 2023 13:16

github-actions bot added this to the 1.22.0 milestone Sep 29, 2023

PerfectSlayer added tag: dependencies Dependencies related changes comp: profiling Profiling labels Sep 29, 2023

richardstartin removed the tag: dependencies Dependencies related changes label Oct 3, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade to ddprof 0.79.0 #5965

Upgrade to ddprof 0.79.0 #5965

richardstartin commented Sep 29, 2023

pr-commenter bot commented Sep 29, 2023

Upgrade to ddprof 0.79.0 #5965

Upgrade to ddprof 0.79.0 #5965

Conversation

richardstartin commented Sep 29, 2023

What Does This Do

Motivation

Additional Notes

pr-commenter bot commented Sep 29, 2023

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary