Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip attaching the tracer to the keytool command #6096

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Skip attaching the tracer to the keytool command #6096

merged 1 commit into from
Oct 25, 2023

Conversation

mcculls
Copy link
Contributor

@mcculls mcculls commented Oct 25, 2023 •
edited by jira bot
Loading

What Does This Do

Be more explicit about which JDK tools we won't attach the tracer to.

Motivation

Reduces log-spam by not tracing non-interesting tools like keytool

Jira ticket: APMS-10600

@mcculls mcculls added the comp: core Tracer core label Oct 25, 2023
@mcculls mcculls marked this pull request as ready for review October 25, 2023 11:35
@mcculls mcculls requested a review from a team as a code owner October 25, 2023 11:35
@pr-commenter
Copy link

pr-commenter bot commented Oct 25, 2023

Benchmarks

Startup

Parameters

Baseline Candidate
commit 1.22.0-SNAPSHOT~3f834156e4 1.22.0-SNAPSHOT~45c8c0ca3a
config baseline candidate
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 54 cases.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.22.0-SNAPSHOT~45c8c0ca3a, baseline=1.22.0-SNAPSHOT~3f834156e4

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.028 s) : 0, 1028331
Total [baseline] (9.275 s) : 0, 9275307
Agent [candidate] (1.022 s) : 0, 1021851
Total [candidate] (9.214 s) : 0, 9214255
section appsec
Agent [baseline] (1.112 s) : 0, 1111564
Total [baseline] (9.34 s) : 0, 9339799
Agent [candidate] (1.111 s) : 0, 1110673
Total [candidate] (9.336 s) : 0, 9335718
section iast
Agent [baseline] (1.145 s) : 0, 1145091
Total [baseline] (9.4 s) : 0, 9399732
Agent [candidate] (1.149 s) : 0, 1148523
Total [candidate] (9.458 s) : 0, 9457831
section profiling
Agent [baseline] (1.199 s) : 0, 1199011
Total [baseline] (9.507 s) : 0, 9507353
Agent [candidate] (1.198 s) : 0, 1197511
Total [candidate] (9.5 s) : 0, 9500124
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.028 s -
Agent appsec 1.112 s 83.232 ms (8.1%)
Agent iast 1.145 s 116.76 ms (11.4%)
Agent profiling 1.199 s 170.679 ms (16.6%)
Total tracing 9.275 s -
Total appsec 9.34 s 64.492 ms (0.7%)
Total iast 9.4 s 124.425 ms (1.3%)
Total profiling 9.507 s 232.046 ms (2.5%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.022 s -
Agent appsec 1.111 s 88.822 ms (8.7%)
Agent iast 1.149 s 126.672 ms (12.4%)
Agent profiling 1.198 s 175.66 ms (17.2%)
Total tracing 9.214 s -
Total appsec 9.336 s 121.463 ms (1.3%)
Total iast 9.458 s 243.576 ms (2.6%)
Total profiling 9.5 s 285.868 ms (3.1%) 
gantt
    title petclinic - break down per module: candidate=1.22.0-SNAPSHOT~45c8c0ca3a, baseline=1.22.0-SNAPSHOT~3f834156e4

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (642.698 ms) : 0, 642698
BytebuddyAgent [candidate] (637.965 ms) : 0, 637965
GlobalTracer [baseline] (294.797 ms) : 0, 294797
GlobalTracer [candidate] (293.578 ms) : 0, 293578
AppSec [baseline] (49.432 ms) : 0, 49432
AppSec [candidate] (49.117 ms) : 0, 49117
Remote Config [baseline] (684.636 µs) : 0, 685
Remote Config [candidate] (675.752 µs) : 0, 676
Telemetry [baseline] (6.107 ms) : 0, 6107
Telemetry [candidate] (6.1 ms) : 0, 6100
section appsec
BytebuddyAgent [baseline] (639.234 ms) : 0, 639234
BytebuddyAgent [candidate] (639.26 ms) : 0, 639260
GlobalTracer [baseline] (293.119 ms) : 0, 293119
GlobalTracer [candidate] (293.272 ms) : 0, 293272
AppSec [baseline] (138.442 ms) : 0, 138442
AppSec [candidate] (137.324 ms) : 0, 137324
Remote Config [baseline] (654.42 µs) : 0, 654
Remote Config [candidate] (671.594 µs) : 0, 672
Telemetry [baseline] (5.743 ms) : 0, 5743
Telemetry [candidate] (5.715 ms) : 0, 5715
section iast
BytebuddyAgent [baseline] (766.088 ms) : 0, 766088
BytebuddyAgent [candidate] (767.744 ms) : 0, 767744
GlobalTracer [baseline] (271.51 ms) : 0, 271510
GlobalTracer [candidate] (273.745 ms) : 0, 273745
AppSec [baseline] (47.612 ms) : 0, 47612
AppSec [candidate] (47.595 ms) : 0, 47595
Remote Config [baseline] (577.87 µs) : 0, 578
Remote Config [candidate] (593.174 µs) : 0, 593
Telemetry [baseline] (7.56 ms) : 0, 7560
Telemetry [candidate] (7.558 ms) : 0, 7558
IAST [baseline] (17.301 ms) : 0, 17301
IAST [candidate] (16.716 ms) : 0, 16716
section profiling
BytebuddyAgent [baseline] (652.289 ms) : 0, 652289
BytebuddyAgent [candidate] (651.278 ms) : 0, 651278
GlobalTracer [baseline] (356.756 ms) : 0, 356756
GlobalTracer [candidate] (355.454 ms) : 0, 355454
AppSec [baseline] (49.554 ms) : 0, 49554
AppSec [candidate] (49.624 ms) : 0, 49624
Remote Config [baseline] (657.108 µs) : 0, 657
Remote Config [candidate] (649.556 µs) : 0, 650
Telemetry [baseline] (6.026 ms) : 0, 6026
Telemetry [candidate] (6.064 ms) : 0, 6064
ProfilingAgent [baseline] (80.073 ms) : 0, 80073
ProfilingAgent [candidate] (81.156 ms) : 0, 81156
Profiling [baseline] (80.097 ms) : 0, 80097
Profiling [candidate] (81.181 ms) : 0, 81181
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.22.0-SNAPSHOT~45c8c0ca3a, baseline=1.22.0-SNAPSHOT~3f834156e4

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.029 s) : 0, 1029371
Total [baseline] (8.723 s) : 0, 8722711
Agent [candidate] (1.025 s) : 0, 1024996
Total [candidate] (8.689 s) : 0, 8689324
section iast
Agent [baseline] (1.153 s) : 0, 1152505
Total [baseline] (9.293 s) : 0, 9292739
Agent [candidate] (1.148 s) : 0, 1148346
Total [candidate] (9.256 s) : 0, 9256500
section iast_TELEMETRY_OFF
Agent [baseline] (1.137 s) : 0, 1136721
Total [baseline] (9.203 s) : 0, 9202969
Agent [candidate] (1.142 s) : 0, 1142114
Total [candidate] (9.233 s) : 0, 9233472
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.029 s -
Agent iast 1.153 s 123.134 ms (12.0%)
Agent iast_TELEMETRY_OFF 1.137 s 107.35 ms (10.4%)
Total tracing 8.723 s -
Total iast 9.293 s 570.027 ms (6.5%)
Total iast_TELEMETRY_OFF 9.203 s 480.257 ms (5.5%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.025 s -
Agent iast 1.148 s 123.35 ms (12.0%)
Agent iast_TELEMETRY_OFF 1.142 s 117.118 ms (11.4%)
Total tracing 8.689 s -
Total iast 9.256 s 567.175 ms (6.5%)
Total iast_TELEMETRY_OFF 9.233 s 544.148 ms (6.3%) 
gantt
    title insecure-bank - break down per module: candidate=1.22.0-SNAPSHOT~45c8c0ca3a, baseline=1.22.0-SNAPSHOT~3f834156e4

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (642.781 ms) : 0, 642781
BytebuddyAgent [candidate] (640.627 ms) : 0, 640627
GlobalTracer [baseline] (295.304 ms) : 0, 295304
GlobalTracer [candidate] (293.58 ms) : 0, 293580
AppSec [baseline] (49.685 ms) : 0, 49685
AppSec [candidate] (49.473 ms) : 0, 49473
Remote Config [baseline] (704.871 µs) : 0, 705
Remote Config [candidate] (681.247 µs) : 0, 681
Telemetry [baseline] (6.152 ms) : 0, 6152
Telemetry [candidate] (6.09 ms) : 0, 6090
section iast
BytebuddyAgent [baseline] (771.559 ms) : 0, 771559
BytebuddyAgent [candidate] (767.128 ms) : 0, 767128
GlobalTracer [baseline] (273.305 ms) : 0, 273305
GlobalTracer [candidate] (272.587 ms) : 0, 272587
AppSec [baseline] (47.375 ms) : 0, 47375
AppSec [candidate] (49.267 ms) : 0, 49267
IAST [baseline] (17.515 ms) : 0, 17515
IAST [candidate] (16.102 ms) : 0, 16102
Remote Config [baseline] (591.171 µs) : 0, 591
Remote Config [candidate] (589.484 µs) : 0, 589
Telemetry [baseline] (7.651 ms) : 0, 7651
Telemetry [candidate] (8.236 ms) : 0, 8236
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (759.918 ms) : 0, 759918
BytebuddyAgent [candidate] (761.939 ms) : 0, 761939
GlobalTracer [baseline] (272.116 ms) : 0, 272116
GlobalTracer [candidate] (273.981 ms) : 0, 273981
AppSec [baseline] (45.976 ms) : 0, 45976
AppSec [candidate] (46.496 ms) : 0, 46496
IAST [baseline] (15.499 ms) : 0, 15499
IAST [candidate] (16.293 ms) : 0, 16293
Remote Config [baseline] (616.165 µs) : 0, 616
Remote Config [candidate] (583.516 µs) : 0, 584
Telemetry [baseline] (8.213 ms) : 0, 8213
Telemetry [candidate] (8.366 ms) : 0, 8366
Loading

Load

Parameters

Baseline Candidate
commit 1.22.0-SNAPSHOT~3f834156e4 1.22.0-SNAPSHOT~45c8c0ca3a
config baseline candidate
end_time 2023-10-25T11:43:12 2023-10-25T11:59:28
start_time 2023-10-25T11:42:59 2023-10-25T11:59:16
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 22 cases.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.22.0-SNAPSHOT~45c8c0ca3a, baseline=1.22.0-SNAPSHOT~3f834156e4
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.35 ms) : 1331, 1369
.   : milestone, 1350,
appsec (1.697 ms) : 1673, 1721
.   : milestone, 1697,
iast (1.446 ms) : 1422, 1470
.   : milestone, 1446,
profiling (1.458 ms) : 1433, 1482
.   : milestone, 1458,
tracing (1.459 ms) : 1434, 1483
.   : milestone, 1459,
section candidate
no_agent (1.32 ms) : 1301, 1339
.   : milestone, 1320,
appsec (1.707 ms) : 1682, 1731
.   : milestone, 1707,
iast (1.441 ms) : 1416, 1465
.   : milestone, 1441,
profiling (1.457 ms) : 1432, 1482
.   : milestone, 1457,
tracing (1.442 ms) : 1418, 1467
.   : milestone, 1442,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.35 ms [1.331 ms, 1.369 ms] -
appsec 1.697 ms [1.673 ms, 1.721 ms] 347.026 µs (25.7%)
iast 1.446 ms [1.422 ms, 1.47 ms] 96.174 µs (7.1%)
profiling 1.458 ms [1.433 ms, 1.482 ms] 107.853 µs (8.0%)
tracing 1.459 ms [1.434 ms, 1.483 ms] 108.882 µs (8.1%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.32 ms [1.301 ms, 1.339 ms] -
appsec 1.707 ms [1.682 ms, 1.731 ms] 387.149 µs (29.3%)
iast 1.441 ms [1.416 ms, 1.465 ms] 120.856 µs (9.2%)
profiling 1.457 ms [1.432 ms, 1.482 ms] 137.07 µs (10.4%)
tracing 1.442 ms [1.418 ms, 1.467 ms] 122.545 µs (9.3%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.22.0-SNAPSHOT~45c8c0ca3a, baseline=1.22.0-SNAPSHOT~3f834156e4
    dateFormat X
    axisFormat %s
section baseline
no_agent (360.873 µs) : 340, 382
.   : milestone, 361,
iast (457.666 µs) : 437, 478
.   : milestone, 458,
iast_FULL (527.254 µs) : 507, 548
.   : milestone, 527,
iast_INACTIVE (428.614 µs) : 408, 449
.   : milestone, 429,
iast_TELEMETRY_OFF (451.453 µs) : 431, 472
.   : milestone, 451,
tracing (426.311 µs) : 405, 447
.   : milestone, 426,
section candidate
no_agent (362.326 µs) : 342, 382
.   : milestone, 362,
iast (457.181 µs) : 437, 478
.   : milestone, 457,
iast_FULL (514.213 µs) : 494, 535
.   : milestone, 514,
iast_INACTIVE (431.459 µs) : 411, 452
.   : milestone, 431,
iast_TELEMETRY_OFF (453.035 µs) : 432, 474
.   : milestone, 453,
tracing (435.032 µs) : 414, 456
.   : milestone, 435,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 360.873 µs [339.697 µs, 382.048 µs] -
iast 457.666 µs [437.047 µs, 478.285 µs] 96.794 µs (26.8%)
iast_FULL 527.254 µs [506.71 µs, 547.798 µs] 166.381 µs (46.1%)
iast_INACTIVE 428.614 µs [407.943 µs, 449.285 µs] 67.742 µs (18.8%)
iast_TELEMETRY_OFF 451.453 µs [430.944 µs, 471.961 µs] 90.58 µs (25.1%)
tracing 426.311 µs [405.16 µs, 447.461 µs] 65.438 µs (18.1%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 362.326 µs [342.498 µs, 382.154 µs] -
iast 457.181 µs [436.51 µs, 477.851 µs] 94.855 µs (26.2%)
iast_FULL 514.213 µs [493.792 µs, 534.635 µs] 151.888 µs (41.9%)
iast_INACTIVE 431.459 µs [410.51 µs, 452.408 µs] 69.133 µs (19.1%)
iast_TELEMETRY_OFF 453.035 µs [431.799 µs, 474.272 µs] 90.71 µs (25.0%)
tracing 435.032 µs [413.621 µs, 456.442 µs] 72.706 µs (20.1%)

@mcculls mcculls merged commit 1e70cdd into master Oct 25, 2023
71 checks passed
@mcculls mcculls deleted the mcculls/dont-trace-jdk-keytool branch October 25, 2023 12:14
@github-actions github-actions bot added this to the 1.22.0 milestone Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smola smola smola approved these changes

@bantonsson bantonsson bantonsson approved these changes

@ygree ygree Awaiting requested review from ygree ygree is a code owner automatically assigned from DataDog/apm-java

Assignees
No one assigned
Labels
comp: core Tracer core
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mcculls @smola @bantonsson