Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Environment variable to activate SCA #6902

Merged
merged 5 commits into from
Apr 22, 2024
Merged

Environment variable to activate SCA #6902

merged 5 commits into from
Apr 22, 2024

Conversation

jandro996
Copy link
Member

@jandro996 jandro996 commented Apr 12, 2024 •
edited by smola
Loading

What Does This Do

Add Environment variable to activate SCA

Log warning if SCA is enabled but telemetry disabled

Motivation

Customers need a way to enable AVM OSS via an environment variable, just as they enable APM or other products or features, instead of having to do it exclusively through the UI.

Additional Notes

Jira ticket: APPSEC-10460

@pr-commenter
Copy link

pr-commenter bot commented Apr 12, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master alejandro.gonzalez/Environment-variable-to-activate-SCA
git_commit_date 1713460719 1713503990
git_commit_sha 23a819a 3e86513
release_version 1.34.0-SNAPSHOT~23a819aa79 1.34.0-SNAPSHOT~3e86513218
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1713506582 1713506582
ci_job_id 491294926 491294926
ci_pipeline_id 32472362 32472362
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 49 metrics, 14 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.34.0-SNAPSHOT~3e86513218, baseline=1.34.0-SNAPSHOT~23a819aa79

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.076 s) : 0, 1075878
Total [baseline] (10.389 s) : 0, 10388682
Agent [candidate] (1.076 s) : 0, 1075878
Total [candidate] (10.382 s) : 0, 10381757
section appsec
Agent [baseline] (1.189 s) : 0, 1188651
Total [baseline] (10.45 s) : 0, 10450175
Agent [candidate] (1.19 s) : 0, 1190276
Total [candidate] (10.547 s) : 0, 10547419
section iast
Agent [baseline] (1.201 s) : 0, 1201367
Total [baseline] (10.729 s) : 0, 10729011
Agent [candidate] (1.199 s) : 0, 1198838
Total [candidate] (10.78 s) : 0, 10779882
section profiling
Agent [baseline] (1.267 s) : 0, 1266669
Total [baseline] (10.643 s) : 0, 10642567
Agent [candidate] (1.27 s) : 0, 1269682
Total [candidate] (10.696 s) : 0, 10696270
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.076 s -
Agent appsec 1.189 s 112.773 ms (10.5%)
Agent iast 1.201 s 125.489 ms (11.7%)
Agent profiling 1.267 s 190.791 ms (17.7%)
Total tracing 10.389 s -
Total appsec 10.45 s 61.492 ms (0.6%)
Total iast 10.729 s 340.328 ms (3.3%)
Total profiling 10.643 s 253.885 ms (2.4%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.076 s -
Agent appsec 1.19 s 114.399 ms (10.6%)
Agent iast 1.199 s 122.96 ms (11.4%)
Agent profiling 1.27 s 193.805 ms (18.0%)
Total tracing 10.382 s -
Total appsec 10.547 s 165.662 ms (1.6%)
Total iast 10.78 s 398.125 ms (3.8%)
Total profiling 10.696 s 314.513 ms (3.0%) 
gantt
    title petclinic - break down per module: candidate=1.34.0-SNAPSHOT~3e86513218, baseline=1.34.0-SNAPSHOT~23a819aa79

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (673.853 ms) : 0, 673853
BytebuddyAgent [candidate] (673.637 ms) : 0, 673637
GlobalTracer [baseline] (309.51 ms) : 0, 309510
GlobalTracer [candidate] (309.75 ms) : 0, 309750
AppSec [baseline] (49.762 ms) : 0, 49762
AppSec [candidate] (49.785 ms) : 0, 49785
Remote Config [baseline] (658.979 µs) : 0, 659
Remote Config [candidate] (669.208 µs) : 0, 669
Telemetry [baseline] (7.659 ms) : 0, 7659
Telemetry [candidate] (7.681 ms) : 0, 7681
section appsec
BytebuddyAgent [baseline] (694.979 ms) : 0, 694979
BytebuddyAgent [candidate] (695.814 ms) : 0, 695814
GlobalTracer [baseline] (290.997 ms) : 0, 290997
GlobalTracer [candidate] (291.422 ms) : 0, 291422
AppSec [baseline] (149.735 ms) : 0, 149735
AppSec [candidate] (149.697 ms) : 0, 149697
IAST [baseline] (19.158 ms) : 0, 19158
IAST [candidate] (19.204 ms) : 0, 19204
Remote Config [baseline] (620.238 µs) : 0, 620
Remote Config [candidate] (617.596 µs) : 0, 618
Telemetry [baseline] (8.386 ms) : 0, 8386
Telemetry [candidate] (8.724 ms) : 0, 8724
section iast
BytebuddyAgent [baseline] (796.378 ms) : 0, 796378
BytebuddyAgent [candidate] (794.096 ms) : 0, 794096
GlobalTracer [baseline] (288.186 ms) : 0, 288186
GlobalTracer [candidate] (287.866 ms) : 0, 287866
AppSec [baseline] (48.842 ms) : 0, 48842
AppSec [candidate] (49.618 ms) : 0, 49618
IAST [baseline] (24.881 ms) : 0, 24881
IAST [candidate] (24.927 ms) : 0, 24927
Remote Config [baseline] (575.286 µs) : 0, 575
Remote Config [candidate] (573.2 µs) : 0, 573
Telemetry [baseline] (8.136 ms) : 0, 8136
Telemetry [candidate] (7.388 ms) : 0, 7388
section profiling
BytebuddyAgent [baseline] (676.834 ms) : 0, 676834
BytebuddyAgent [candidate] (678.437 ms) : 0, 678437
GlobalTracer [baseline] (379.424 ms) : 0, 379424
GlobalTracer [candidate] (380.529 ms) : 0, 380529
AppSec [baseline] (50.2 ms) : 0, 50200
AppSec [candidate] (50.082 ms) : 0, 50082
Remote Config [baseline] (703.99 µs) : 0, 704
Remote Config [candidate] (723.822 µs) : 0, 724
Telemetry [baseline] (7.472 ms) : 0, 7472
Telemetry [candidate] (7.494 ms) : 0, 7494
ProfilingAgent [baseline] (95.784 ms) : 0, 95784
ProfilingAgent [candidate] (96.04 ms) : 0, 96040
Profiling [baseline] (95.808 ms) : 0, 95808
Profiling [candidate] (96.064 ms) : 0, 96064
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.34.0-SNAPSHOT~3e86513218, baseline=1.34.0-SNAPSHOT~23a819aa79

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.073 s) : 0, 1073264
Total [baseline] (8.578 s) : 0, 8577558
Agent [candidate] (1.082 s) : 0, 1081585
Total [candidate] (8.532 s) : 0, 8531743
section iast
Agent [baseline] (1.198 s) : 0, 1198323
Total [baseline] (9.027 s) : 0, 9026938
Agent [candidate] (1.208 s) : 0, 1207877
Total [candidate] (9.045 s) : 0, 9044858
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.217 s) : 0, 1216857
Total [baseline] (9.003 s) : 0, 9002621
Agent [candidate] (1.208 s) : 0, 1207959
Total [candidate] (8.985 s) : 0, 8985189
section iast_TELEMETRY_OFF
Agent [baseline] (1.196 s) : 0, 1195569
Total [baseline] (8.997 s) : 0, 8997229
Agent [candidate] (1.202 s) : 0, 1202372
Total [candidate] (9.037 s) : 0, 9037404
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.073 s -
Agent iast 1.198 s 125.059 ms (11.7%)
Agent iast_HARDCODED_SECRET_DISABLED 1.217 s 143.593 ms (13.4%)
Agent iast_TELEMETRY_OFF 1.196 s 122.305 ms (11.4%)
Total tracing 8.578 s -
Total iast 9.027 s 449.38 ms (5.2%)
Total iast_HARDCODED_SECRET_DISABLED 9.003 s 425.062 ms (5.0%)
Total iast_TELEMETRY_OFF 8.997 s 419.67 ms (4.9%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.082 s -
Agent iast 1.208 s 126.291 ms (11.7%)
Agent iast_HARDCODED_SECRET_DISABLED 1.208 s 126.373 ms (11.7%)
Agent iast_TELEMETRY_OFF 1.202 s 120.787 ms (11.2%)
Total tracing 8.532 s -
Total iast 9.045 s 513.115 ms (6.0%)
Total iast_HARDCODED_SECRET_DISABLED 8.985 s 453.446 ms (5.3%)
Total iast_TELEMETRY_OFF 9.037 s 505.661 ms (5.9%) 
gantt
    title insecure-bank - break down per module: candidate=1.34.0-SNAPSHOT~3e86513218, baseline=1.34.0-SNAPSHOT~23a819aa79

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (672.46 ms) : 0, 672460
BytebuddyAgent [candidate] (677.652 ms) : 0, 677652
GlobalTracer [baseline] (308.741 ms) : 0, 308741
GlobalTracer [candidate] (310.933 ms) : 0, 310933
AppSec [baseline] (49.451 ms) : 0, 49451
AppSec [candidate] (49.956 ms) : 0, 49956
Remote Config [baseline] (657.976 µs) : 0, 658
Remote Config [candidate] (675.076 µs) : 0, 675
Telemetry [baseline] (7.668 ms) : 0, 7668
Telemetry [candidate] (7.797 ms) : 0, 7797
section iast
BytebuddyAgent [baseline] (793.927 ms) : 0, 793927
BytebuddyAgent [candidate] (800.495 ms) : 0, 800495
GlobalTracer [baseline] (287.854 ms) : 0, 287854
GlobalTracer [candidate] (289.863 ms) : 0, 289863
AppSec [baseline] (50.378 ms) : 0, 50378
AppSec [candidate] (50.73 ms) : 0, 50730
IAST [baseline] (23.918 ms) : 0, 23918
IAST [candidate] (21.891 ms) : 0, 21891
Remote Config [baseline] (570.163 µs) : 0, 570
Remote Config [candidate] (580.07 µs) : 0, 580
Telemetry [baseline] (7.298 ms) : 0, 7298
Telemetry [candidate] (9.678 ms) : 0, 9678
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (807.374 ms) : 0, 807374
BytebuddyAgent [candidate] (799.753 ms) : 0, 799753
GlobalTracer [baseline] (291.657 ms) : 0, 291657
GlobalTracer [candidate] (290.708 ms) : 0, 290708
AppSec [baseline] (50.65 ms) : 0, 50650
AppSec [candidate] (52.065 ms) : 0, 52065
IAST [baseline] (23.445 ms) : 0, 23445
IAST [candidate] (21.919 ms) : 0, 21919
Remote Config [baseline] (597.871 µs) : 0, 598
Remote Config [candidate] (591.018 µs) : 0, 591
Telemetry [baseline] (8.2 ms) : 0, 8200
Telemetry [candidate] (8.244 ms) : 0, 8244
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (791.441 ms) : 0, 791441
BytebuddyAgent [candidate] (797.042 ms) : 0, 797042
GlobalTracer [baseline] (288.055 ms) : 0, 288055
GlobalTracer [candidate] (290.069 ms) : 0, 290069
AppSec [baseline] (48.168 ms) : 0, 48168
AppSec [candidate] (49.695 ms) : 0, 49695
IAST [baseline] (26.51 ms) : 0, 26510
IAST [candidate] (22.925 ms) : 0, 22925
Remote Config [baseline] (571.582 µs) : 0, 572
Remote Config [candidate] (586.988 µs) : 0, 587
Telemetry [baseline] (6.479 ms) : 0, 6479
Telemetry [candidate] (7.418 ms) : 0, 7418
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-04-19T05:33:48 2024-04-19T05:40:35
git_branch master alejandro.gonzalez/Environment-variable-to-activate-SCA
git_commit_date 1713460719 1713503990
git_commit_sha 23a819a 3e86513
release_version 1.34.0-SNAPSHOT~23a819aa79 1.34.0-SNAPSHOT~3e86513218
start_time 2024-04-19T05:33:35 2024-04-19T05:40:22
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1713505581 1713505581
ci_job_id 491294927 491294927
ci_pipeline_id 32472362 32472362
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 1 performance regressions! Performance is the same for 10 metrics, 17 unstable metrics.

scenario Δ mean http_req_duration Δ mean throughput candidate mean http_req_duration candidate mean throughput baseline mean http_req_duration baseline mean throughput
scenario:load:petclinic:profiling worse
[+47.287µs; +102.645µs] or [+3.178%; +6.898%]		 unstable
[-696.162op/s; +468.242op/s] or [-22.625%; +15.218%]		 1.563ms 2962.963op/s 1.488ms 3076.923op/s
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.34.0-SNAPSHOT~3e86513218, baseline=1.34.0-SNAPSHOT~23a819aa79
    dateFormat X
    axisFormat %s
section baseline
no_agent (361.83 µs) : 342, 382
.   : milestone, 362,
iast (477.093 µs) : 455, 499
.   : milestone, 477,
iast_FULL (537.327 µs) : 517, 558
.   : milestone, 537,
iast_GLOBAL (495.536 µs) : 474, 517
.   : milestone, 496,
iast_HARDCODED_SECRET_DISABLED (478.438 µs) : 457, 500
.   : milestone, 478,
iast_INACTIVE (445.368 µs) : 425, 466
.   : milestone, 445,
iast_TELEMETRY_OFF (475.18 µs) : 453, 497
.   : milestone, 475,
tracing (445.19 µs) : 425, 466
.   : milestone, 445,
section candidate
no_agent (369.066 µs) : 349, 389
.   : milestone, 369,
iast (476.218 µs) : 454, 498
.   : milestone, 476,
iast_FULL (544.588 µs) : 524, 565
.   : milestone, 545,
iast_GLOBAL (497.419 µs) : 476, 519
.   : milestone, 497,
iast_HARDCODED_SECRET_DISABLED (472.18 µs) : 451, 494
.   : milestone, 472,
iast_INACTIVE (451.822 µs) : 430, 473
.   : milestone, 452,
iast_TELEMETRY_OFF (465.888 µs) : 444, 488
.   : milestone, 466,
tracing (445.882 µs) : 425, 467
.   : milestone, 446,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 361.83 µs [341.766 µs, 381.893 µs] -
iast 477.093 µs [455.343 µs, 498.842 µs] 115.263 µs (31.9%)
iast_FULL 537.327 µs [516.661 µs, 557.992 µs] 175.497 µs (48.5%)
iast_GLOBAL 495.536 µs [474.089 µs, 516.983 µs] 133.707 µs (37.0%)
iast_HARDCODED_SECRET_DISABLED 478.438 µs [456.844 µs, 500.031 µs] 116.608 µs (32.2%)
iast_INACTIVE 445.368 µs [424.826 µs, 465.909 µs] 83.538 µs (23.1%)
iast_TELEMETRY_OFF 475.18 µs [453.386 µs, 496.974 µs] 113.35 µs (31.3%)
tracing 445.19 µs [424.737 µs, 465.643 µs] 83.36 µs (23.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 369.066 µs [349.199 µs, 388.933 µs] -
iast 476.218 µs [454.326 µs, 498.109 µs] 107.152 µs (29.0%)
iast_FULL 544.588 µs [523.88 µs, 565.296 µs] 175.523 µs (47.6%)
iast_GLOBAL 497.419 µs [475.81 µs, 519.028 µs] 128.353 µs (34.8%)
iast_HARDCODED_SECRET_DISABLED 472.18 µs [450.536 µs, 493.824 µs] 103.115 µs (27.9%)
iast_INACTIVE 451.822 µs [430.273 µs, 473.372 µs] 82.757 µs (22.4%)
iast_TELEMETRY_OFF 465.888 µs [444.145 µs, 487.63 µs] 96.822 µs (26.2%)
tracing 445.882 µs [424.685 µs, 467.079 µs] 76.816 µs (20.8%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.34.0-SNAPSHOT~3e86513218, baseline=1.34.0-SNAPSHOT~23a819aa79
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.342 ms) : 1322, 1362
.   : milestone, 1342,
appsec (1.695 ms) : 1671, 1720
.   : milestone, 1695,
appsec_no_iast (1.729 ms) : 1704, 1755
.   : milestone, 1729,
iast (1.469 ms) : 1446, 1492
.   : milestone, 1469,
profiling (1.488 ms) : 1463, 1513
.   : milestone, 1488,
tracing (1.498 ms) : 1473, 1522
.   : milestone, 1498,
section candidate
no_agent (1.334 ms) : 1315, 1353
.   : milestone, 1334,
appsec (1.725 ms) : 1702, 1749
.   : milestone, 1725,
appsec_no_iast (1.72 ms) : 1695, 1744
.   : milestone, 1720,
iast (1.498 ms) : 1475, 1520
.   : milestone, 1498,
profiling (1.563 ms) : 1536, 1589
.   : milestone, 1563,
tracing (1.495 ms) : 1471, 1519
.   : milestone, 1495,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.342 ms [1.322 ms, 1.362 ms] -
appsec 1.695 ms [1.671 ms, 1.72 ms] 353.491 µs (26.3%)
appsec_no_iast 1.729 ms [1.704 ms, 1.755 ms] 387.466 µs (28.9%)
iast 1.469 ms [1.446 ms, 1.492 ms] 126.778 µs (9.4%)
profiling 1.488 ms [1.463 ms, 1.513 ms] 146.033 µs (10.9%)
tracing 1.498 ms [1.473 ms, 1.522 ms] 155.658 µs (11.6%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.334 ms [1.315 ms, 1.353 ms] -
appsec 1.725 ms [1.702 ms, 1.749 ms] 391.368 µs (29.3%)
appsec_no_iast 1.72 ms [1.695 ms, 1.744 ms] 385.681 µs (28.9%)
iast 1.498 ms [1.475 ms, 1.52 ms] 163.574 µs (12.3%)
profiling 1.563 ms [1.536 ms, 1.589 ms] 228.839 µs (17.2%)
tracing 1.495 ms [1.471 ms, 1.519 ms] 161.0 µs (12.1%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master alejandro.gonzalez/Environment-variable-to-activate-SCA
git_commit_date 1713460719 1713503990
git_commit_sha 23a819a 3e86513
release_version 1.34.0-SNAPSHOT~23a819aa79 1.34.0-SNAPSHOT~3e86513218
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1713506091 1713506091
ci_job_id 491294928 491294928
ci_pipeline_id 32472362 32472362
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.34.0-SNAPSHOT~3e86513218, baseline=1.34.0-SNAPSHOT~23a819aa79
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.396 s) : 15396000, 15396000
.   : milestone, 15396000,
appsec (15.163 s) : 15163000, 15163000
.   : milestone, 15163000,
iast (18.808 s) : 18808000, 18808000
.   : milestone, 18808000,
iast_GLOBAL (17.723 s) : 17723000, 17723000
.   : milestone, 17723000,
profiling (15.094 s) : 15094000, 15094000
.   : milestone, 15094000,
tracing (15.1 s) : 15100000, 15100000
.   : milestone, 15100000,
section candidate
no_agent (15.067 s) : 15067000, 15067000
.   : milestone, 15067000,
appsec (15.141 s) : 15141000, 15141000
.   : milestone, 15141000,
iast (18.644 s) : 18644000, 18644000
.   : milestone, 18644000,
iast_GLOBAL (18.199 s) : 18199000, 18199000
.   : milestone, 18199000,
profiling (15.865 s) : 15865000, 15865000
.   : milestone, 15865000,
tracing (14.825 s) : 14825000, 14825000
.   : milestone, 14825000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.396 s [15.396 s, 15.396 s] -
appsec 15.163 s [15.163 s, 15.163 s] -233.0 ms (-1.5%)
iast 18.808 s [18.808 s, 18.808 s] 3.412 s (22.2%)
iast_GLOBAL 17.723 s [17.723 s, 17.723 s] 2.327 s (15.1%)
profiling 15.094 s [15.094 s, 15.094 s] -302.0 ms (-2.0%)
tracing 15.1 s [15.1 s, 15.1 s] -296.0 ms (-1.9%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.067 s [15.067 s, 15.067 s] -
appsec 15.141 s [15.141 s, 15.141 s] 74.0 ms (0.5%)
iast 18.644 s [18.644 s, 18.644 s] 3.577 s (23.7%)
iast_GLOBAL 18.199 s [18.199 s, 18.199 s] 3.132 s (20.8%)
profiling 15.865 s [15.865 s, 15.865 s] 798.0 ms (5.3%)
tracing 14.825 s [14.825 s, 14.825 s] -242.0 ms (-1.6%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.34.0-SNAPSHOT~3e86513218, baseline=1.34.0-SNAPSHOT~23a819aa79
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.461 ms) : 1450, 1473
.   : milestone, 1461,
appsec (2.202 ms) : 2168, 2235
.   : milestone, 2202,
iast (1.866 ms) : 1832, 1900
.   : milestone, 1866,
iast_GLOBAL (1.919 ms) : 1884, 1954
.   : milestone, 1919,
profiling (1.853 ms) : 1819, 1887
.   : milestone, 1853,
tracing (1.828 ms) : 1796, 1859
.   : milestone, 1828,
section candidate
no_agent (1.464 ms) : 1453, 1476
.   : milestone, 1464,
appsec (2.201 ms) : 2167, 2234
.   : milestone, 2201,
iast (1.874 ms) : 1840, 1909
.   : milestone, 1874,
iast_GLOBAL (1.917 ms) : 1882, 1952
.   : milestone, 1917,
profiling (1.854 ms) : 1821, 1888
.   : milestone, 1854,
tracing (1.838 ms) : 1806, 1870
.   : milestone, 1838,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.461 ms [1.45 ms, 1.473 ms] -
appsec 2.202 ms [2.168 ms, 2.235 ms] 740.544 µs (50.7%)
iast 1.866 ms [1.832 ms, 1.9 ms] 404.911 µs (27.7%)
iast_GLOBAL 1.919 ms [1.884 ms, 1.954 ms] 458.191 µs (31.4%)
profiling 1.853 ms [1.819 ms, 1.887 ms] 392.13 µs (26.8%)
tracing 1.828 ms [1.796 ms, 1.859 ms] 366.373 µs (25.1%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.464 ms [1.453 ms, 1.476 ms] -
appsec 2.201 ms [2.167 ms, 2.234 ms] 736.034 µs (50.3%)
iast 1.874 ms [1.84 ms, 1.909 ms] 409.715 µs (28.0%)
iast_GLOBAL 1.917 ms [1.882 ms, 1.952 ms] 452.41 µs (30.9%)
profiling 1.854 ms [1.821 ms, 1.888 ms] 389.821 µs (26.6%)
tracing 1.838 ms [1.806 ms, 1.87 ms] 373.527 µs (25.5%)

@jandro996 jandro996 requested a review from smola April 16, 2024 06:50
@jandro996 jandro996 added the comp: asm iast Application Security Management (IAST) label Apr 16, 2024
@jandro996 jandro996 marked this pull request as ready for review April 17, 2024 09:29
@jandro996 jandro996 requested a review from a team as a code owner April 17, 2024 09:29
@jandro996 jandro996 force-pushed the alejandro.gonzalez/Environment-variable-to-activate-SCA branch from 6591f18 to a1d3ec5 Compare April 17, 2024 11:24
smola
smola approved these changes Apr 19, 2024
View reviewed changes
Copy link
Member

@smola smola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jandro996 jandro996 merged commit 39a5e4c into master Apr 22, 2024
80 checks passed
@github-actions github-actions bot added this to the 1.34.0 milestone Apr 22, 2024
@smola smola deleted the alejandro.gonzalez/Environment-variable-to-activate-SCA branch May 7, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougqh dougqh dougqh approved these changes

@smola smola smola approved these changes

@nayeem-kamal nayeem-kamal Awaiting requested review from nayeem-kamal nayeem-kamal is a code owner automatically assigned from DataDog/apm-java

@manuel-alvarez-alvarez manuel-alvarez-alvarez Awaiting requested review from manuel-alvarez-alvarez

@ValentinZakharov ValentinZakharov Awaiting requested review from ValentinZakharov

Assignees
No one assigned
Labels
comp: asm iast Application Security Management (IAST)
Projects
None yet
Milestone
1.34.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jandro996 @smola @dougqh