Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not trace processes spawned by internal shell command executor #6927

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Do not trace processes spawned by internal shell command executor #6927

merged 1 commit into from
Apr 18, 2024

Conversation

nikita-tkachenko-datadog
Copy link
Contributor

@nikita-tkachenko-datadog nikita-tkachenko-datadog commented Apr 18, 2024 •
edited by jira bot
Loading

What Does This Do

Updates ShellCommandExecutor component so that it mutes tracing for the processes that it spawns.

Motivation

If not muted, the processes may show up as spans in the user's traces, which is incorrect since those processes are started by the tracer and not by the traced application.

Jira ticket: CIVIS-9821

@nikita-tkachenko-datadog nikita-tkachenko-datadog added type: bug comp: ci visibility Continuous Integration Visibility labels Apr 18, 2024
@nikita-tkachenko-datadog nikita-tkachenko-datadog changed the title Do not trace processes spawned by internal shell comman executor Do not trace processes spawned by internal shell command executor Apr 18, 2024
@nikita-tkachenko-datadog nikita-tkachenko-datadog marked this pull request as ready for review April 18, 2024 15:58
@nikita-tkachenko-datadog nikita-tkachenko-datadog requested a review from a team as a code owner April 18, 2024 15:58
@pr-commenter
Copy link

pr-commenter bot commented Apr 18, 2024

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master nikita-tkachenko/do-not-trace-shell-command-executor
git_commit_date 1713433730 1713453557
git_commit_sha a1463c6 e9efadb
release_version 1.33.0-SNAPSHOT~a1463c6bf3 1.34.0-SNAPSHOT~e9efadbee0
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1713456374 1713456374
ci_job_id 490621984 490621984
ci_pipeline_id 32412863 32412863
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 48 metrics, 15 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.34.0-SNAPSHOT~e9efadbee0, baseline=1.33.0-SNAPSHOT~a1463c6bf3

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.081 s) : 0, 1080659
Total [baseline] (8.588 s) : 0, 8587964
Agent [candidate] (1.082 s) : 0, 1082323
Total [candidate] (8.554 s) : 0, 8553701
section iast
Agent [baseline] (1.198 s) : 0, 1197976
Total [baseline] (9.002 s) : 0, 9001806
Agent [candidate] (1.206 s) : 0, 1205667
Total [candidate] (9.029 s) : 0, 9028979
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.199 s) : 0, 1199491
Total [baseline] (9.054 s) : 0, 9054415
Agent [candidate] (1.198 s) : 0, 1197742
Total [candidate] (9.013 s) : 0, 9013194
section iast_TELEMETRY_OFF
Agent [baseline] (1.196 s) : 0, 1195698
Total [baseline] (8.993 s) : 0, 8993021
Agent [candidate] (1.196 s) : 0, 1196087
Total [candidate] (8.996 s) : 0, 8995590
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.081 s -
Agent iast 1.198 s 117.317 ms (10.9%)
Agent iast_HARDCODED_SECRET_DISABLED 1.199 s 118.832 ms (11.0%)
Agent iast_TELEMETRY_OFF 1.196 s 115.039 ms (10.6%)
Total tracing 8.588 s -
Total iast 9.002 s 413.842 ms (4.8%)
Total iast_HARDCODED_SECRET_DISABLED 9.054 s 466.451 ms (5.4%)
Total iast_TELEMETRY_OFF 8.993 s 405.057 ms (4.7%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.082 s -
Agent iast 1.206 s 123.344 ms (11.4%)
Agent iast_HARDCODED_SECRET_DISABLED 1.198 s 115.419 ms (10.7%)
Agent iast_TELEMETRY_OFF 1.196 s 113.764 ms (10.5%)
Total tracing 8.554 s -
Total iast 9.029 s 475.278 ms (5.6%)
Total iast_HARDCODED_SECRET_DISABLED 9.013 s 459.492 ms (5.4%)
Total iast_TELEMETRY_OFF 8.996 s 441.889 ms (5.2%) 
gantt
    title insecure-bank - break down per module: candidate=1.34.0-SNAPSHOT~e9efadbee0, baseline=1.33.0-SNAPSHOT~a1463c6bf3

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (676.894 ms) : 0, 676894
BytebuddyAgent [candidate] (677.647 ms) : 0, 677647
GlobalTracer [baseline] (311.152 ms) : 0, 311152
GlobalTracer [candidate] (311.784 ms) : 0, 311784
AppSec [baseline] (49.742 ms) : 0, 49742
AppSec [candidate] (49.76 ms) : 0, 49760
Remote Config [baseline] (664.566 µs) : 0, 665
Remote Config [candidate] (668.862 µs) : 0, 669
Telemetry [baseline] (7.634 ms) : 0, 7634
Telemetry [candidate] (7.706 ms) : 0, 7706
section iast
BytebuddyAgent [baseline] (793.917 ms) : 0, 793917
BytebuddyAgent [candidate] (798.687 ms) : 0, 798687
GlobalTracer [baseline] (287.7 ms) : 0, 287700
GlobalTracer [candidate] (289.527 ms) : 0, 289527
AppSec [baseline] (49.37 ms) : 0, 49370
AppSec [candidate] (50.639 ms) : 0, 50639
Remote Config [baseline] (572.081 µs) : 0, 572
Remote Config [candidate] (588.019 µs) : 0, 588
Telemetry [baseline] (7.294 ms) : 0, 7294
Telemetry [candidate] (8.946 ms) : 0, 8946
IAST [baseline] (24.765 ms) : 0, 24765
IAST [candidate] (22.748 ms) : 0, 22748
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (793.405 ms) : 0, 793405
BytebuddyAgent [candidate] (792.924 ms) : 0, 792924
GlobalTracer [baseline] (289.74 ms) : 0, 289740
GlobalTracer [candidate] (287.966 ms) : 0, 287966
AppSec [baseline] (49.755 ms) : 0, 49755
AppSec [candidate] (51.186 ms) : 0, 51186
Remote Config [baseline] (609.102 µs) : 0, 609
Remote Config [candidate] (570.675 µs) : 0, 571
Telemetry [baseline] (7.41 ms) : 0, 7410
Telemetry [candidate] (7.423 ms) : 0, 7423
IAST [baseline] (24.232 ms) : 0, 24232
IAST [candidate] (23.207 ms) : 0, 23207
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (791.363 ms) : 0, 791363
BytebuddyAgent [candidate] (791.298 ms) : 0, 791298
GlobalTracer [baseline] (288.247 ms) : 0, 288247
GlobalTracer [candidate] (288.307 ms) : 0, 288307
AppSec [baseline] (50.227 ms) : 0, 50227
AppSec [candidate] (49.02 ms) : 0, 49020
Remote Config [baseline] (597.375 µs) : 0, 597
Remote Config [candidate] (589.6 µs) : 0, 590
Telemetry [baseline] (7.379 ms) : 0, 7379
Telemetry [candidate] (8.139 ms) : 0, 8139
IAST [baseline] (23.436 ms) : 0, 23436
IAST [candidate] (24.29 ms) : 0, 24290
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.34.0-SNAPSHOT~e9efadbee0, baseline=1.33.0-SNAPSHOT~a1463c6bf3

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.076 s) : 0, 1075645
Total [baseline] (10.339 s) : 0, 10338960
Agent [candidate] (1.082 s) : 0, 1081675
Total [candidate] (10.349 s) : 0, 10349037
section appsec
Agent [baseline] (1.191 s) : 0, 1191018
Total [baseline] (10.51 s) : 0, 10510471
Agent [candidate] (1.186 s) : 0, 1186428
Total [candidate] (10.549 s) : 0, 10548790
section iast
Agent [baseline] (1.196 s) : 0, 1196450
Total [baseline] (10.783 s) : 0, 10782895
Agent [candidate] (1.2 s) : 0, 1199758
Total [candidate] (10.747 s) : 0, 10747343
section profiling
Agent [baseline] (1.267 s) : 0, 1267265
Total [baseline] (10.575 s) : 0, 10574905
Agent [candidate] (1.267 s) : 0, 1266870
Total [candidate] (10.63 s) : 0, 10629839
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.076 s -
Agent appsec 1.191 s 115.373 ms (10.7%)
Agent iast 1.196 s 120.805 ms (11.2%)
Agent profiling 1.267 s 191.62 ms (17.8%)
Total tracing 10.339 s -
Total appsec 10.51 s 171.511 ms (1.7%)
Total iast 10.783 s 443.936 ms (4.3%)
Total profiling 10.575 s 235.945 ms (2.3%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.082 s -
Agent appsec 1.186 s 104.753 ms (9.7%)
Agent iast 1.2 s 118.083 ms (10.9%)
Agent profiling 1.267 s 185.194 ms (17.1%)
Total tracing 10.349 s -
Total appsec 10.549 s 199.753 ms (1.9%)
Total iast 10.747 s 398.306 ms (3.8%)
Total profiling 10.63 s 280.802 ms (2.7%) 
gantt
    title petclinic - break down per module: candidate=1.34.0-SNAPSHOT~e9efadbee0, baseline=1.33.0-SNAPSHOT~a1463c6bf3

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (674.096 ms) : 0, 674096
BytebuddyAgent [candidate] (677.379 ms) : 0, 677379
GlobalTracer [baseline] (309.304 ms) : 0, 309304
GlobalTracer [candidate] (311.482 ms) : 0, 311482
AppSec [baseline] (49.623 ms) : 0, 49623
AppSec [candidate] (49.917 ms) : 0, 49917
Remote Config [baseline] (656.693 µs) : 0, 657
Remote Config [candidate] (666.681 µs) : 0, 667
Telemetry [baseline] (7.575 ms) : 0, 7575
Telemetry [candidate] (7.605 ms) : 0, 7605
section appsec
BytebuddyAgent [baseline] (696.686 ms) : 0, 696686
BytebuddyAgent [candidate] (693.952 ms) : 0, 693952
GlobalTracer [baseline] (291.841 ms) : 0, 291841
GlobalTracer [candidate] (291.037 ms) : 0, 291037
AppSec [baseline] (149.915 ms) : 0, 149915
AppSec [candidate] (149.359 ms) : 0, 149359
Remote Config [baseline] (626.993 µs) : 0, 627
Remote Config [candidate] (619.62 µs) : 0, 620
Telemetry [baseline] (7.856 ms) : 0, 7856
Telemetry [candidate] (7.526 ms) : 0, 7526
IAST [baseline] (19.355 ms) : 0, 19355
IAST [candidate] (19.201 ms) : 0, 19201
section iast
BytebuddyAgent [baseline] (792.939 ms) : 0, 792939
BytebuddyAgent [candidate] (794.108 ms) : 0, 794108
GlobalTracer [baseline] (287.133 ms) : 0, 287133
GlobalTracer [candidate] (288.03 ms) : 0, 288030
AppSec [baseline] (50.159 ms) : 0, 50159
AppSec [candidate] (50.016 ms) : 0, 50016
Remote Config [baseline] (568.19 µs) : 0, 568
Remote Config [candidate] (586.761 µs) : 0, 587
Telemetry [baseline] (8.025 ms) : 0, 8025
Telemetry [candidate] (7.398 ms) : 0, 7398
IAST [baseline] (23.274 ms) : 0, 23274
IAST [candidate] (25.2 ms) : 0, 25200
section profiling
BytebuddyAgent [baseline] (677.187 ms) : 0, 677187
BytebuddyAgent [candidate] (676.856 ms) : 0, 676856
GlobalTracer [baseline] (380.07 ms) : 0, 380070
GlobalTracer [candidate] (379.467 ms) : 0, 379467
AppSec [baseline] (49.976 ms) : 0, 49976
AppSec [candidate] (50.391 ms) : 0, 50391
Remote Config [baseline] (708.63 µs) : 0, 709
Remote Config [candidate] (694.746 µs) : 0, 695
Telemetry [baseline] (7.453 ms) : 0, 7453
Telemetry [candidate] (7.448 ms) : 0, 7448
ProfilingAgent [baseline] (95.594 ms) : 0, 95594
ProfilingAgent [candidate] (95.683 ms) : 0, 95683
Profiling [baseline] (95.618 ms) : 0, 95618
Profiling [candidate] (95.707 ms) : 0, 95707
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-04-18T15:37:01 2024-04-18T15:43:48
git_branch master nikita-tkachenko/do-not-trace-shell-command-executor
git_commit_date 1713433730 1713453557
git_commit_sha a1463c6 e9efadb
release_version 1.33.0-SNAPSHOT~a1463c6bf3 1.34.0-SNAPSHOT~e9efadbee0
start_time 2024-04-18T15:36:47 2024-04-18T15:43:35
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1713455370 1713455370
ci_job_id 490621985 490621985
ci_pipeline_id 32412863 32412863
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 1 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 17 unstable metrics.

scenario Δ mean http_req_duration Δ mean throughput candidate mean http_req_duration candidate mean throughput baseline mean http_req_duration baseline mean throughput
scenario:load:petclinic:profiling better
[-96.093µs; -42.828µs] or [-6.196%; -2.762%]		 unstable
[-328.840op/s; +802.914op/s] or [-11.098%; +27.098%]		 1.481ms 3200.000op/s 1.551ms 2962.963op/s
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.34.0-SNAPSHOT~e9efadbee0, baseline=1.33.0-SNAPSHOT~a1463c6bf3
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.326 ms) : 1305, 1346
.   : milestone, 1326,
appsec (1.714 ms) : 1690, 1738
.   : milestone, 1714,
appsec_no_iast (1.733 ms) : 1708, 1758
.   : milestone, 1733,
iast (1.505 ms) : 1482, 1527
.   : milestone, 1505,
profiling (1.551 ms) : 1526, 1576
.   : milestone, 1551,
tracing (1.492 ms) : 1468, 1515
.   : milestone, 1492,
section candidate
no_agent (1.324 ms) : 1305, 1343
.   : milestone, 1324,
appsec (1.714 ms) : 1689, 1738
.   : milestone, 1714,
appsec_no_iast (1.699 ms) : 1674, 1724
.   : milestone, 1699,
iast (1.475 ms) : 1452, 1498
.   : milestone, 1475,
profiling (1.481 ms) : 1457, 1506
.   : milestone, 1481,
tracing (1.463 ms) : 1440, 1486
.   : milestone, 1463,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.326 ms [1.305 ms, 1.346 ms] -
appsec 1.714 ms [1.69 ms, 1.738 ms] 388.697 µs (29.3%)
appsec_no_iast 1.733 ms [1.708 ms, 1.758 ms] 407.039 µs (30.7%)
iast 1.505 ms [1.482 ms, 1.527 ms] 178.971 µs (13.5%)
profiling 1.551 ms [1.526 ms, 1.576 ms] 225.314 µs (17.0%)
tracing 1.492 ms [1.468 ms, 1.515 ms] 166.1 µs (12.5%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.324 ms [1.305 ms, 1.343 ms] -
appsec 1.714 ms [1.689 ms, 1.738 ms] 389.571 µs (29.4%)
appsec_no_iast 1.699 ms [1.674 ms, 1.724 ms] 375.095 µs (28.3%)
iast 1.475 ms [1.452 ms, 1.498 ms] 150.802 µs (11.4%)
profiling 1.481 ms [1.457 ms, 1.506 ms] 157.333 µs (11.9%)
tracing 1.463 ms [1.44 ms, 1.486 ms] 138.865 µs (10.5%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.34.0-SNAPSHOT~e9efadbee0, baseline=1.33.0-SNAPSHOT~a1463c6bf3
    dateFormat X
    axisFormat %s
section baseline
no_agent (358.69 µs) : 339, 379
.   : milestone, 359,
iast (476.322 µs) : 455, 497
.   : milestone, 476,
iast_FULL (534.509 µs) : 514, 555
.   : milestone, 535,
iast_GLOBAL (491.486 µs) : 470, 513
.   : milestone, 491,
iast_HARDCODED_SECRET_DISABLED (474.359 µs) : 453, 496
.   : milestone, 474,
iast_INACTIVE (438.226 µs) : 418, 459
.   : milestone, 438,
iast_TELEMETRY_OFF (464.606 µs) : 443, 486
.   : milestone, 465,
tracing (434.1 µs) : 414, 454
.   : milestone, 434,
section candidate
no_agent (360.65 µs) : 341, 380
.   : milestone, 361,
iast (464.563 µs) : 444, 485
.   : milestone, 465,
iast_FULL (531.34 µs) : 510, 553
.   : milestone, 531,
iast_GLOBAL (494.686 µs) : 473, 517
.   : milestone, 495,
iast_HARDCODED_SECRET_DISABLED (467.404 µs) : 446, 488
.   : milestone, 467,
iast_INACTIVE (447.445 µs) : 427, 468
.   : milestone, 447,
iast_TELEMETRY_OFF (465.147 µs) : 444, 486
.   : milestone, 465,
tracing (438.093 µs) : 418, 459
.   : milestone, 438,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 358.69 µs [338.512 µs, 378.868 µs] -
iast 476.322 µs [455.258 µs, 497.385 µs] 117.632 µs (32.8%)
iast_FULL 534.509 µs [513.767 µs, 555.252 µs] 175.819 µs (49.0%)
iast_GLOBAL 491.486 µs [470.088 µs, 512.884 µs] 132.796 µs (37.0%)
iast_HARDCODED_SECRET_DISABLED 474.359 µs [452.536 µs, 496.182 µs] 115.669 µs (32.2%)
iast_INACTIVE 438.226 µs [417.698 µs, 458.754 µs] 79.536 µs (22.2%)
iast_TELEMETRY_OFF 464.606 µs [443.461 µs, 485.751 µs] 105.916 µs (29.5%)
tracing 434.1 µs [413.785 µs, 454.416 µs] 75.41 µs (21.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 360.65 µs [341.137 µs, 380.164 µs] -
iast 464.563 µs [443.651 µs, 485.475 µs] 103.913 µs (28.8%)
iast_FULL 531.34 µs [510.136 µs, 552.543 µs] 170.689 µs (47.3%)
iast_GLOBAL 494.686 µs [472.587 µs, 516.785 µs] 134.036 µs (37.2%)
iast_HARDCODED_SECRET_DISABLED 467.404 µs [446.466 µs, 488.342 µs] 106.753 µs (29.6%)
iast_INACTIVE 447.445 µs [426.814 µs, 468.076 µs] 86.795 µs (24.1%)
iast_TELEMETRY_OFF 465.147 µs [444.487 µs, 485.808 µs] 104.497 µs (29.0%)
tracing 438.093 µs [417.599 µs, 458.588 µs] 77.443 µs (21.5%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master nikita-tkachenko/do-not-trace-shell-command-executor
git_commit_date 1713433730 1713453557
git_commit_sha a1463c6 e9efadb
release_version 1.33.0-SNAPSHOT~a1463c6bf3 1.34.0-SNAPSHOT~e9efadbee0
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1713455879 1713455879
ci_job_id 490621987 490621987
ci_pipeline_id 32412863 32412863
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.34.0-SNAPSHOT~e9efadbee0, baseline=1.33.0-SNAPSHOT~a1463c6bf3
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.013 s) : 15013000, 15013000
.   : milestone, 15013000,
appsec (14.84 s) : 14840000, 14840000
.   : milestone, 14840000,
iast (18.872 s) : 18872000, 18872000
.   : milestone, 18872000,
iast_GLOBAL (17.869 s) : 17869000, 17869000
.   : milestone, 17869000,
profiling (15.902 s) : 15902000, 15902000
.   : milestone, 15902000,
tracing (14.953 s) : 14953000, 14953000
.   : milestone, 14953000,
section candidate
no_agent (15.367 s) : 15367000, 15367000
.   : milestone, 15367000,
appsec (15.049 s) : 15049000, 15049000
.   : milestone, 15049000,
iast (18.953 s) : 18953000, 18953000
.   : milestone, 18953000,
iast_GLOBAL (17.958 s) : 17958000, 17958000
.   : milestone, 17958000,
profiling (15.122 s) : 15122000, 15122000
.   : milestone, 15122000,
tracing (14.951 s) : 14951000, 14951000
.   : milestone, 14951000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.013 s [15.013 s, 15.013 s] -
appsec 14.84 s [14.84 s, 14.84 s] -173.0 ms (-1.2%)
iast 18.872 s [18.872 s, 18.872 s] 3.859 s (25.7%)
iast_GLOBAL 17.869 s [17.869 s, 17.869 s] 2.856 s (19.0%)
profiling 15.902 s [15.902 s, 15.902 s] 889.0 ms (5.9%)
tracing 14.953 s [14.953 s, 14.953 s] -60.0 ms (-0.4%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.367 s [15.367 s, 15.367 s] -
appsec 15.049 s [15.049 s, 15.049 s] -318.0 ms (-2.1%)
iast 18.953 s [18.953 s, 18.953 s] 3.586 s (23.3%)
iast_GLOBAL 17.958 s [17.958 s, 17.958 s] 2.591 s (16.9%)
profiling 15.122 s [15.122 s, 15.122 s] -245.0 ms (-1.6%)
tracing 14.951 s [14.951 s, 14.951 s] -416.0 ms (-2.7%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.34.0-SNAPSHOT~e9efadbee0, baseline=1.33.0-SNAPSHOT~a1463c6bf3
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.46 ms) : 1449, 1472
.   : milestone, 1460,
appsec (2.2 ms) : 2166, 2233
.   : milestone, 2200,
iast (1.871 ms) : 1836, 1905
.   : milestone, 1871,
iast_GLOBAL (1.91 ms) : 1875, 1945
.   : milestone, 1910,
profiling (1.844 ms) : 1810, 1878
.   : milestone, 1844,
tracing (1.812 ms) : 1781, 1843
.   : milestone, 1812,
section candidate
no_agent (1.46 ms) : 1448, 1471
.   : milestone, 1460,
appsec (2.205 ms) : 2171, 2239
.   : milestone, 2205,
iast (1.872 ms) : 1838, 1906
.   : milestone, 1872,
iast_GLOBAL (1.912 ms) : 1877, 1946
.   : milestone, 1912,
profiling (1.84 ms) : 1808, 1872
.   : milestone, 1840,
tracing (1.826 ms) : 1794, 1858
.   : milestone, 1826,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.46 ms [1.449 ms, 1.472 ms] -
appsec 2.2 ms [2.166 ms, 2.233 ms] 739.317 µs (50.6%)
iast 1.871 ms [1.836 ms, 1.905 ms] 410.35 µs (28.1%)
iast_GLOBAL 1.91 ms [1.875 ms, 1.945 ms] 449.711 µs (30.8%)
profiling 1.844 ms [1.81 ms, 1.878 ms] 383.375 µs (26.3%)
tracing 1.812 ms [1.781 ms, 1.843 ms] 351.782 µs (24.1%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.46 ms [1.448 ms, 1.471 ms] -
appsec 2.205 ms [2.171 ms, 2.239 ms] 745.689 µs (51.1%)
iast 1.872 ms [1.838 ms, 1.906 ms] 412.37 µs (28.3%)
iast_GLOBAL 1.912 ms [1.877 ms, 1.946 ms] 451.964 µs (31.0%)
profiling 1.84 ms [1.808 ms, 1.872 ms] 380.686 µs (26.1%)
tracing 1.826 ms [1.794 ms, 1.858 ms] 366.12 µs (25.1%)

@nikita-tkachenko-datadog nikita-tkachenko-datadog merged commit 23a819a into master Apr 18, 2024
82 checks passed
@nikita-tkachenko-datadog nikita-tkachenko-datadog deleted the nikita-tkachenko/do-not-trace-shell-command-executor branch April 18, 2024 17:18
@github-actions github-actions bot added this to the 1.34.0 milestone Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romainkomorndatadog romainkomorndatadog romainkomorndatadog approved these changes

Assignees
No one assigned
Labels
comp: ci visibility Continuous Integration Visibility type: bug
Projects
None yet
Milestone
1.34.0
Development

Successfully merging this pull request may close these issues.
2 participants
@nikita-tkachenko-datadog @romainkomorndatadog