Integrate initial list of third party libraries #6928

ojung · 2024-04-19T16:19:40Z

What Does This Do

Add third party filtering and use it in SymDB / ER.

Motivation

Additional Notes

Jira ticket: DEBUG-1942

pr-commenter · 2024-04-19T17:03:58Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	ojung/DEBUG-1942-integrate-initial-list-of-third-party-libraries
git_commit_date	1713861708	1713901707
git_commit_sha	`f34dfb5`	`5affc93`
release_version	1.34.0-SNAPSHOT~f34dfb52a1	1.34.0-SNAPSHOT~5affc93ea8

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1713904911	1713904911
ci_job_id	494874952	494874952
ci_pipeline_id	32747992	32747992
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 11 unstable metrics.

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.34.0-SNAPSHOT~5affc93ea8, baseline=1.34.0-SNAPSHOT~f34dfb52a1

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.072 s) : 0, 1072425
Total [baseline] (8.52 s) : 0, 8519522
Agent [candidate] (1.073 s) : 0, 1072715
Total [candidate] (8.57 s) : 0, 8570199
section iast
Agent [baseline] (1.203 s) : 0, 1202638
Total [baseline] (9.056 s) : 0, 9055673
Agent [candidate] (1.202 s) : 0, 1202077
Total [candidate] (9.038 s) : 0, 9037836
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.197 s) : 0, 1197079
Total [baseline] (8.956 s) : 0, 8956498
Agent [candidate] (1.208 s) : 0, 1208266
Total [candidate] (8.996 s) : 0, 8996300
section iast_TELEMETRY_OFF
Agent [baseline] (1.194 s) : 0, 1193591
Total [baseline] (8.967 s) : 0, 8966778
Agent [candidate] (1.197 s) : 0, 1196525
Total [candidate] (8.977 s) : 0, 8976637

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.072 s	-
Agent	iast	1.203 s	130.213 ms (12.1%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.197 s	124.655 ms (11.6%)
Agent	iast_TELEMETRY_OFF	1.194 s	121.167 ms (11.3%)
Total	tracing	8.52 s	-
Total	iast	9.056 s	536.151 ms (6.3%)
Total	iast_HARDCODED_SECRET_DISABLED	8.956 s	436.976 ms (5.1%)
Total	iast_TELEMETRY_OFF	8.967 s	447.257 ms (5.2%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.073 s	-
Agent	iast	1.202 s	129.362 ms (12.1%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.208 s	135.551 ms (12.6%)
Agent	iast_TELEMETRY_OFF	1.197 s	123.81 ms (11.5%)
Total	tracing	8.57 s	-
Total	iast	9.038 s	467.637 ms (5.5%)
Total	iast_HARDCODED_SECRET_DISABLED	8.996 s	426.101 ms (5.0%)
Total	iast_TELEMETRY_OFF	8.977 s	406.438 ms (4.7%)

gantt
    title insecure-bank - break down per module: candidate=1.34.0-SNAPSHOT~5affc93ea8, baseline=1.34.0-SNAPSHOT~f34dfb52a1

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (671.836 ms) : 0, 671836
BytebuddyAgent [candidate] (671.73 ms) : 0, 671730
GlobalTracer [baseline] (308.623 ms) : 0, 308623
GlobalTracer [candidate] (309.095 ms) : 0, 309095
AppSec [baseline] (49.381 ms) : 0, 49381
AppSec [candidate] (49.375 ms) : 0, 49375
Remote Config [baseline] (660.347 µs) : 0, 660
Remote Config [candidate] (655.407 µs) : 0, 655
Telemetry [baseline] (7.602 ms) : 0, 7602
Telemetry [candidate] (7.589 ms) : 0, 7589
section iast
BytebuddyAgent [baseline] (797.247 ms) : 0, 797247
BytebuddyAgent [candidate] (795.93 ms) : 0, 795930
GlobalTracer [baseline] (288.092 ms) : 0, 288092
GlobalTracer [candidate] (290.343 ms) : 0, 290343
AppSec [baseline] (49.783 ms) : 0, 49783
AppSec [candidate] (50.527 ms) : 0, 50527
IAST [baseline] (25.708 ms) : 0, 25708
IAST [candidate] (23.49 ms) : 0, 23490
Remote Config [baseline] (577.202 µs) : 0, 577
Remote Config [candidate] (578.396 µs) : 0, 578
Telemetry [baseline] (6.592 ms) : 0, 6592
Telemetry [candidate] (6.749 ms) : 0, 6749
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (793.218 ms) : 0, 793218
BytebuddyAgent [candidate] (801.204 ms) : 0, 801204
GlobalTracer [baseline] (287.765 ms) : 0, 287765
GlobalTracer [candidate] (290.284 ms) : 0, 290284
AppSec [baseline] (52.071 ms) : 0, 52071
AppSec [candidate] (50.926 ms) : 0, 50926
IAST [baseline] (22.531 ms) : 0, 22531
IAST [candidate] (23.914 ms) : 0, 23914
Remote Config [baseline] (565.414 µs) : 0, 565
Remote Config [candidate] (558.067 µs) : 0, 558
Telemetry [baseline] (6.598 ms) : 0, 6598
Telemetry [candidate] (6.564 ms) : 0, 6564
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (790.45 ms) : 0, 790450
BytebuddyAgent [candidate] (792.533 ms) : 0, 792533
GlobalTracer [baseline] (287.243 ms) : 0, 287243
GlobalTracer [candidate] (288.612 ms) : 0, 288612
AppSec [baseline] (49.23 ms) : 0, 49230
AppSec [candidate] (48.078 ms) : 0, 48078
IAST [baseline] (23.68 ms) : 0, 23680
IAST [candidate] (24.261 ms) : 0, 24261
Remote Config [baseline] (588.371 µs) : 0, 588
Remote Config [candidate] (579.487 µs) : 0, 579
Telemetry [baseline] (8.021 ms) : 0, 8021
Telemetry [candidate] (8.058 ms) : 0, 8058

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.34.0-SNAPSHOT~5affc93ea8, baseline=1.34.0-SNAPSHOT~f34dfb52a1

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.071 s) : 0, 1070792
Total [baseline] (10.373 s) : 0, 10373278
Agent [candidate] (1.075 s) : 0, 1074873
Total [candidate] (10.348 s) : 0, 10348437
section appsec
Agent [baseline] (1.186 s) : 0, 1186477
Total [baseline] (10.452 s) : 0, 10451690
Agent [candidate] (1.187 s) : 0, 1186818
Total [candidate] (10.482 s) : 0, 10481900
section iast
Agent [baseline] (1.196 s) : 0, 1196295
Total [baseline] (10.652 s) : 0, 10651889
Agent [candidate] (1.198 s) : 0, 1198004
Total [candidate] (10.777 s) : 0, 10776520
section profiling
Agent [baseline] (1.265 s) : 0, 1265347
Total [baseline] (10.555 s) : 0, 10554781
Agent [candidate] (1.266 s) : 0, 1266153
Total [candidate] (10.604 s) : 0, 10603973

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.071 s	-
Agent	appsec	1.186 s	115.685 ms (10.8%)
Agent	iast	1.196 s	125.502 ms (11.7%)
Agent	profiling	1.265 s	194.555 ms (18.2%)
Total	tracing	10.373 s	-
Total	appsec	10.452 s	78.412 ms (0.8%)
Total	iast	10.652 s	278.611 ms (2.7%)
Total	profiling	10.555 s	181.503 ms (1.7%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.075 s	-
Agent	appsec	1.187 s	111.946 ms (10.4%)
Agent	iast	1.198 s	123.131 ms (11.5%)
Agent	profiling	1.266 s	191.281 ms (17.8%)
Total	tracing	10.348 s	-
Total	appsec	10.482 s	133.463 ms (1.3%)
Total	iast	10.777 s	428.083 ms (4.1%)
Total	profiling	10.604 s	255.536 ms (2.5%)

gantt
    title petclinic - break down per module: candidate=1.34.0-SNAPSHOT~5affc93ea8, baseline=1.34.0-SNAPSHOT~f34dfb52a1

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (670.617 ms) : 0, 670617
BytebuddyAgent [candidate] (673.298 ms) : 0, 673298
GlobalTracer [baseline] (308.384 ms) : 0, 308384
GlobalTracer [candidate] (309.554 ms) : 0, 309554
AppSec [baseline] (49.37 ms) : 0, 49370
AppSec [candidate] (49.374 ms) : 0, 49374
Remote Config [baseline] (651.676 µs) : 0, 652
Remote Config [candidate] (658.28 µs) : 0, 658
Telemetry [baseline] (7.566 ms) : 0, 7566
Telemetry [candidate] (7.59 ms) : 0, 7590
section appsec
BytebuddyAgent [baseline] (694.09 ms) : 0, 694090
BytebuddyAgent [candidate] (694.077 ms) : 0, 694077
GlobalTracer [baseline] (290.368 ms) : 0, 290368
GlobalTracer [candidate] (291.097 ms) : 0, 291097
AppSec [baseline] (149.235 ms) : 0, 149235
AppSec [candidate] (149.346 ms) : 0, 149346
Remote Config [baseline] (615.466 µs) : 0, 615
Remote Config [candidate] (619.411 µs) : 0, 619
Telemetry [baseline] (8.181 ms) : 0, 8181
Telemetry [candidate] (7.796 ms) : 0, 7796
IAST [baseline] (19.36 ms) : 0, 19360
IAST [candidate] (19.123 ms) : 0, 19123
section iast
BytebuddyAgent [baseline] (792.358 ms) : 0, 792358
BytebuddyAgent [candidate] (793.814 ms) : 0, 793814
GlobalTracer [baseline] (287.121 ms) : 0, 287121
GlobalTracer [candidate] (287.762 ms) : 0, 287762
AppSec [baseline] (50.239 ms) : 0, 50239
AppSec [candidate] (49.384 ms) : 0, 49384
Remote Config [baseline] (578.805 µs) : 0, 579
Remote Config [candidate] (562.883 µs) : 0, 563
Telemetry [baseline] (7.399 ms) : 0, 7399
Telemetry [candidate] (7.999 ms) : 0, 7999
IAST [baseline] (24.35 ms) : 0, 24350
IAST [candidate] (24.065 ms) : 0, 24065
section profiling
BytebuddyAgent [baseline] (676.144 ms) : 0, 676144
BytebuddyAgent [candidate] (675.973 ms) : 0, 675973
GlobalTracer [baseline] (379.252 ms) : 0, 379252
GlobalTracer [candidate] (379.598 ms) : 0, 379598
AppSec [baseline] (50.01 ms) : 0, 50010
AppSec [candidate] (50.074 ms) : 0, 50074
Remote Config [baseline] (698.855 µs) : 0, 699
Remote Config [candidate] (717.614 µs) : 0, 718
Telemetry [baseline] (7.455 ms) : 0, 7455
Telemetry [candidate] (7.479 ms) : 0, 7479
ProfilingAgent [baseline] (95.554 ms) : 0, 95554
ProfilingAgent [candidate] (95.919 ms) : 0, 95919
Profiling [baseline] (95.578 ms) : 0, 95578
Profiling [candidate] (95.943 ms) : 0, 95943

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2024-04-23T20:12:42	2024-04-23T20:19:28
git_branch	master	ojung/DEBUG-1942-integrate-initial-list-of-third-party-libraries
git_commit_date	1713861708	1713901707
git_commit_sha	`f34dfb5`	`5affc93`
release_version	1.34.0-SNAPSHOT~f34dfb52a1	1.34.0-SNAPSHOT~5affc93ea8
start_time	2024-04-23T20:12:29	2024-04-23T20:19:15

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1713903912	1713903912
ci_job_id	494874954	494874954
ci_pipeline_id	32747992	32747992
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics.

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.34.0-SNAPSHOT~5affc93ea8, baseline=1.34.0-SNAPSHOT~f34dfb52a1
    dateFormat X
    axisFormat %s
section baseline
no_agent (368.608 µs) : 349, 388
.   : milestone, 369,
iast (472.497 µs) : 451, 494
.   : milestone, 472,
iast_FULL (539.343 µs) : 518, 561
.   : milestone, 539,
iast_GLOBAL (490.393 µs) : 469, 511
.   : milestone, 490,
iast_HARDCODED_SECRET_DISABLED (468.759 µs) : 447, 490
.   : milestone, 469,
iast_INACTIVE (446.612 µs) : 426, 468
.   : milestone, 447,
iast_TELEMETRY_OFF (461.224 µs) : 440, 483
.   : milestone, 461,
tracing (445.88 µs) : 425, 467
.   : milestone, 446,
section candidate
no_agent (372.193 µs) : 353, 392
.   : milestone, 372,
iast (473.639 µs) : 453, 495
.   : milestone, 474,
iast_FULL (533.155 µs) : 512, 554
.   : milestone, 533,
iast_GLOBAL (494.385 µs) : 473, 516
.   : milestone, 494,
iast_HARDCODED_SECRET_DISABLED (474.275 µs) : 453, 496
.   : milestone, 474,
iast_INACTIVE (446.573 µs) : 426, 468
.   : milestone, 447,
iast_TELEMETRY_OFF (471.931 µs) : 451, 493
.   : milestone, 472,
tracing (440.356 µs) : 420, 461
.   : milestone, 440,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	368.608 µs [348.881 µs, 388.334 µs]	-
iast	472.497 µs [451.397 µs, 493.598 µs]	103.889 µs (28.2%)
iast_FULL	539.343 µs [517.948 µs, 560.738 µs]	170.735 µs (46.3%)
iast_GLOBAL	490.393 µs [469.316 µs, 511.47 µs]	121.785 µs (33.0%)
iast_HARDCODED_SECRET_DISABLED	468.759 µs [447.234 µs, 490.285 µs]	100.151 µs (27.2%)
iast_INACTIVE	446.612 µs [425.585 µs, 467.638 µs]	78.004 µs (21.2%)
iast_TELEMETRY_OFF	461.224 µs [439.555 µs, 482.894 µs]	92.616 µs (25.1%)
tracing	445.88 µs [424.984 µs, 466.775 µs]	77.272 µs (21.0%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	372.193 µs [352.668 µs, 391.717 µs]	-
iast	473.639 µs [452.711 µs, 494.567 µs]	101.446 µs (27.3%)
iast_FULL	533.155 µs [512.358 µs, 553.952 µs]	160.962 µs (43.2%)
iast_GLOBAL	494.385 µs [473.02 µs, 515.75 µs]	122.192 µs (32.8%)
iast_HARDCODED_SECRET_DISABLED	474.275 µs [452.988 µs, 495.562 µs]	102.082 µs (27.4%)
iast_INACTIVE	446.573 µs [425.588 µs, 467.558 µs]	74.38 µs (20.0%)
iast_TELEMETRY_OFF	471.931 µs [451.132 µs, 492.731 µs]	99.739 µs (26.8%)
tracing	440.356 µs [419.975 µs, 460.738 µs]	68.164 µs (18.3%)

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.34.0-SNAPSHOT~5affc93ea8, baseline=1.34.0-SNAPSHOT~f34dfb52a1
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.356 ms) : 1337, 1375
.   : milestone, 1356,
appsec (1.72 ms) : 1696, 1744
.   : milestone, 1720,
appsec_no_iast (1.714 ms) : 1691, 1738
.   : milestone, 1714,
iast (1.481 ms) : 1458, 1504
.   : milestone, 1481,
profiling (1.485 ms) : 1461, 1509
.   : milestone, 1485,
tracing (1.464 ms) : 1439, 1488
.   : milestone, 1464,
section candidate
no_agent (1.346 ms) : 1327, 1365
.   : milestone, 1346,
appsec (1.727 ms) : 1703, 1751
.   : milestone, 1727,
appsec_no_iast (1.717 ms) : 1694, 1740
.   : milestone, 1717,
iast (1.5 ms) : 1478, 1522
.   : milestone, 1500,
profiling (1.483 ms) : 1458, 1508
.   : milestone, 1483,
tracing (1.48 ms) : 1455, 1505
.   : milestone, 1480,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.356 ms [1.337 ms, 1.375 ms]	-
appsec	1.72 ms [1.696 ms, 1.744 ms]	364.329 µs (26.9%)
appsec_no_iast	1.714 ms [1.691 ms, 1.738 ms]	358.615 µs (26.5%)
iast	1.481 ms [1.458 ms, 1.504 ms]	125.7 µs (9.3%)
profiling	1.485 ms [1.461 ms, 1.509 ms]	129.173 µs (9.5%)
tracing	1.464 ms [1.439 ms, 1.488 ms]	108.221 µs (8.0%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.346 ms [1.327 ms, 1.365 ms]	-
appsec	1.727 ms [1.703 ms, 1.751 ms]	381.624 µs (28.4%)
appsec_no_iast	1.717 ms [1.694 ms, 1.74 ms]	371.287 µs (27.6%)
iast	1.5 ms [1.478 ms, 1.522 ms]	153.953 µs (11.4%)
profiling	1.483 ms [1.458 ms, 1.508 ms]	137.277 µs (10.2%)
tracing	1.48 ms [1.455 ms, 1.505 ms]	134.026 µs (10.0%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	ojung/DEBUG-1942-integrate-initial-list-of-third-party-libraries
git_commit_date	1713861708	1713901707
git_commit_sha	`f34dfb5`	`5affc93`
release_version	1.34.0-SNAPSHOT~f34dfb52a1	1.34.0-SNAPSHOT~5affc93ea8

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1713904411	1713904411
ci_job_id	494874955	494874955
ci_pipeline_id	32747992	32747992
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.34.0-SNAPSHOT~5affc93ea8, baseline=1.34.0-SNAPSHOT~f34dfb52a1
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.458 ms) : 1447, 1470
.   : milestone, 1458,
appsec (2.188 ms) : 2155, 2221
.   : milestone, 2188,
iast (1.875 ms) : 1840, 1910
.   : milestone, 1875,
iast_GLOBAL (1.912 ms) : 1878, 1947
.   : milestone, 1912,
profiling (2.324 ms) : 2145, 2503
.   : milestone, 2324,
tracing (1.831 ms) : 1799, 1863
.   : milestone, 1831,
section candidate
no_agent (1.458 ms) : 1446, 1469
.   : milestone, 1458,
appsec (2.194 ms) : 2160, 2228
.   : milestone, 2194,
iast (1.879 ms) : 1844, 1914
.   : milestone, 1879,
iast_GLOBAL (1.918 ms) : 1883, 1954
.   : milestone, 1918,
profiling (1.845 ms) : 1812, 1878
.   : milestone, 1845,
tracing (1.817 ms) : 1786, 1848
.   : milestone, 1817,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.458 ms [1.447 ms, 1.47 ms]	-
appsec	2.188 ms [2.155 ms, 2.221 ms]	729.895 µs (50.0%)
iast	1.875 ms [1.84 ms, 1.91 ms]	416.678 µs (28.6%)
iast_GLOBAL	1.912 ms [1.878 ms, 1.947 ms]	454.028 µs (31.1%)
profiling	2.324 ms [2.145 ms, 2.503 ms]	865.739 µs (59.4%)
tracing	1.831 ms [1.799 ms, 1.863 ms]	372.496 µs (25.5%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.458 ms [1.446 ms, 1.469 ms]	-
appsec	2.194 ms [2.16 ms, 2.228 ms]	736.727 µs (50.5%)
iast	1.879 ms [1.844 ms, 1.914 ms]	421.291 µs (28.9%)
iast_GLOBAL	1.918 ms [1.883 ms, 1.954 ms]	460.527 µs (31.6%)
profiling	1.845 ms [1.812 ms, 1.878 ms]	387.178 µs (26.6%)
tracing	1.817 ms [1.786 ms, 1.848 ms]	359.109 µs (24.6%)

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.34.0-SNAPSHOT~5affc93ea8, baseline=1.34.0-SNAPSHOT~f34dfb52a1
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.336 s) : 15336000, 15336000
.   : milestone, 15336000,
appsec (15.197 s) : 15197000, 15197000
.   : milestone, 15197000,
iast (18.753 s) : 18753000, 18753000
.   : milestone, 18753000,
iast_GLOBAL (17.848 s) : 17848000, 17848000
.   : milestone, 17848000,
profiling (15.488 s) : 15488000, 15488000
.   : milestone, 15488000,
tracing (15.04 s) : 15040000, 15040000
.   : milestone, 15040000,
section candidate
no_agent (15.432 s) : 15432000, 15432000
.   : milestone, 15432000,
appsec (15.06 s) : 15060000, 15060000
.   : milestone, 15060000,
iast (18.725 s) : 18725000, 18725000
.   : milestone, 18725000,
iast_GLOBAL (17.836 s) : 17836000, 17836000
.   : milestone, 17836000,
profiling (15.026 s) : 15026000, 15026000
.   : milestone, 15026000,
tracing (15.274 s) : 15274000, 15274000
.   : milestone, 15274000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.336 s [15.336 s, 15.336 s]	-
appsec	15.197 s [15.197 s, 15.197 s]	-139.0 ms (-0.9%)
iast	18.753 s [18.753 s, 18.753 s]	3.417 s (22.3%)
iast_GLOBAL	17.848 s [17.848 s, 17.848 s]	2.512 s (16.4%)
profiling	15.488 s [15.488 s, 15.488 s]	152.0 ms (1.0%)
tracing	15.04 s [15.04 s, 15.04 s]	-296.0 ms (-1.9%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.432 s [15.432 s, 15.432 s]	-
appsec	15.06 s [15.06 s, 15.06 s]	-372.0 ms (-2.4%)
iast	18.725 s [18.725 s, 18.725 s]	3.293 s (21.3%)
iast_GLOBAL	17.836 s [17.836 s, 17.836 s]	2.404 s (15.6%)
profiling	15.026 s [15.026 s, 15.026 s]	-406.0 ms (-2.6%)
tracing	15.274 s [15.274 s, 15.274 s]	-158.0 ms (-1.0%)

jpbempel

Looks clean! Thanks!

PerfectSlayer

I reviewed and added few comments.
If Stuarts can also chime in with the native-image question, it could be great.

internal-api/src/main/java/datadog/trace/api/Config.java

PerfectSlayer · 2024-04-22T12:36:36Z

dd-java-agent/agent-debugger/src/main/java/com/datadog/debugger/agent/ThirdPartyLibraries.java

+  private static final JsonAdapter<InternalConfig> ADAPTER =
+      new Moshi.Builder().build().adapter(InternalConfig.class);


I wonder if any Moshi usage should be enclosed into a dedicated static class like here: https://github.com/DataDog/dd-trace-java/pull/6892/files

cc @mcculls

In general yes, but in this case it isn't necessary because native image doesn't support dynamic-instrumentation

This might be something useful to document in some knowledge base. Any idea where to put it?

You could start a new doc under https://github.com/DataDog/dd-trace-java/tree/master/docs ?

Not quite FAQs, but would capture common patterns / recommendations

Good idea. I will start an Instrumentation development pattern document.
We can start aggregate similar tricks and knowledge in it.

add explicit exclusions of JDK packages in tests

PerfectSlayer

Thanks for the changes! 👍
Don’t forget to squash your commits when merging.

ojung requested review from a team as code owners April 19, 2024 16:19

ojung requested review from shatzi, PerfectSlayer and nayeem-kamal and removed request for a team April 19, 2024 16:19

evanchooly approved these changes Apr 19, 2024

View reviewed changes

ojung removed the request for review from shatzi April 21, 2024 16:32

Add third party filtering

8bac278

ojung force-pushed the ojung/DEBUG-1942-integrate-initial-list-of-third-party-libraries branch from 4ad2913 to 8bac278 Compare April 22, 2024 08:40

jpbempel approved these changes Apr 22, 2024

View reviewed changes

PerfectSlayer reviewed Apr 22, 2024

View reviewed changes

use pattern for split

89b4ea2

add explicit exclusions of JDK packages in tests

jpbempel added the comp: debugger Dynamic Instrumentation label Apr 23, 2024

Return Set from config

5affc93

jpbempel approved these changes Apr 24, 2024

View reviewed changes

PerfectSlayer approved these changes Apr 24, 2024

View reviewed changes

ojung merged commit 9821e02 into master Apr 24, 2024
80 checks passed

ojung deleted the ojung/DEBUG-1942-integrate-initial-list-of-third-party-libraries branch April 24, 2024 11:43

github-actions bot added this to the 1.34.0 milestone Apr 24, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Integrate initial list of third party libraries #6928

Integrate initial list of third party libraries #6928

ojung commented Apr 19, 2024 •

edited by jira bot

pr-commenter bot commented Apr 19, 2024 •

edited

jpbempel left a comment

PerfectSlayer left a comment

PerfectSlayer Apr 22, 2024

mcculls Apr 23, 2024

PerfectSlayer Apr 23, 2024

mcculls Apr 24, 2024

PerfectSlayer Apr 24, 2024

PerfectSlayer left a comment

		private static final JsonAdapter<InternalConfig> ADAPTER =
		new Moshi.Builder().build().adapter(InternalConfig.class);

Integrate initial list of third party libraries #6928

Integrate initial list of third party libraries #6928

Conversation

ojung commented Apr 19, 2024 • edited by jira bot

What Does This Do

Motivation

Additional Notes

pr-commenter bot commented Apr 19, 2024 • edited

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

jpbempel left a comment

Choose a reason for hiding this comment

PerfectSlayer left a comment

Choose a reason for hiding this comment

PerfectSlayer Apr 22, 2024

Choose a reason for hiding this comment

mcculls Apr 23, 2024

Choose a reason for hiding this comment

PerfectSlayer Apr 23, 2024

Choose a reason for hiding this comment

mcculls Apr 24, 2024

Choose a reason for hiding this comment

PerfectSlayer Apr 24, 2024

Choose a reason for hiding this comment

PerfectSlayer left a comment

Choose a reason for hiding this comment

ojung commented Apr 19, 2024 •

edited by jira bot

pr-commenter bot commented Apr 19, 2024 •

edited