Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip auto user events when sign-up logic fails #6964

Merged
merged 1 commit into from
May 7, 2024
Merged

Skip auto user events when sign-up logic fails #6964

merged 1 commit into from
May 7, 2024

Conversation

manuel-alvarez-alvarez
Copy link
Member

What Does This Do

Skip generating appsec.events.users.signup.* events in case there is an error in the sign up process.

Motivation

Additional Notes

Jira ticket: [PROJ-IDENT]

@manuel-alvarez-alvarez manuel-alvarez-alvarez added the comp: asm waf Application Security Management (WAF) label Apr 29, 2024
@manuel-alvarez-alvarez manuel-alvarez-alvarez marked this pull request as ready for review April 29, 2024 15:31
@manuel-alvarez-alvarez manuel-alvarez-alvarez requested a review from a team as a code owner April 29, 2024 15:31
@pr-commenter
Copy link

pr-commenter bot commented Apr 29, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master malvarez/asm-skip-failed-signup-events
git_commit_date 1715076464 1715078602
git_commit_sha 2267ce3 0084e4f
release_version 1.34.0-SNAPSHOT~2267ce380f 1.34.0-SNAPSHOT~0084e4f861
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1715081316 1715081316
ci_job_id 505980334 505980334
ci_pipeline_id 33750554 33750554
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 48 metrics, 15 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.34.0-SNAPSHOT~0084e4f861, baseline=1.34.0-SNAPSHOT~2267ce380f

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.081 s) : 0, 1081295
Total [baseline] (8.557 s) : 0, 8557231
Agent [candidate] (1.081 s) : 0, 1080653
Total [candidate] (8.603 s) : 0, 8602964
section iast
Agent [baseline] (1.202 s) : 0, 1202323
Total [baseline] (8.998 s) : 0, 8997775
Agent [candidate] (1.209 s) : 0, 1209105
Total [candidate] (9.014 s) : 0, 9013727
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.223 s) : 0, 1222855
Total [baseline] (8.993 s) : 0, 8993164
Agent [candidate] (1.202 s) : 0, 1201511
Total [candidate] (8.966 s) : 0, 8966372
section iast_TELEMETRY_OFF
Agent [baseline] (1.199 s) : 0, 1199109
Total [baseline] (8.994 s) : 0, 8993660
Agent [candidate] (1.21 s) : 0, 1209917
Total [candidate] (9.005 s) : 0, 9005363
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.081 s -
Agent iast 1.202 s 121.028 ms (11.2%)
Agent iast_HARDCODED_SECRET_DISABLED 1.223 s 141.56 ms (13.1%)
Agent iast_TELEMETRY_OFF 1.199 s 117.814 ms (10.9%)
Total tracing 8.557 s -
Total iast 8.998 s 440.544 ms (5.1%)
Total iast_HARDCODED_SECRET_DISABLED 8.993 s 435.933 ms (5.1%)
Total iast_TELEMETRY_OFF 8.994 s 436.429 ms (5.1%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.081 s -
Agent iast 1.209 s 128.452 ms (11.9%)
Agent iast_HARDCODED_SECRET_DISABLED 1.202 s 120.857 ms (11.2%)
Agent iast_TELEMETRY_OFF 1.21 s 129.263 ms (12.0%)
Total tracing 8.603 s -
Total iast 9.014 s 410.763 ms (4.8%)
Total iast_HARDCODED_SECRET_DISABLED 8.966 s 363.409 ms (4.2%)
Total iast_TELEMETRY_OFF 9.005 s 402.399 ms (4.7%) 
gantt
    title insecure-bank - break down per module: candidate=1.34.0-SNAPSHOT~0084e4f861, baseline=1.34.0-SNAPSHOT~2267ce380f

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (678.073 ms) : 0, 678073
BytebuddyAgent [candidate] (675.866 ms) : 0, 675866
GlobalTracer [baseline] (310.82 ms) : 0, 310820
GlobalTracer [candidate] (312.175 ms) : 0, 312175
AppSec [baseline] (49.528 ms) : 0, 49528
AppSec [candidate] (49.843 ms) : 0, 49843
Remote Config [baseline] (661.046 µs) : 0, 661
Remote Config [candidate] (660.668 µs) : 0, 661
Telemetry [baseline] (7.588 ms) : 0, 7588
Telemetry [candidate] (7.619 ms) : 0, 7619
section iast
BytebuddyAgent [baseline] (794.836 ms) : 0, 794836
BytebuddyAgent [candidate] (800.711 ms) : 0, 800711
GlobalTracer [baseline] (290.783 ms) : 0, 290783
GlobalTracer [candidate] (291.736 ms) : 0, 291736
AppSec [baseline] (50.099 ms) : 0, 50099
AppSec [candidate] (49.23 ms) : 0, 49230
IAST [baseline] (24.271 ms) : 0, 24271
IAST [candidate] (25.472 ms) : 0, 25472
Remote Config [baseline] (1.339 ms) : 0, 1339
Remote Config [candidate] (632.089 µs) : 0, 632
Telemetry [baseline] (6.661 ms) : 0, 6661
Telemetry [candidate] (6.693 ms) : 0, 6693
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (809.316 ms) : 0, 809316
BytebuddyAgent [candidate] (793.691 ms) : 0, 793691
GlobalTracer [baseline] (295.746 ms) : 0, 295746
GlobalTracer [candidate] (291.212 ms) : 0, 291212
AppSec [baseline] (51.267 ms) : 0, 51267
AppSec [candidate] (51.489 ms) : 0, 51489
IAST [baseline] (23.536 ms) : 0, 23536
IAST [candidate] (21.299 ms) : 0, 21299
Remote Config [baseline] (1.332 ms) : 0, 1332
Remote Config [candidate] (2.101 ms) : 0, 2101
Telemetry [baseline] (6.673 ms) : 0, 6673
Telemetry [candidate] (7.421 ms) : 0, 7421
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (792.157 ms) : 0, 792157
BytebuddyAgent [candidate] (798.843 ms) : 0, 798843
GlobalTracer [baseline] (290.606 ms) : 0, 290606
GlobalTracer [candidate] (293.241 ms) : 0, 293241
AppSec [baseline] (49.652 ms) : 0, 49652
AppSec [candidate] (49.033 ms) : 0, 49033
IAST [baseline] (24.607 ms) : 0, 24607
IAST [candidate] (25.462 ms) : 0, 25462
Remote Config [baseline] (595.324 µs) : 0, 595
Remote Config [candidate] (608.694 µs) : 0, 609
Telemetry [baseline] (7.262 ms) : 0, 7262
Telemetry [candidate] (8.14 ms) : 0, 8140
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.34.0-SNAPSHOT~0084e4f861, baseline=1.34.0-SNAPSHOT~2267ce380f

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.082 s) : 0, 1082211
Total [baseline] (10.446 s) : 0, 10445662
Agent [candidate] (1.078 s) : 0, 1077863
Total [candidate] (10.391 s) : 0, 10391221
section appsec
Agent [baseline] (1.197 s) : 0, 1196553
Total [baseline] (10.472 s) : 0, 10472315
Agent [candidate] (1.193 s) : 0, 1193101
Total [candidate] (10.481 s) : 0, 10480685
section iast
Agent [baseline] (1.205 s) : 0, 1205031
Total [baseline] (10.788 s) : 0, 10788044
Agent [candidate] (1.214 s) : 0, 1213572
Total [candidate] (10.822 s) : 0, 10822073
section profiling
Agent [baseline] (1.269 s) : 0, 1268801
Total [baseline] (10.621 s) : 0, 10621453
Agent [candidate] (1.282 s) : 0, 1281993
Total [candidate] (10.681 s) : 0, 10680864
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.082 s -
Agent appsec 1.197 s 114.342 ms (10.6%)
Agent iast 1.205 s 122.82 ms (11.3%)
Agent profiling 1.269 s 186.591 ms (17.2%)
Total tracing 10.446 s -
Total appsec 10.472 s 26.653 ms (0.3%)
Total iast 10.788 s 342.382 ms (3.3%)
Total profiling 10.621 s 175.791 ms (1.7%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.078 s -
Agent appsec 1.193 s 115.238 ms (10.7%)
Agent iast 1.214 s 135.709 ms (12.6%)
Agent profiling 1.282 s 204.129 ms (18.9%)
Total tracing 10.391 s -
Total appsec 10.481 s 89.464 ms (0.9%)
Total iast 10.822 s 430.852 ms (4.1%)
Total profiling 10.681 s 289.642 ms (2.8%) 
gantt
    title petclinic - break down per module: candidate=1.34.0-SNAPSHOT~0084e4f861, baseline=1.34.0-SNAPSHOT~2267ce380f

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (676.124 ms) : 0, 676124
BytebuddyAgent [candidate] (674.947 ms) : 0, 674947
GlobalTracer [baseline] (313.275 ms) : 0, 313275
GlobalTracer [candidate] (310.898 ms) : 0, 310898
AppSec [baseline] (50.135 ms) : 0, 50135
AppSec [candidate] (49.499 ms) : 0, 49499
Remote Config [baseline] (669.144 µs) : 0, 669
Remote Config [candidate] (656.026 µs) : 0, 656
Telemetry [baseline] (7.644 ms) : 0, 7644
Telemetry [candidate] (7.556 ms) : 0, 7556
section appsec
BytebuddyAgent [baseline] (698.147 ms) : 0, 698147
BytebuddyAgent [candidate] (696.42 ms) : 0, 696420
GlobalTracer [baseline] (294.733 ms) : 0, 294733
GlobalTracer [candidate] (293.835 ms) : 0, 293835
AppSec [baseline] (149.711 ms) : 0, 149711
AppSec [candidate] (149.38 ms) : 0, 149380
Remote Config [baseline] (619.393 µs) : 0, 619
Remote Config [candidate] (620.163 µs) : 0, 620
Telemetry [baseline] (9.252 ms) : 0, 9252
Telemetry [candidate] (8.808 ms) : 0, 8808
IAST [baseline] (19.444 ms) : 0, 19444
IAST [candidate] (19.37 ms) : 0, 19370
section iast
BytebuddyAgent [baseline] (795.369 ms) : 0, 795369
BytebuddyAgent [candidate] (802.385 ms) : 0, 802385
GlobalTracer [baseline] (293.464 ms) : 0, 293464
GlobalTracer [candidate] (293.652 ms) : 0, 293652
AppSec [baseline] (50.368 ms) : 0, 50368
AppSec [candidate] (50.564 ms) : 0, 50564
Remote Config [baseline] (599.286 µs) : 0, 599
Remote Config [candidate] (1.281 ms) : 0, 1281
Telemetry [baseline] (7.346 ms) : 0, 7346
Telemetry [candidate] (6.661 ms) : 0, 6661
IAST [baseline] (23.591 ms) : 0, 23591
IAST [candidate] (24.431 ms) : 0, 24431
section profiling
ProfilingAgent [baseline] (96.091 ms) : 0, 96091
ProfilingAgent [candidate] (96.961 ms) : 0, 96961
BytebuddyAgent [baseline] (677.227 ms) : 0, 677227
BytebuddyAgent [candidate] (684.017 ms) : 0, 684017
GlobalTracer [baseline] (380.83 ms) : 0, 380830
GlobalTracer [candidate] (384.856 ms) : 0, 384856
AppSec [baseline] (50.04 ms) : 0, 50040
AppSec [candidate] (50.975 ms) : 0, 50975
Remote Config [baseline] (704.331 µs) : 0, 704
Remote Config [candidate] (732.862 µs) : 0, 733
Telemetry [baseline] (7.456 ms) : 0, 7456
Telemetry [candidate] (7.616 ms) : 0, 7616
Profiling [baseline] (96.117 ms) : 0, 96117
Profiling [candidate] (96.987 ms) : 0, 96987
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-05-07T10:59:53 2024-05-07T11:06:43
git_branch master malvarez/asm-skip-failed-signup-events
git_commit_date 1715076464 1715078602
git_commit_sha 2267ce3 0084e4f
release_version 1.34.0-SNAPSHOT~2267ce380f 1.34.0-SNAPSHOT~0084e4f861
start_time 2024-05-07T10:59:40 2024-05-07T11:06:29
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1715080348 1715080348
ci_job_id 505980335 505980335
ci_pipeline_id 33750554 33750554
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.34.0-SNAPSHOT~0084e4f861, baseline=1.34.0-SNAPSHOT~2267ce380f
    dateFormat X
    axisFormat %s
section baseline
no_agent (373.369 µs) : 354, 393
.   : milestone, 373,
iast (479.546 µs) : 459, 501
.   : milestone, 480,
iast_FULL (541.887 µs) : 521, 562
.   : milestone, 542,
iast_GLOBAL (496.586 µs) : 476, 517
.   : milestone, 497,
iast_HARDCODED_SECRET_DISABLED (475.783 µs) : 455, 497
.   : milestone, 476,
iast_INACTIVE (449.355 µs) : 428, 470
.   : milestone, 449,
iast_TELEMETRY_OFF (472.308 µs) : 451, 493
.   : milestone, 472,
tracing (449.46 µs) : 428, 470
.   : milestone, 449,
section candidate
no_agent (364.702 µs) : 345, 385
.   : milestone, 365,
iast (477.754 µs) : 457, 498
.   : milestone, 478,
iast_FULL (547.089 µs) : 527, 568
.   : milestone, 547,
iast_GLOBAL (509.834 µs) : 488, 532
.   : milestone, 510,
iast_HARDCODED_SECRET_DISABLED (482.519 µs) : 461, 504
.   : milestone, 483,
iast_INACTIVE (449.498 µs) : 429, 470
.   : milestone, 449,
iast_TELEMETRY_OFF (467.698 µs) : 446, 490
.   : milestone, 468,
tracing (453.648 µs) : 432, 475
.   : milestone, 454,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 373.369 µs [353.928 µs, 392.81 µs] -
iast 479.546 µs [458.582 µs, 500.51 µs] 106.177 µs (28.4%)
iast_FULL 541.887 µs [521.365 µs, 562.409 µs] 168.518 µs (45.1%)
iast_GLOBAL 496.586 µs [475.738 µs, 517.435 µs] 123.217 µs (33.0%)
iast_HARDCODED_SECRET_DISABLED 475.783 µs [455.025 µs, 496.541 µs] 102.413 µs (27.4%)
iast_INACTIVE 449.355 µs [428.409 µs, 470.301 µs] 75.985 µs (20.4%)
iast_TELEMETRY_OFF 472.308 µs [451.223 µs, 493.393 µs] 98.939 µs (26.5%)
tracing 449.46 µs [428.433 µs, 470.486 µs] 76.09 µs (20.4%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 364.702 µs [344.732 µs, 384.673 µs] -
iast 477.754 µs [457.339 µs, 498.169 µs] 113.051 µs (31.0%)
iast_FULL 547.089 µs [526.501 µs, 567.677 µs] 182.387 µs (50.0%)
iast_GLOBAL 509.834 µs [487.723 µs, 531.945 µs] 145.132 µs (39.8%)
iast_HARDCODED_SECRET_DISABLED 482.519 µs [461.168 µs, 503.871 µs] 117.817 µs (32.3%)
iast_INACTIVE 449.498 µs [428.715 µs, 470.281 µs] 84.796 µs (23.3%)
iast_TELEMETRY_OFF 467.698 µs [445.752 µs, 489.644 µs] 102.995 µs (28.2%)
tracing 453.648 µs [432.354 µs, 474.942 µs] 88.946 µs (24.4%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.34.0-SNAPSHOT~0084e4f861, baseline=1.34.0-SNAPSHOT~2267ce380f
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.359 ms) : 1339, 1378
.   : milestone, 1359,
appsec (1.715 ms) : 1692, 1738
.   : milestone, 1715,
appsec_no_iast (1.703 ms) : 1678, 1728
.   : milestone, 1703,
iast (1.498 ms) : 1476, 1521
.   : milestone, 1498,
profiling (1.523 ms) : 1499, 1546
.   : milestone, 1523,
tracing (1.478 ms) : 1454, 1503
.   : milestone, 1478,
section candidate
no_agent (1.348 ms) : 1329, 1368
.   : milestone, 1348,
appsec (1.747 ms) : 1723, 1771
.   : milestone, 1747,
appsec_no_iast (1.724 ms) : 1699, 1749
.   : milestone, 1724,
iast (1.492 ms) : 1469, 1515
.   : milestone, 1492,
profiling (1.508 ms) : 1483, 1532
.   : milestone, 1508,
tracing (1.487 ms) : 1464, 1511
.   : milestone, 1487,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.359 ms [1.339 ms, 1.378 ms] -
appsec 1.715 ms [1.692 ms, 1.738 ms] 356.254 µs (26.2%)
appsec_no_iast 1.703 ms [1.678 ms, 1.728 ms] 344.519 µs (25.4%)
iast 1.498 ms [1.476 ms, 1.521 ms] 139.821 µs (10.3%)
profiling 1.523 ms [1.499 ms, 1.546 ms] 163.962 µs (12.1%)
tracing 1.478 ms [1.454 ms, 1.503 ms] 119.745 µs (8.8%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.348 ms [1.329 ms, 1.368 ms] -
appsec 1.747 ms [1.723 ms, 1.771 ms] 398.773 µs (29.6%)
appsec_no_iast 1.724 ms [1.699 ms, 1.749 ms] 376.319 µs (27.9%)
iast 1.492 ms [1.469 ms, 1.515 ms] 143.619 µs (10.7%)
profiling 1.508 ms [1.483 ms, 1.532 ms] 159.579 µs (11.8%)
tracing 1.487 ms [1.464 ms, 1.511 ms] 139.089 µs (10.3%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master malvarez/asm-skip-failed-signup-events
git_commit_date 1715076464 1715078602
git_commit_sha 2267ce3 0084e4f
release_version 1.34.0-SNAPSHOT~2267ce380f 1.34.0-SNAPSHOT~0084e4f861
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1715080846 1715080846
ci_job_id 505980336 505980336
ci_pipeline_id 33750554 33750554
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.34.0-SNAPSHOT~0084e4f861, baseline=1.34.0-SNAPSHOT~2267ce380f
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.471 ms) : 1460, 1483
.   : milestone, 1471,
appsec (2.215 ms) : 2180, 2249
.   : milestone, 2215,
iast (1.905 ms) : 1868, 1941
.   : milestone, 1905,
iast_GLOBAL (1.937 ms) : 1901, 1973
.   : milestone, 1937,
profiling (1.863 ms) : 1829, 1898
.   : milestone, 1863,
tracing (1.831 ms) : 1799, 1863
.   : milestone, 1831,
section candidate
no_agent (1.472 ms) : 1460, 1484
.   : milestone, 1472,
appsec (2.211 ms) : 2177, 2245
.   : milestone, 2211,
iast (1.911 ms) : 1874, 1948
.   : milestone, 1911,
iast_GLOBAL (1.937 ms) : 1901, 1973
.   : milestone, 1937,
profiling (1.855 ms) : 1822, 1888
.   : milestone, 1855,
tracing (1.844 ms) : 1811, 1876
.   : milestone, 1844,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.471 ms [1.46 ms, 1.483 ms] -
appsec 2.215 ms [2.18 ms, 2.249 ms] 743.506 µs (50.5%)
iast 1.905 ms [1.868 ms, 1.941 ms] 433.526 µs (29.5%)
iast_GLOBAL 1.937 ms [1.901 ms, 1.973 ms] 465.786 µs (31.7%)
profiling 1.863 ms [1.829 ms, 1.898 ms] 392.329 µs (26.7%)
tracing 1.831 ms [1.799 ms, 1.863 ms] 359.801 µs (24.5%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.472 ms [1.46 ms, 1.484 ms] -
appsec 2.211 ms [2.177 ms, 2.245 ms] 738.767 µs (50.2%)
iast 1.911 ms [1.874 ms, 1.948 ms] 438.973 µs (29.8%)
iast_GLOBAL 1.937 ms [1.901 ms, 1.973 ms] 464.859 µs (31.6%)
profiling 1.855 ms [1.822 ms, 1.888 ms] 382.633 µs (26.0%)
tracing 1.844 ms [1.811 ms, 1.876 ms] 371.374 µs (25.2%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.34.0-SNAPSHOT~0084e4f861, baseline=1.34.0-SNAPSHOT~2267ce380f
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.032 s) : 15032000, 15032000
.   : milestone, 15032000,
appsec (14.659 s) : 14659000, 14659000
.   : milestone, 14659000,
iast (19.1 s) : 19100000, 19100000
.   : milestone, 19100000,
iast_GLOBAL (17.708 s) : 17708000, 17708000
.   : milestone, 17708000,
profiling (15.597 s) : 15597000, 15597000
.   : milestone, 15597000,
tracing (15.223 s) : 15223000, 15223000
.   : milestone, 15223000,
section candidate
no_agent (15.045 s) : 15045000, 15045000
.   : milestone, 15045000,
appsec (15.092 s) : 15092000, 15092000
.   : milestone, 15092000,
iast (18.674 s) : 18674000, 18674000
.   : milestone, 18674000,
iast_GLOBAL (17.76 s) : 17760000, 17760000
.   : milestone, 17760000,
profiling (15.062 s) : 15062000, 15062000
.   : milestone, 15062000,
tracing (15.25 s) : 15250000, 15250000
.   : milestone, 15250000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.032 s [15.032 s, 15.032 s] -
appsec 14.659 s [14.659 s, 14.659 s] -373.0 ms (-2.5%)
iast 19.1 s [19.1 s, 19.1 s] 4.068 s (27.1%)
iast_GLOBAL 17.708 s [17.708 s, 17.708 s] 2.676 s (17.8%)
profiling 15.597 s [15.597 s, 15.597 s] 565.0 ms (3.8%)
tracing 15.223 s [15.223 s, 15.223 s] 191.0 ms (1.3%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.045 s [15.045 s, 15.045 s] -
appsec 15.092 s [15.092 s, 15.092 s] 47.0 ms (0.3%)
iast 18.674 s [18.674 s, 18.674 s] 3.629 s (24.1%)
iast_GLOBAL 17.76 s [17.76 s, 17.76 s] 2.715 s (18.0%)
profiling 15.062 s [15.062 s, 15.062 s] 17.0 ms (0.1%)
tracing 15.25 s [15.25 s, 15.25 s] 205.0 ms (1.4%)

@manuel-alvarez-alvarez manuel-alvarez-alvarez force-pushed the malvarez/asm-skip-failed-signup-events branch from 920fe3f to 074b915 Compare May 7, 2024 07:06
@manuel-alvarez-alvarez manuel-alvarez-alvarez force-pushed the malvarez/asm-skip-failed-signup-events branch from 074b915 to 0084e4f Compare May 7, 2024 10:43
@manuel-alvarez-alvarez manuel-alvarez-alvarez merged commit 23683a0 into master May 7, 2024
80 checks passed
@manuel-alvarez-alvarez manuel-alvarez-alvarez deleted the malvarez/asm-skip-failed-signup-events branch May 7, 2024 12:04
@github-actions github-actions bot added this to the 1.34.0 milestone May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ValentinZakharov ValentinZakharov ValentinZakharov approved these changes

@smola smola smola approved these changes

Assignees
No one assigned
Labels
comp: asm waf Application Security Management (WAF)
Projects
None yet
Milestone
1.34.0
Development

Successfully merging this pull request may close these issues.
3 participants
@manuel-alvarez-alvarez @smola @ValentinZakharov