Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add test set for tomcat 11 #6966

Merged
merged 1 commit into from
Apr 30, 2024
Merged

add test set for tomcat 11 #6966

merged 1 commit into from
Apr 30, 2024

Conversation

amarziali
Copy link
Collaborator

@amarziali amarziali commented Apr 29, 2024 •
edited by jira bot

What Does This Do

Add test suites for the upcoming tomcat 11. Smoke tests will be added as soon as spring boot will bump its tomcat dependencies

Motivation

Additional Notes

Jira ticket: AIDM-53

@pr-commenter
Copy link

pr-commenter bot commented Apr 29, 2024 •
edited

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/tomcat11
git_commit_date 1714482408 1714483099
git_commit_sha fcfaf54 703479b
release_version 1.34.0-SNAPSHOT~fcfaf54d06 1.34.0-SNAPSHOT~703479b42b
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1714485519 1714485519
ci_job_id 500787682 500787682
ci_pipeline_id 33249362 33249362
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 48 metrics, 15 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.34.0-SNAPSHOT~703479b42b, baseline=1.34.0-SNAPSHOT~fcfaf54d06

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.08 s) : 0, 1080245
Total [baseline] (8.589 s) : 0, 8588514
Agent [candidate] (1.085 s) : 0, 1085031
Total [candidate] (8.61 s) : 0, 8610292
section iast
Agent [baseline] (1.199 s) : 0, 1199413
Total [baseline] (9.062 s) : 0, 9061538
Agent [candidate] (1.199 s) : 0, 1199350
Total [candidate] (8.997 s) : 0, 8997299
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.204 s) : 0, 1203951
Total [baseline] (8.995 s) : 0, 8994604
Agent [candidate] (1.203 s) : 0, 1203301
Total [candidate] (8.988 s) : 0, 8988443
section iast_TELEMETRY_OFF
Agent [baseline] (1.197 s) : 0, 1197316
Total [baseline] (8.986 s) : 0, 8986229
Agent [candidate] (1.2 s) : 0, 1199956
Total [candidate] (9.043 s) : 0, 9043002
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.08 s -
Agent iast 1.199 s 119.168 ms (11.0%)
Agent iast_HARDCODED_SECRET_DISABLED 1.204 s 123.706 ms (11.5%)
Agent iast_TELEMETRY_OFF 1.197 s 117.071 ms (10.8%)
Total tracing 8.589 s -
Total iast 9.062 s 473.024 ms (5.5%)
Total iast_HARDCODED_SECRET_DISABLED 8.995 s 406.09 ms (4.7%)
Total iast_TELEMETRY_OFF 8.986 s 397.715 ms (4.6%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.085 s -
Agent iast 1.199 s 114.32 ms (10.5%)
Agent iast_HARDCODED_SECRET_DISABLED 1.203 s 118.271 ms (10.9%)
Agent iast_TELEMETRY_OFF 1.2 s 114.925 ms (10.6%)
Total tracing 8.61 s -
Total iast 8.997 s 387.007 ms (4.5%)
Total iast_HARDCODED_SECRET_DISABLED 8.988 s 378.151 ms (4.4%)
Total iast_TELEMETRY_OFF 9.043 s 432.711 ms (5.0%) 
gantt
    title insecure-bank - break down per module: candidate=1.34.0-SNAPSHOT~703479b42b, baseline=1.34.0-SNAPSHOT~fcfaf54d06

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (675.229 ms) : 0, 675229
BytebuddyAgent [candidate] (679.95 ms) : 0, 679950
GlobalTracer [baseline] (312.487 ms) : 0, 312487
GlobalTracer [candidate] (312.181 ms) : 0, 312181
AppSec [baseline] (49.725 ms) : 0, 49725
AppSec [candidate] (49.956 ms) : 0, 49956
Remote Config [baseline] (662.086 µs) : 0, 662
Remote Config [candidate] (672.099 µs) : 0, 672
Telemetry [baseline] (7.613 ms) : 0, 7613
Telemetry [candidate] (7.662 ms) : 0, 7662
section iast
BytebuddyAgent [baseline] (794.568 ms) : 0, 794568
BytebuddyAgent [candidate] (794.977 ms) : 0, 794977
GlobalTracer [baseline] (288.285 ms) : 0, 288285
GlobalTracer [candidate] (287.892 ms) : 0, 287892
AppSec [baseline] (52.709 ms) : 0, 52709
AppSec [candidate] (51.66 ms) : 0, 51660
IAST [baseline] (22.461 ms) : 0, 22461
IAST [candidate] (23.155 ms) : 0, 23155
Remote Config [baseline] (571.278 µs) : 0, 571
Remote Config [candidate] (645.874 µs) : 0, 646
Telemetry [baseline] (6.616 ms) : 0, 6616
Telemetry [candidate] (6.668 ms) : 0, 6668
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (798.959 ms) : 0, 798959
BytebuddyAgent [candidate] (796.15 ms) : 0, 796150
GlobalTracer [baseline] (288.089 ms) : 0, 288089
GlobalTracer [candidate] (289.352 ms) : 0, 289352
AppSec [baseline] (51.139 ms) : 0, 51139
AppSec [candidate] (50.182 ms) : 0, 50182
IAST [baseline] (22.556 ms) : 0, 22556
IAST [candidate] (25.831 ms) : 0, 25831
Remote Config [baseline] (573.857 µs) : 0, 574
Remote Config [candidate] (636.255 µs) : 0, 636
Telemetry [baseline] (8.137 ms) : 0, 8137
Telemetry [candidate] (6.623 ms) : 0, 6623
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (792.347 ms) : 0, 792347
BytebuddyAgent [candidate] (793.646 ms) : 0, 793646
GlobalTracer [baseline] (288.467 ms) : 0, 288467
GlobalTracer [candidate] (289.45 ms) : 0, 289450
AppSec [baseline] (51.281 ms) : 0, 51281
AppSec [candidate] (51.397 ms) : 0, 51397
IAST [baseline] (22.274 ms) : 0, 22274
IAST [candidate] (23.102 ms) : 0, 23102
Remote Config [baseline] (575.291 µs) : 0, 575
Remote Config [candidate] (583.483 µs) : 0, 583
Telemetry [baseline] (8.054 ms) : 0, 8054
Telemetry [candidate] (7.364 ms) : 0, 7364
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.34.0-SNAPSHOT~703479b42b, baseline=1.34.0-SNAPSHOT~fcfaf54d06

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.077 s) : 0, 1076909
Total [baseline] (10.412 s) : 0, 10412152
Agent [candidate] (1.078 s) : 0, 1077617
Total [candidate] (10.353 s) : 0, 10352922
section appsec
Agent [baseline] (1.189 s) : 0, 1188998
Total [baseline] (10.52 s) : 0, 10519576
Agent [candidate] (1.19 s) : 0, 1189895
Total [candidate] (10.441 s) : 0, 10440539
section iast
Agent [baseline] (1.202 s) : 0, 1202067
Total [baseline] (10.766 s) : 0, 10766204
Agent [candidate] (1.207 s) : 0, 1207083
Total [candidate] (10.797 s) : 0, 10796786
section profiling
Agent [baseline] (1.27 s) : 0, 1269588
Total [baseline] (10.668 s) : 0, 10668129
Agent [candidate] (1.27 s) : 0, 1269831
Total [candidate] (10.599 s) : 0, 10599260
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.077 s -
Agent appsec 1.189 s 112.089 ms (10.4%)
Agent iast 1.202 s 125.158 ms (11.6%)
Agent profiling 1.27 s 192.679 ms (17.9%)
Total tracing 10.412 s -
Total appsec 10.52 s 107.424 ms (1.0%)
Total iast 10.766 s 354.052 ms (3.4%)
Total profiling 10.668 s 255.976 ms (2.5%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.078 s -
Agent appsec 1.19 s 112.278 ms (10.4%)
Agent iast 1.207 s 129.466 ms (12.0%)
Agent profiling 1.27 s 192.214 ms (17.8%)
Total tracing 10.353 s -
Total appsec 10.441 s 87.617 ms (0.8%)
Total iast 10.797 s 443.864 ms (4.3%)
Total profiling 10.599 s 246.338 ms (2.4%) 
gantt
    title petclinic - break down per module: candidate=1.34.0-SNAPSHOT~703479b42b, baseline=1.34.0-SNAPSHOT~fcfaf54d06

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (674.755 ms) : 0, 674755
BytebuddyAgent [candidate] (675.307 ms) : 0, 675307
GlobalTracer [baseline] (309.942 ms) : 0, 309942
GlobalTracer [candidate] (309.942 ms) : 0, 309942
AppSec [baseline] (49.431 ms) : 0, 49431
AppSec [candidate] (49.611 ms) : 0, 49611
Remote Config [baseline] (658.308 µs) : 0, 658
Remote Config [candidate] (657.453 µs) : 0, 657
Telemetry [baseline] (7.603 ms) : 0, 7603
Telemetry [candidate] (7.669 ms) : 0, 7669
section appsec
BytebuddyAgent [baseline] (695.416 ms) : 0, 695416
BytebuddyAgent [candidate] (695.296 ms) : 0, 695296
GlobalTracer [baseline] (291.366 ms) : 0, 291366
GlobalTracer [candidate] (291.672 ms) : 0, 291672
AppSec [baseline] (149.845 ms) : 0, 149845
AppSec [candidate] (149.186 ms) : 0, 149186
Remote Config [baseline] (627.848 µs) : 0, 628
Remote Config [candidate] (619.182 µs) : 0, 619
Telemetry [baseline] (7.59 ms) : 0, 7590
Telemetry [candidate] (9.166 ms) : 0, 9166
IAST [baseline] (19.601 ms) : 0, 19601
IAST [candidate] (19.204 ms) : 0, 19204
section iast
BytebuddyAgent [baseline] (795.763 ms) : 0, 795763
BytebuddyAgent [candidate] (800.025 ms) : 0, 800025
GlobalTracer [baseline] (288.981 ms) : 0, 288981
GlobalTracer [candidate] (290.545 ms) : 0, 290545
AppSec [baseline] (47.483 ms) : 0, 47483
AppSec [candidate] (49.655 ms) : 0, 49655
Remote Config [baseline] (1.288 ms) : 0, 1288
Remote Config [candidate] (566.361 µs) : 0, 566
Telemetry [baseline] (7.318 ms) : 0, 7318
Telemetry [candidate] (6.623 ms) : 0, 6623
IAST [baseline] (26.768 ms) : 0, 26768
IAST [candidate] (25.019 ms) : 0, 25019
section profiling
BytebuddyAgent [baseline] (678.612 ms) : 0, 678612
BytebuddyAgent [candidate] (678.131 ms) : 0, 678131
GlobalTracer [baseline] (380.39 ms) : 0, 380390
GlobalTracer [candidate] (380.643 ms) : 0, 380643
AppSec [baseline] (50.083 ms) : 0, 50083
AppSec [candidate] (50.421 ms) : 0, 50421
Remote Config [baseline] (708.269 µs) : 0, 708
Remote Config [candidate] (705.178 µs) : 0, 705
Telemetry [baseline] (7.501 ms) : 0, 7501
Telemetry [candidate] (7.458 ms) : 0, 7458
ProfilingAgent [baseline] (95.884 ms) : 0, 95884
ProfilingAgent [candidate] (95.93 ms) : 0, 95930
Profiling [baseline] (95.908 ms) : 0, 95908
Profiling [candidate] (95.954 ms) : 0, 95954

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-04-30T13:31:39 2024-04-30T13:38:29
git_branch master andrea.marziali/tomcat11
git_commit_date 1714482408 1714483099
git_commit_sha fcfaf54 703479b
release_version 1.34.0-SNAPSHOT~fcfaf54d06 1.34.0-SNAPSHOT~703479b42b
start_time 2024-04-30T13:31:25 2024-04-30T13:38:16
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1714484656 1714484656
ci_job_id 500787683 500787683
ci_pipeline_id 33249362 33249362
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.34.0-SNAPSHOT~703479b42b, baseline=1.34.0-SNAPSHOT~fcfaf54d06
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.347 ms) : 1328, 1367
.   : milestone, 1347,
appsec (1.72 ms) : 1696, 1745
.   : milestone, 1720,
appsec_no_iast (1.726 ms) : 1702, 1749
.   : milestone, 1726,
iast (1.499 ms) : 1476, 1522
.   : milestone, 1499,
profiling (1.553 ms) : 1527, 1579
.   : milestone, 1553,
tracing (1.476 ms) : 1452, 1499
.   : milestone, 1476,
section candidate
no_agent (1.35 ms) : 1329, 1370
.   : milestone, 1350,
appsec (1.744 ms) : 1720, 1767
.   : milestone, 1744,
appsec_no_iast (1.733 ms) : 1708, 1757
.   : milestone, 1733,
iast (1.499 ms) : 1476, 1521
.   : milestone, 1499,
profiling (1.552 ms) : 1525, 1580
.   : milestone, 1552,
tracing (1.476 ms) : 1451, 1501
.   : milestone, 1476,
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.347 ms [1.328 ms, 1.367 ms] -
appsec 1.72 ms [1.696 ms, 1.745 ms] 372.997 µs (27.7%)
appsec_no_iast 1.726 ms [1.702 ms, 1.749 ms] 378.213 µs (28.1%)
iast 1.499 ms [1.476 ms, 1.522 ms] 151.282 µs (11.2%)
profiling 1.553 ms [1.527 ms, 1.579 ms] 205.861 µs (15.3%)
tracing 1.476 ms [1.452 ms, 1.499 ms] 128.16 µs (9.5%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.35 ms [1.329 ms, 1.37 ms] -
appsec 1.744 ms [1.72 ms, 1.767 ms] 394.283 µs (29.2%)
appsec_no_iast 1.733 ms [1.708 ms, 1.757 ms] 383.194 µs (28.4%)
iast 1.499 ms [1.476 ms, 1.521 ms] 149.016 µs (11.0%)
profiling 1.552 ms [1.525 ms, 1.58 ms] 202.948 µs (15.0%)
tracing 1.476 ms [1.451 ms, 1.501 ms] 126.754 µs (9.4%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.34.0-SNAPSHOT~703479b42b, baseline=1.34.0-SNAPSHOT~fcfaf54d06
    dateFormat X
    axisFormat %s
section baseline
no_agent (372.709 µs) : 353, 393
.   : milestone, 373,
iast (487.377 µs) : 467, 508
.   : milestone, 487,
iast_FULL (549.543 µs) : 528, 571
.   : milestone, 550,
iast_GLOBAL (497.979 µs) : 478, 518
.   : milestone, 498,
iast_HARDCODED_SECRET_DISABLED (485.503 µs) : 463, 508
.   : milestone, 486,
iast_INACTIVE (450.061 µs) : 430, 470
.   : milestone, 450,
iast_TELEMETRY_OFF (474.147 µs) : 453, 495
.   : milestone, 474,
tracing (451.925 µs) : 431, 473
.   : milestone, 452,
section candidate
no_agent (370.324 µs) : 351, 390
.   : milestone, 370,
iast (477.369 µs) : 457, 498
.   : milestone, 477,
iast_FULL (546.552 µs) : 526, 567
.   : milestone, 547,
iast_GLOBAL (499.208 µs) : 479, 520
.   : milestone, 499,
iast_HARDCODED_SECRET_DISABLED (480.109 µs) : 459, 501
.   : milestone, 480,
iast_INACTIVE (459.339 µs) : 438, 481
.   : milestone, 459,
iast_TELEMETRY_OFF (481.913 µs) : 461, 503
.   : milestone, 482,
tracing (450.372 µs) : 429, 472
.   : milestone, 450,
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 372.709 µs [352.609 µs, 392.808 µs] -
iast 487.377 µs [466.544 µs, 508.211 µs] 114.669 µs (30.8%)
iast_FULL 549.543 µs [528.121 µs, 570.964 µs] 176.834 µs (47.4%)
iast_GLOBAL 497.979 µs [477.532 µs, 518.427 µs] 125.27 µs (33.6%)
iast_HARDCODED_SECRET_DISABLED 485.503 µs [463.227 µs, 507.779 µs] 112.794 µs (30.3%)
iast_INACTIVE 450.061 µs [429.639 µs, 470.484 µs] 77.353 µs (20.8%)
iast_TELEMETRY_OFF 474.147 µs [453.177 µs, 495.116 µs] 101.438 µs (27.2%)
tracing 451.925 µs [430.705 µs, 473.146 µs] 79.217 µs (21.3%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 370.324 µs [350.776 µs, 389.872 µs] -
iast 477.369 µs [456.829 µs, 497.909 µs] 107.045 µs (28.9%)
iast_FULL 546.552 µs [526.101 µs, 567.004 µs] 176.228 µs (47.6%)
iast_GLOBAL 499.208 µs [478.845 µs, 519.572 µs] 128.884 µs (34.8%)
iast_HARDCODED_SECRET_DISABLED 480.109 µs [459.177 µs, 501.041 µs] 109.785 µs (29.6%)
iast_INACTIVE 459.339 µs [437.998 µs, 480.68 µs] 89.015 µs (24.0%)
iast_TELEMETRY_OFF 481.913 µs [460.549 µs, 503.278 µs] 111.589 µs (30.1%)
tracing 450.372 µs [428.77 µs, 471.973 µs] 80.048 µs (21.6%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/tomcat11
git_commit_date 1714482408 1714483099
git_commit_sha fcfaf54 703479b
release_version 1.34.0-SNAPSHOT~fcfaf54d06 1.34.0-SNAPSHOT~703479b42b
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1714485161 1714485161
ci_job_id 500787684 500787684
ci_pipeline_id 33249362 33249362
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.34.0-SNAPSHOT~703479b42b, baseline=1.34.0-SNAPSHOT~fcfaf54d06
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.455 ms) : 1444, 1466
.   : milestone, 1455,
appsec (2.189 ms) : 2155, 2223
.   : milestone, 2189,
iast (1.879 ms) : 1843, 1914
.   : milestone, 1879,
iast_GLOBAL (1.911 ms) : 1875, 1946
.   : milestone, 1911,
profiling (1.837 ms) : 1804, 1870
.   : milestone, 1837,
tracing (1.827 ms) : 1795, 1860
.   : milestone, 1827,
section candidate
no_agent (1.459 ms) : 1447, 1470
.   : milestone, 1459,
appsec (2.196 ms) : 2162, 2230
.   : milestone, 2196,
iast (1.881 ms) : 1845, 1916
.   : milestone, 1881,
iast_GLOBAL (1.902 ms) : 1867, 1937
.   : milestone, 1902,
profiling (1.832 ms) : 1800, 1865
.   : milestone, 1832,
tracing (1.828 ms) : 1796, 1861
.   : milestone, 1828,
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.455 ms [1.444 ms, 1.466 ms] -
appsec 2.189 ms [2.155 ms, 2.223 ms] 733.618 µs (50.4%)
iast 1.879 ms [1.843 ms, 1.914 ms] 423.876 µs (29.1%)
iast_GLOBAL 1.911 ms [1.875 ms, 1.946 ms] 455.732 µs (31.3%)
profiling 1.837 ms [1.804 ms, 1.87 ms] 381.739 µs (26.2%)
tracing 1.827 ms [1.795 ms, 1.86 ms] 372.447 µs (25.6%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.459 ms [1.447 ms, 1.47 ms] -
appsec 2.196 ms [2.162 ms, 2.23 ms] 737.18 µs (50.5%)
iast 1.881 ms [1.845 ms, 1.916 ms] 421.995 µs (28.9%)
iast_GLOBAL 1.902 ms [1.867 ms, 1.937 ms] 443.157 µs (30.4%)
profiling 1.832 ms [1.8 ms, 1.865 ms] 373.737 µs (25.6%)
tracing 1.828 ms [1.796 ms, 1.861 ms] 369.847 µs (25.4%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.34.0-SNAPSHOT~703479b42b, baseline=1.34.0-SNAPSHOT~fcfaf54d06
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.594 s) : 15594000, 15594000
.   : milestone, 15594000,
appsec (15.153 s) : 15153000, 15153000
.   : milestone, 15153000,
iast (18.735 s) : 18735000, 18735000
.   : milestone, 18735000,
iast_GLOBAL (17.924 s) : 17924000, 17924000
.   : milestone, 17924000,
profiling (15.06 s) : 15060000, 15060000
.   : milestone, 15060000,
tracing (15.124 s) : 15124000, 15124000
.   : milestone, 15124000,
section candidate
no_agent (15.03 s) : 15030000, 15030000
.   : milestone, 15030000,
appsec (14.908 s) : 14908000, 14908000
.   : milestone, 14908000,
iast (18.8 s) : 18800000, 18800000
.   : milestone, 18800000,
iast_GLOBAL (17.829 s) : 17829000, 17829000
.   : milestone, 17829000,
profiling (15.796 s) : 15796000, 15796000
.   : milestone, 15796000,
tracing (15.023 s) : 15023000, 15023000
.   : milestone, 15023000,
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.594 s [15.594 s, 15.594 s] -
appsec 15.153 s [15.153 s, 15.153 s] -441.0 ms (-2.8%)
iast 18.735 s [18.735 s, 18.735 s] 3.141 s (20.1%)
iast_GLOBAL 17.924 s [17.924 s, 17.924 s] 2.33 s (14.9%)
profiling 15.06 s [15.06 s, 15.06 s] -534.0 ms (-3.4%)
tracing 15.124 s [15.124 s, 15.124 s] -470.0 ms (-3.0%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.03 s [15.03 s, 15.03 s] -
appsec 14.908 s [14.908 s, 14.908 s] -122.0 ms (-0.8%)
iast 18.8 s [18.8 s, 18.8 s] 3.77 s (25.1%)
iast_GLOBAL 17.829 s [17.829 s, 17.829 s] 2.799 s (18.6%)
profiling 15.796 s [15.796 s, 15.796 s] 766.0 ms (5.1%)
tracing 15.023 s [15.023 s, 15.023 s] -7.0 ms (-0.0%)

@amarziali amarziali marked this pull request as ready for review April 30, 2024 08:55
@amarziali amarziali requested a review from a team as a code owner April 30, 2024 08:55
@amarziali amarziali requested review from mcculls and ygree April 30, 2024 08:55
ygree
ygree approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@ygree ygree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amarziali amarziali merged commit 7cbd5a5 into master Apr 30, 2024
80 checks passed
@amarziali amarziali deleted the andrea.marziali/tomcat11 branch April 30, 2024 15:34
@github-actions github-actions bot added this to the 1.34.0 milestone Apr 30, 2024
@amarziali amarziali added comp: testing Testing tag: no release notes Changes to exclude from release notes and removed tag: no release notes Changes to exclude from release notes labels Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ygree ygree ygree approved these changes

@mcculls mcculls Awaiting requested review from mcculls mcculls was automatically assigned from DataDog/apm-java

Assignees
No one assigned
Labels
comp: testing Testing
Projects
None yet
Milestone
1.34.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@amarziali @ygree