-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Process 'sampling.priority' tags #6971
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcculls
added
inst: opentelemetry
OpenTelemetry instrumentation
comp: opentracing
OpenTracing
labels
Apr 30, 2024
mcculls
force-pushed
the
mcculls/process-sampling.priority-tags
branch
from
April 30, 2024 08:48
05a1b93
to
86d12e2
Compare
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 48 metrics, 15 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.34.0-SNAPSHOT~86d12e2222, baseline=1.34.0-SNAPSHOT~d3eae46967
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.086 s) : 0, 1086136
Total [baseline] (10.405 s) : 0, 10405046
Agent [candidate] (1.077 s) : 0, 1076519
Total [candidate] (10.34 s) : 0, 10340269
section appsec
Agent [baseline] (1.19 s) : 0, 1189770
Total [baseline] (10.528 s) : 0, 10527932
Agent [candidate] (1.189 s) : 0, 1188852
Total [candidate] (10.522 s) : 0, 10522424
section iast
Agent [baseline] (1.2 s) : 0, 1200382
Total [baseline] (10.678 s) : 0, 10678352
Agent [candidate] (1.219 s) : 0, 1218905
Total [candidate] (10.931 s) : 0, 10931104
section profiling
Agent [baseline] (1.269 s) : 0, 1269090
Total [baseline] (10.599 s) : 0, 10599275
Agent [candidate] (1.269 s) : 0, 1268800
Total [candidate] (10.7 s) : 0, 10699806
gantt
title petclinic - break down per module: candidate=1.34.0-SNAPSHOT~86d12e2222, baseline=1.34.0-SNAPSHOT~d3eae46967
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (680.348 ms) : 0, 680348
BytebuddyAgent [candidate] (674.236 ms) : 0, 674236
GlobalTracer [baseline] (312.925 ms) : 0, 312925
GlobalTracer [candidate] (310.189 ms) : 0, 310189
AppSec [baseline] (49.879 ms) : 0, 49879
AppSec [candidate] (49.339 ms) : 0, 49339
Remote Config [baseline] (668.49 µs) : 0, 668
Remote Config [candidate] (665.209 µs) : 0, 665
Telemetry [baseline] (7.674 ms) : 0, 7674
Telemetry [candidate] (7.659 ms) : 0, 7659
section appsec
BytebuddyAgent [baseline] (695.475 ms) : 0, 695475
BytebuddyAgent [candidate] (694.999 ms) : 0, 694999
GlobalTracer [baseline] (291.393 ms) : 0, 291393
GlobalTracer [candidate] (291.394 ms) : 0, 291394
AppSec [baseline] (149.44 ms) : 0, 149440
AppSec [candidate] (149.045 ms) : 0, 149045
IAST [baseline] (19.227 ms) : 0, 19227
IAST [candidate] (19.267 ms) : 0, 19267
Remote Config [baseline] (626.606 µs) : 0, 627
Remote Config [candidate] (618.39 µs) : 0, 618
Telemetry [baseline] (8.858 ms) : 0, 8858
Telemetry [candidate] (8.782 ms) : 0, 8782
section iast
BytebuddyAgent [baseline] (794.412 ms) : 0, 794412
BytebuddyAgent [candidate] (807.611 ms) : 0, 807611
GlobalTracer [baseline] (288.423 ms) : 0, 288423
GlobalTracer [candidate] (292.596 ms) : 0, 292596
AppSec [baseline] (50.854 ms) : 0, 50854
AppSec [candidate] (51.997 ms) : 0, 51997
IAST [baseline] (24.4 ms) : 0, 24400
IAST [candidate] (24.361 ms) : 0, 24361
Remote Config [baseline] (568.024 µs) : 0, 568
Remote Config [candidate] (687.804 µs) : 0, 688
Telemetry [baseline] (7.366 ms) : 0, 7366
Telemetry [candidate] (6.71 ms) : 0, 6710
section profiling
BytebuddyAgent [baseline] (678.188 ms) : 0, 678188
BytebuddyAgent [candidate] (677.403 ms) : 0, 677403
GlobalTracer [baseline] (380.411 ms) : 0, 380411
GlobalTracer [candidate] (380.402 ms) : 0, 380402
AppSec [baseline] (50.201 ms) : 0, 50201
AppSec [candidate] (50.376 ms) : 0, 50376
Remote Config [baseline] (703.42 µs) : 0, 703
Remote Config [candidate] (712.912 µs) : 0, 713
Telemetry [baseline] (7.473 ms) : 0, 7473
Telemetry [candidate] (7.463 ms) : 0, 7463
ProfilingAgent [baseline] (95.725 ms) : 0, 95725
ProfilingAgent [candidate] (96.143 ms) : 0, 96143
Profiling [baseline] (95.749 ms) : 0, 95749
Profiling [candidate] (96.167 ms) : 0, 96167
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.34.0-SNAPSHOT~86d12e2222, baseline=1.34.0-SNAPSHOT~d3eae46967
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.073 s) : 0, 1073120
Total [baseline] (8.552 s) : 0, 8551879
Agent [candidate] (1.076 s) : 0, 1076015
Total [candidate] (8.542 s) : 0, 8542197
section iast
Agent [baseline] (1.207 s) : 0, 1207114
Total [baseline] (9.012 s) : 0, 9012442
Agent [candidate] (1.208 s) : 0, 1208051
Total [candidate] (9.005 s) : 0, 9005475
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.198 s) : 0, 1198351
Total [baseline] (8.976 s) : 0, 8975879
Agent [candidate] (1.217 s) : 0, 1217058
Total [candidate] (9.051 s) : 0, 9050861
section iast_TELEMETRY_OFF
Agent [baseline] (1.196 s) : 0, 1195976
Total [baseline] (8.992 s) : 0, 8991866
Agent [candidate] (1.196 s) : 0, 1195801
Total [candidate] (8.999 s) : 0, 8999067
gantt
title insecure-bank - break down per module: candidate=1.34.0-SNAPSHOT~86d12e2222, baseline=1.34.0-SNAPSHOT~d3eae46967
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (672.404 ms) : 0, 672404
BytebuddyAgent [candidate] (673.831 ms) : 0, 673831
GlobalTracer [baseline] (308.774 ms) : 0, 308774
GlobalTracer [candidate] (310.272 ms) : 0, 310272
AppSec [baseline] (49.394 ms) : 0, 49394
AppSec [candidate] (49.37 ms) : 0, 49370
Remote Config [baseline] (661.285 µs) : 0, 661
Remote Config [candidate] (654.335 µs) : 0, 654
Telemetry [baseline] (7.638 ms) : 0, 7638
Telemetry [candidate] (7.554 ms) : 0, 7554
section iast
BytebuddyAgent [baseline] (799.853 ms) : 0, 799853
BytebuddyAgent [candidate] (800.385 ms) : 0, 800385
GlobalTracer [baseline] (289.646 ms) : 0, 289646
GlobalTracer [candidate] (290.143 ms) : 0, 290143
AppSec [baseline] (51.41 ms) : 0, 51410
AppSec [candidate] (50.475 ms) : 0, 50475
IAST [baseline] (24.309 ms) : 0, 24309
IAST [candidate] (25.22 ms) : 0, 25220
Remote Config [baseline] (665.762 µs) : 0, 666
Remote Config [candidate] (581.197 µs) : 0, 581
Telemetry [baseline] (6.66 ms) : 0, 6660
Telemetry [candidate] (6.68 ms) : 0, 6680
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (793.389 ms) : 0, 793389
BytebuddyAgent [candidate] (806.589 ms) : 0, 806589
GlobalTracer [baseline] (287.972 ms) : 0, 287972
GlobalTracer [candidate] (292.118 ms) : 0, 292118
AppSec [baseline] (50.633 ms) : 0, 50633
AppSec [candidate] (53.427 ms) : 0, 53427
IAST [baseline] (22.536 ms) : 0, 22536
IAST [candidate] (22.721 ms) : 0, 22721
Remote Config [baseline] (1.324 ms) : 0, 1324
Remote Config [candidate] (654.813 µs) : 0, 655
Telemetry [baseline] (8.129 ms) : 0, 8129
Telemetry [candidate] (6.731 ms) : 0, 6731
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (791.327 ms) : 0, 791327
BytebuddyAgent [candidate] (791.252 ms) : 0, 791252
GlobalTracer [baseline] (288.075 ms) : 0, 288075
GlobalTracer [candidate] (287.919 ms) : 0, 287919
AppSec [baseline] (49.718 ms) : 0, 49718
AppSec [candidate] (48.267 ms) : 0, 48267
IAST [baseline] (22.929 ms) : 0, 22929
IAST [candidate] (26.107 ms) : 0, 26107
Remote Config [baseline] (579.613 µs) : 0, 580
Remote Config [candidate] (585.57 µs) : 0, 586
Telemetry [baseline] (8.959 ms) : 0, 8959
Telemetry [candidate] (7.281 ms) : 0, 7281
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 15 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.34.0-SNAPSHOT~86d12e2222, baseline=1.34.0-SNAPSHOT~d3eae46967
dateFormat X
axisFormat %s
section baseline
no_agent (369.253 µs) : 349, 390
. : milestone, 369,
iast (475.234 µs) : 454, 496
. : milestone, 475,
iast_FULL (542.595 µs) : 522, 564
. : milestone, 543,
iast_GLOBAL (497.843 µs) : 477, 519
. : milestone, 498,
iast_HARDCODED_SECRET_DISABLED (483.512 µs) : 463, 505
. : milestone, 484,
iast_INACTIVE (444.639 µs) : 424, 466
. : milestone, 445,
iast_TELEMETRY_OFF (473.604 µs) : 453, 494
. : milestone, 474,
tracing (440.195 µs) : 420, 460
. : milestone, 440,
section candidate
no_agent (371.675 µs) : 352, 392
. : milestone, 372,
iast (475.015 µs) : 454, 496
. : milestone, 475,
iast_FULL (542.551 µs) : 521, 564
. : milestone, 543,
iast_GLOBAL (502.143 µs) : 481, 524
. : milestone, 502,
iast_HARDCODED_SECRET_DISABLED (476.396 µs) : 455, 498
. : milestone, 476,
iast_INACTIVE (445.019 µs) : 425, 465
. : milestone, 445,
iast_TELEMETRY_OFF (473.285 µs) : 452, 495
. : milestone, 473,
tracing (448.531 µs) : 428, 469
. : milestone, 449,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.34.0-SNAPSHOT~86d12e2222, baseline=1.34.0-SNAPSHOT~d3eae46967
dateFormat X
axisFormat %s
section baseline
no_agent (1.343 ms) : 1324, 1362
. : milestone, 1343,
appsec (1.735 ms) : 1712, 1759
. : milestone, 1735,
appsec_no_iast (1.733 ms) : 1709, 1756
. : milestone, 1733,
iast (1.489 ms) : 1466, 1511
. : milestone, 1489,
profiling (1.527 ms) : 1501, 1553
. : milestone, 1527,
tracing (1.48 ms) : 1456, 1504
. : milestone, 1480,
section candidate
no_agent (1.334 ms) : 1315, 1353
. : milestone, 1334,
appsec (1.744 ms) : 1720, 1767
. : milestone, 1744,
appsec_no_iast (1.734 ms) : 1711, 1758
. : milestone, 1734,
iast (1.476 ms) : 1453, 1499
. : milestone, 1476,
profiling (1.494 ms) : 1468, 1519
. : milestone, 1494,
tracing (1.497 ms) : 1473, 1521
. : milestone, 1497,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.34.0-SNAPSHOT~86d12e2222, baseline=1.34.0-SNAPSHOT~d3eae46967
dateFormat X
axisFormat %s
section baseline
no_agent (1.461 ms) : 1450, 1473
. : milestone, 1461,
appsec (2.192 ms) : 2159, 2226
. : milestone, 2192,
iast (1.887 ms) : 1851, 1922
. : milestone, 1887,
iast_GLOBAL (1.927 ms) : 1891, 1962
. : milestone, 1927,
profiling (1.846 ms) : 1812, 1880
. : milestone, 1846,
tracing (1.844 ms) : 1812, 1876
. : milestone, 1844,
section candidate
no_agent (1.457 ms) : 1446, 1468
. : milestone, 1457,
appsec (2.202 ms) : 2169, 2236
. : milestone, 2202,
iast (1.883 ms) : 1848, 1919
. : milestone, 1883,
iast_GLOBAL (1.921 ms) : 1886, 1956
. : milestone, 1921,
profiling (1.849 ms) : 1816, 1883
. : milestone, 1849,
tracing (1.829 ms) : 1798, 1861
. : milestone, 1829,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.34.0-SNAPSHOT~86d12e2222, baseline=1.34.0-SNAPSHOT~d3eae46967
dateFormat X
axisFormat %s
section baseline
no_agent (14.851 s) : 14851000, 14851000
. : milestone, 14851000,
appsec (14.929 s) : 14929000, 14929000
. : milestone, 14929000,
iast (18.787 s) : 18787000, 18787000
. : milestone, 18787000,
iast_GLOBAL (17.904 s) : 17904000, 17904000
. : milestone, 17904000,
profiling (15.675 s) : 15675000, 15675000
. : milestone, 15675000,
tracing (15.242 s) : 15242000, 15242000
. : milestone, 15242000,
section candidate
no_agent (14.894 s) : 14894000, 14894000
. : milestone, 14894000,
appsec (15.203 s) : 15203000, 15203000
. : milestone, 15203000,
iast (18.999 s) : 18999000, 18999000
. : milestone, 18999000,
iast_GLOBAL (17.859 s) : 17859000, 17859000
. : milestone, 17859000,
profiling (15.245 s) : 15245000, 15245000
. : milestone, 15245000,
tracing (14.953 s) : 14953000, 14953000
. : milestone, 14953000,
|
dougqh
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Processes
sampling.priority
tags as defined by OpenTracing:Motivation
Improves consistency with other tracers that process
sampling.priority
tags.Jira ticket: [PROJ-IDENT]