Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process 'sampling.priority' tags #6971

Merged
merged 1 commit into from
May 1, 2024

Conversation

mcculls
Copy link
Contributor

@mcculls mcculls commented Apr 30, 2024

What Does This Do

Processes sampling.priority tags as defined by OpenTracing:

If greater than 0, a hint to the Tracer to do its best to capture the trace. If 0, a hint to the trace to not-capture the trace. If absent, the Tracer should use its default sampling mechanism.

Motivation

Improves consistency with other tracers that process sampling.priority tags.

Jira ticket: [PROJ-IDENT]

@mcculls mcculls added inst: opentelemetry OpenTelemetry instrumentation comp: opentracing OpenTracing labels Apr 30, 2024
@mcculls mcculls force-pushed the mcculls/process-sampling.priority-tags branch from 05a1b93 to 86d12e2 Compare April 30, 2024 08:48
@pr-commenter
Copy link

pr-commenter bot commented Apr 30, 2024

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/process-sampling.priority-tags
git_commit_date 1714466677 1714466893
git_commit_sha d3eae46 86d12e2
release_version 1.34.0-SNAPSHOT~d3eae46967 1.34.0-SNAPSHOT~86d12e2222
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1714470804 1714470804
ci_job_id 500518265 500518265
ci_pipeline_id 33231333 33231333
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 48 metrics, 15 unstable metrics.

Startup time reports for petclinic
gantt
    title petclinic - global startup overhead: candidate=1.34.0-SNAPSHOT~86d12e2222, baseline=1.34.0-SNAPSHOT~d3eae46967

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.086 s) : 0, 1086136
Total [baseline] (10.405 s) : 0, 10405046
Agent [candidate] (1.077 s) : 0, 1076519
Total [candidate] (10.34 s) : 0, 10340269
section appsec
Agent [baseline] (1.19 s) : 0, 1189770
Total [baseline] (10.528 s) : 0, 10527932
Agent [candidate] (1.189 s) : 0, 1188852
Total [candidate] (10.522 s) : 0, 10522424
section iast
Agent [baseline] (1.2 s) : 0, 1200382
Total [baseline] (10.678 s) : 0, 10678352
Agent [candidate] (1.219 s) : 0, 1218905
Total [candidate] (10.931 s) : 0, 10931104
section profiling
Agent [baseline] (1.269 s) : 0, 1269090
Total [baseline] (10.599 s) : 0, 10599275
Agent [candidate] (1.269 s) : 0, 1268800
Total [candidate] (10.7 s) : 0, 10699806
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.086 s -
Agent appsec 1.19 s 103.634 ms (9.5%)
Agent iast 1.2 s 114.246 ms (10.5%)
Agent profiling 1.269 s 182.954 ms (16.8%)
Total tracing 10.405 s -
Total appsec 10.528 s 122.886 ms (1.2%)
Total iast 10.678 s 273.306 ms (2.6%)
Total profiling 10.599 s 194.228 ms (1.9%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.077 s -
Agent appsec 1.189 s 112.333 ms (10.4%)
Agent iast 1.219 s 142.386 ms (13.2%)
Agent profiling 1.269 s 192.281 ms (17.9%)
Total tracing 10.34 s -
Total appsec 10.522 s 182.155 ms (1.8%)
Total iast 10.931 s 590.835 ms (5.7%)
Total profiling 10.7 s 359.537 ms (3.5%)
gantt
    title petclinic - break down per module: candidate=1.34.0-SNAPSHOT~86d12e2222, baseline=1.34.0-SNAPSHOT~d3eae46967

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (680.348 ms) : 0, 680348
BytebuddyAgent [candidate] (674.236 ms) : 0, 674236
GlobalTracer [baseline] (312.925 ms) : 0, 312925
GlobalTracer [candidate] (310.189 ms) : 0, 310189
AppSec [baseline] (49.879 ms) : 0, 49879
AppSec [candidate] (49.339 ms) : 0, 49339
Remote Config [baseline] (668.49 µs) : 0, 668
Remote Config [candidate] (665.209 µs) : 0, 665
Telemetry [baseline] (7.674 ms) : 0, 7674
Telemetry [candidate] (7.659 ms) : 0, 7659
section appsec
BytebuddyAgent [baseline] (695.475 ms) : 0, 695475
BytebuddyAgent [candidate] (694.999 ms) : 0, 694999
GlobalTracer [baseline] (291.393 ms) : 0, 291393
GlobalTracer [candidate] (291.394 ms) : 0, 291394
AppSec [baseline] (149.44 ms) : 0, 149440
AppSec [candidate] (149.045 ms) : 0, 149045
IAST [baseline] (19.227 ms) : 0, 19227
IAST [candidate] (19.267 ms) : 0, 19267
Remote Config [baseline] (626.606 µs) : 0, 627
Remote Config [candidate] (618.39 µs) : 0, 618
Telemetry [baseline] (8.858 ms) : 0, 8858
Telemetry [candidate] (8.782 ms) : 0, 8782
section iast
BytebuddyAgent [baseline] (794.412 ms) : 0, 794412
BytebuddyAgent [candidate] (807.611 ms) : 0, 807611
GlobalTracer [baseline] (288.423 ms) : 0, 288423
GlobalTracer [candidate] (292.596 ms) : 0, 292596
AppSec [baseline] (50.854 ms) : 0, 50854
AppSec [candidate] (51.997 ms) : 0, 51997
IAST [baseline] (24.4 ms) : 0, 24400
IAST [candidate] (24.361 ms) : 0, 24361
Remote Config [baseline] (568.024 µs) : 0, 568
Remote Config [candidate] (687.804 µs) : 0, 688
Telemetry [baseline] (7.366 ms) : 0, 7366
Telemetry [candidate] (6.71 ms) : 0, 6710
section profiling
BytebuddyAgent [baseline] (678.188 ms) : 0, 678188
BytebuddyAgent [candidate] (677.403 ms) : 0, 677403
GlobalTracer [baseline] (380.411 ms) : 0, 380411
GlobalTracer [candidate] (380.402 ms) : 0, 380402
AppSec [baseline] (50.201 ms) : 0, 50201
AppSec [candidate] (50.376 ms) : 0, 50376
Remote Config [baseline] (703.42 µs) : 0, 703
Remote Config [candidate] (712.912 µs) : 0, 713
Telemetry [baseline] (7.473 ms) : 0, 7473
Telemetry [candidate] (7.463 ms) : 0, 7463
ProfilingAgent [baseline] (95.725 ms) : 0, 95725
ProfilingAgent [candidate] (96.143 ms) : 0, 96143
Profiling [baseline] (95.749 ms) : 0, 95749
Profiling [candidate] (96.167 ms) : 0, 96167
Startup time reports for insecure-bank
gantt
    title insecure-bank - global startup overhead: candidate=1.34.0-SNAPSHOT~86d12e2222, baseline=1.34.0-SNAPSHOT~d3eae46967

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.073 s) : 0, 1073120
Total [baseline] (8.552 s) : 0, 8551879
Agent [candidate] (1.076 s) : 0, 1076015
Total [candidate] (8.542 s) : 0, 8542197
section iast
Agent [baseline] (1.207 s) : 0, 1207114
Total [baseline] (9.012 s) : 0, 9012442
Agent [candidate] (1.208 s) : 0, 1208051
Total [candidate] (9.005 s) : 0, 9005475
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.198 s) : 0, 1198351
Total [baseline] (8.976 s) : 0, 8975879
Agent [candidate] (1.217 s) : 0, 1217058
Total [candidate] (9.051 s) : 0, 9050861
section iast_TELEMETRY_OFF
Agent [baseline] (1.196 s) : 0, 1195976
Total [baseline] (8.992 s) : 0, 8991866
Agent [candidate] (1.196 s) : 0, 1195801
Total [candidate] (8.999 s) : 0, 8999067
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.073 s -
Agent iast 1.207 s 133.993 ms (12.5%)
Agent iast_HARDCODED_SECRET_DISABLED 1.198 s 125.231 ms (11.7%)
Agent iast_TELEMETRY_OFF 1.196 s 122.855 ms (11.4%)
Total tracing 8.552 s -
Total iast 9.012 s 460.563 ms (5.4%)
Total iast_HARDCODED_SECRET_DISABLED 8.976 s 424.0 ms (5.0%)
Total iast_TELEMETRY_OFF 8.992 s 439.987 ms (5.1%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.076 s -
Agent iast 1.208 s 132.036 ms (12.3%)
Agent iast_HARDCODED_SECRET_DISABLED 1.217 s 141.043 ms (13.1%)
Agent iast_TELEMETRY_OFF 1.196 s 119.786 ms (11.1%)
Total tracing 8.542 s -
Total iast 9.005 s 463.278 ms (5.4%)
Total iast_HARDCODED_SECRET_DISABLED 9.051 s 508.664 ms (6.0%)
Total iast_TELEMETRY_OFF 8.999 s 456.87 ms (5.3%)
gantt
    title insecure-bank - break down per module: candidate=1.34.0-SNAPSHOT~86d12e2222, baseline=1.34.0-SNAPSHOT~d3eae46967

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (672.404 ms) : 0, 672404
BytebuddyAgent [candidate] (673.831 ms) : 0, 673831
GlobalTracer [baseline] (308.774 ms) : 0, 308774
GlobalTracer [candidate] (310.272 ms) : 0, 310272
AppSec [baseline] (49.394 ms) : 0, 49394
AppSec [candidate] (49.37 ms) : 0, 49370
Remote Config [baseline] (661.285 µs) : 0, 661
Remote Config [candidate] (654.335 µs) : 0, 654
Telemetry [baseline] (7.638 ms) : 0, 7638
Telemetry [candidate] (7.554 ms) : 0, 7554
section iast
BytebuddyAgent [baseline] (799.853 ms) : 0, 799853
BytebuddyAgent [candidate] (800.385 ms) : 0, 800385
GlobalTracer [baseline] (289.646 ms) : 0, 289646
GlobalTracer [candidate] (290.143 ms) : 0, 290143
AppSec [baseline] (51.41 ms) : 0, 51410
AppSec [candidate] (50.475 ms) : 0, 50475
IAST [baseline] (24.309 ms) : 0, 24309
IAST [candidate] (25.22 ms) : 0, 25220
Remote Config [baseline] (665.762 µs) : 0, 666
Remote Config [candidate] (581.197 µs) : 0, 581
Telemetry [baseline] (6.66 ms) : 0, 6660
Telemetry [candidate] (6.68 ms) : 0, 6680
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (793.389 ms) : 0, 793389
BytebuddyAgent [candidate] (806.589 ms) : 0, 806589
GlobalTracer [baseline] (287.972 ms) : 0, 287972
GlobalTracer [candidate] (292.118 ms) : 0, 292118
AppSec [baseline] (50.633 ms) : 0, 50633
AppSec [candidate] (53.427 ms) : 0, 53427
IAST [baseline] (22.536 ms) : 0, 22536
IAST [candidate] (22.721 ms) : 0, 22721
Remote Config [baseline] (1.324 ms) : 0, 1324
Remote Config [candidate] (654.813 µs) : 0, 655
Telemetry [baseline] (8.129 ms) : 0, 8129
Telemetry [candidate] (6.731 ms) : 0, 6731
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (791.327 ms) : 0, 791327
BytebuddyAgent [candidate] (791.252 ms) : 0, 791252
GlobalTracer [baseline] (288.075 ms) : 0, 288075
GlobalTracer [candidate] (287.919 ms) : 0, 287919
AppSec [baseline] (49.718 ms) : 0, 49718
AppSec [candidate] (48.267 ms) : 0, 48267
IAST [baseline] (22.929 ms) : 0, 22929
IAST [candidate] (26.107 ms) : 0, 26107
Remote Config [baseline] (579.613 µs) : 0, 580
Remote Config [candidate] (585.57 µs) : 0, 586
Telemetry [baseline] (8.959 ms) : 0, 8959
Telemetry [candidate] (7.281 ms) : 0, 7281

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-04-30T09:26:02 2024-04-30T09:32:52
git_branch master mcculls/process-sampling.priority-tags
git_commit_date 1714466677 1714466893
git_commit_sha d3eae46 86d12e2
release_version 1.34.0-SNAPSHOT~d3eae46967 1.34.0-SNAPSHOT~86d12e2222
start_time 2024-04-30T09:25:49 2024-04-30T09:32:39
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1714469916 1714469916
ci_job_id 500518266 500518266
ci_pipeline_id 33231333 33231333
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 15 unstable metrics.

Request duration reports for insecure-bank
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.34.0-SNAPSHOT~86d12e2222, baseline=1.34.0-SNAPSHOT~d3eae46967
    dateFormat X
    axisFormat %s
section baseline
no_agent (369.253 µs) : 349, 390
.   : milestone, 369,
iast (475.234 µs) : 454, 496
.   : milestone, 475,
iast_FULL (542.595 µs) : 522, 564
.   : milestone, 543,
iast_GLOBAL (497.843 µs) : 477, 519
.   : milestone, 498,
iast_HARDCODED_SECRET_DISABLED (483.512 µs) : 463, 505
.   : milestone, 484,
iast_INACTIVE (444.639 µs) : 424, 466
.   : milestone, 445,
iast_TELEMETRY_OFF (473.604 µs) : 453, 494
.   : milestone, 474,
tracing (440.195 µs) : 420, 460
.   : milestone, 440,
section candidate
no_agent (371.675 µs) : 352, 392
.   : milestone, 372,
iast (475.015 µs) : 454, 496
.   : milestone, 475,
iast_FULL (542.551 µs) : 521, 564
.   : milestone, 543,
iast_GLOBAL (502.143 µs) : 481, 524
.   : milestone, 502,
iast_HARDCODED_SECRET_DISABLED (476.396 µs) : 455, 498
.   : milestone, 476,
iast_INACTIVE (445.019 µs) : 425, 465
.   : milestone, 445,
iast_TELEMETRY_OFF (473.285 µs) : 452, 495
.   : milestone, 473,
tracing (448.531 µs) : 428, 469
.   : milestone, 449,
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 369.253 µs [348.708 µs, 389.798 µs] -
iast 475.234 µs [454.119 µs, 496.348 µs] 105.981 µs (28.7%)
iast_FULL 542.595 µs [521.674 µs, 563.517 µs] 173.342 µs (46.9%)
iast_GLOBAL 497.843 µs [476.528 µs, 519.158 µs] 128.59 µs (34.8%)
iast_HARDCODED_SECRET_DISABLED 483.512 µs [462.523 µs, 504.502 µs] 114.259 µs (30.9%)
iast_INACTIVE 444.639 µs [423.622 µs, 465.656 µs] 75.386 µs (20.4%)
iast_TELEMETRY_OFF 473.604 µs [452.839 µs, 494.368 µs] 104.35 µs (28.3%)
tracing 440.195 µs [420.07 µs, 460.32 µs] 70.942 µs (19.2%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 371.675 µs [351.595 µs, 391.755 µs] -
iast 475.015 µs [454.147 µs, 495.884 µs] 103.34 µs (27.8%)
iast_FULL 542.551 µs [520.744 µs, 564.357 µs] 170.876 µs (46.0%)
iast_GLOBAL 502.143 µs [480.606 µs, 523.681 µs] 130.468 µs (35.1%)
iast_HARDCODED_SECRET_DISABLED 476.396 µs [454.781 µs, 498.01 µs] 104.72 µs (28.2%)
iast_INACTIVE 445.019 µs [424.73 µs, 465.307 µs] 73.344 µs (19.7%)
iast_TELEMETRY_OFF 473.285 µs [451.917 µs, 494.654 µs] 101.61 µs (27.3%)
tracing 448.531 µs [427.996 µs, 469.066 µs] 76.856 µs (20.7%)
Request duration reports for petclinic
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.34.0-SNAPSHOT~86d12e2222, baseline=1.34.0-SNAPSHOT~d3eae46967
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.343 ms) : 1324, 1362
.   : milestone, 1343,
appsec (1.735 ms) : 1712, 1759
.   : milestone, 1735,
appsec_no_iast (1.733 ms) : 1709, 1756
.   : milestone, 1733,
iast (1.489 ms) : 1466, 1511
.   : milestone, 1489,
profiling (1.527 ms) : 1501, 1553
.   : milestone, 1527,
tracing (1.48 ms) : 1456, 1504
.   : milestone, 1480,
section candidate
no_agent (1.334 ms) : 1315, 1353
.   : milestone, 1334,
appsec (1.744 ms) : 1720, 1767
.   : milestone, 1744,
appsec_no_iast (1.734 ms) : 1711, 1758
.   : milestone, 1734,
iast (1.476 ms) : 1453, 1499
.   : milestone, 1476,
profiling (1.494 ms) : 1468, 1519
.   : milestone, 1494,
tracing (1.497 ms) : 1473, 1521
.   : milestone, 1497,
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.343 ms [1.324 ms, 1.362 ms] -
appsec 1.735 ms [1.712 ms, 1.759 ms] 392.492 µs (29.2%)
appsec_no_iast 1.733 ms [1.709 ms, 1.756 ms] 389.993 µs (29.0%)
iast 1.489 ms [1.466 ms, 1.511 ms] 145.896 µs (10.9%)
profiling 1.527 ms [1.501 ms, 1.553 ms] 184.588 µs (13.7%)
tracing 1.48 ms [1.456 ms, 1.504 ms] 137.088 µs (10.2%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.334 ms [1.315 ms, 1.353 ms] -
appsec 1.744 ms [1.72 ms, 1.767 ms] 409.834 µs (30.7%)
appsec_no_iast 1.734 ms [1.711 ms, 1.758 ms] 400.455 µs (30.0%)
iast 1.476 ms [1.453 ms, 1.499 ms] 142.1 µs (10.7%)
profiling 1.494 ms [1.468 ms, 1.519 ms] 159.652 µs (12.0%)
tracing 1.497 ms [1.473 ms, 1.521 ms] 162.91 µs (12.2%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/process-sampling.priority-tags
git_commit_date 1714466677 1714466893
git_commit_sha d3eae46 86d12e2
release_version 1.34.0-SNAPSHOT~d3eae46967 1.34.0-SNAPSHOT~86d12e2222
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1714470431 1714470431
ci_job_id 500518267 500518267
ci_pipeline_id 33231333 33231333
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.34.0-SNAPSHOT~86d12e2222, baseline=1.34.0-SNAPSHOT~d3eae46967
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.461 ms) : 1450, 1473
.   : milestone, 1461,
appsec (2.192 ms) : 2159, 2226
.   : milestone, 2192,
iast (1.887 ms) : 1851, 1922
.   : milestone, 1887,
iast_GLOBAL (1.927 ms) : 1891, 1962
.   : milestone, 1927,
profiling (1.846 ms) : 1812, 1880
.   : milestone, 1846,
tracing (1.844 ms) : 1812, 1876
.   : milestone, 1844,
section candidate
no_agent (1.457 ms) : 1446, 1468
.   : milestone, 1457,
appsec (2.202 ms) : 2169, 2236
.   : milestone, 2202,
iast (1.883 ms) : 1848, 1919
.   : milestone, 1883,
iast_GLOBAL (1.921 ms) : 1886, 1956
.   : milestone, 1921,
profiling (1.849 ms) : 1816, 1883
.   : milestone, 1849,
tracing (1.829 ms) : 1798, 1861
.   : milestone, 1829,
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.461 ms [1.45 ms, 1.473 ms] -
appsec 2.192 ms [2.159 ms, 2.226 ms] 731.21 µs (50.0%)
iast 1.887 ms [1.851 ms, 1.922 ms] 425.427 µs (29.1%)
iast_GLOBAL 1.927 ms [1.891 ms, 1.962 ms] 465.573 µs (31.9%)
profiling 1.846 ms [1.812 ms, 1.88 ms] 384.51 µs (26.3%)
tracing 1.844 ms [1.812 ms, 1.876 ms] 382.71 µs (26.2%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.457 ms [1.446 ms, 1.468 ms] -
appsec 2.202 ms [2.169 ms, 2.236 ms] 745.278 µs (51.1%)
iast 1.883 ms [1.848 ms, 1.919 ms] 425.954 µs (29.2%)
iast_GLOBAL 1.921 ms [1.886 ms, 1.956 ms] 464.048 µs (31.8%)
profiling 1.849 ms [1.816 ms, 1.883 ms] 392.394 µs (26.9%)
tracing 1.829 ms [1.798 ms, 1.861 ms] 372.051 µs (25.5%)
Execution time for biojava
gantt
    title biojava - execution time [CI 0.99] : candidate=1.34.0-SNAPSHOT~86d12e2222, baseline=1.34.0-SNAPSHOT~d3eae46967
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.851 s) : 14851000, 14851000
.   : milestone, 14851000,
appsec (14.929 s) : 14929000, 14929000
.   : milestone, 14929000,
iast (18.787 s) : 18787000, 18787000
.   : milestone, 18787000,
iast_GLOBAL (17.904 s) : 17904000, 17904000
.   : milestone, 17904000,
profiling (15.675 s) : 15675000, 15675000
.   : milestone, 15675000,
tracing (15.242 s) : 15242000, 15242000
.   : milestone, 15242000,
section candidate
no_agent (14.894 s) : 14894000, 14894000
.   : milestone, 14894000,
appsec (15.203 s) : 15203000, 15203000
.   : milestone, 15203000,
iast (18.999 s) : 18999000, 18999000
.   : milestone, 18999000,
iast_GLOBAL (17.859 s) : 17859000, 17859000
.   : milestone, 17859000,
profiling (15.245 s) : 15245000, 15245000
.   : milestone, 15245000,
tracing (14.953 s) : 14953000, 14953000
.   : milestone, 14953000,
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.851 s [14.851 s, 14.851 s] -
appsec 14.929 s [14.929 s, 14.929 s] 78.0 ms (0.5%)
iast 18.787 s [18.787 s, 18.787 s] 3.936 s (26.5%)
iast_GLOBAL 17.904 s [17.904 s, 17.904 s] 3.053 s (20.6%)
profiling 15.675 s [15.675 s, 15.675 s] 824.0 ms (5.5%)
tracing 15.242 s [15.242 s, 15.242 s] 391.0 ms (2.6%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.894 s [14.894 s, 14.894 s] -
appsec 15.203 s [15.203 s, 15.203 s] 309.0 ms (2.1%)
iast 18.999 s [18.999 s, 18.999 s] 4.105 s (27.6%)
iast_GLOBAL 17.859 s [17.859 s, 17.859 s] 2.965 s (19.9%)
profiling 15.245 s [15.245 s, 15.245 s] 351.0 ms (2.4%)
tracing 14.953 s [14.953 s, 14.953 s] 59.0 ms (0.4%)

@mcculls mcculls marked this pull request as ready for review April 30, 2024 09:42
@mcculls mcculls requested a review from a team as a code owner April 30, 2024 09:42
@mcculls mcculls merged commit 0ffbbce into master May 1, 2024
80 checks passed
@mcculls mcculls deleted the mcculls/process-sampling.priority-tags branch May 1, 2024 15:20
@github-actions github-actions bot added this to the 1.34.0 milestone May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp: opentracing OpenTracing inst: opentelemetry OpenTelemetry instrumentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants