Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add coordinated sampling for Exception Debugging #6974

Merged
merged 1 commit into from
May 6, 2024
Merged

Add coordinated sampling for Exception Debugging #6974

merged 1 commit into from
May 6, 2024

Conversation

jpbempel
Copy link
Member

@jpbempel jpbempel commented Apr 30, 2024 •
edited by jira bot
Loading

What Does This Do

if the first stack level generates a snapshot after sampling
we keep continuing to generate snapshot for next levels by forcing
sampling (not calling the sampler).
For each evaluation of exception probe we query the state by throwable
instance and based on this state (list of snapshots) we take the
decision keep sampling or drop)

Motivation

Having complete stacks with all snpashots without depending on the sampling for each stack level

Additional Notes

Jira ticket: DEBUG-2068

@jpbempel jpbempel added the comp: debugger Dynamic Instrumentation label Apr 30, 2024
@jpbempel jpbempel requested a review from a team as a code owner April 30, 2024 11:58
@jpbempel jpbempel requested review from ojung and removed request for a team April 30, 2024 11:58
@jpbempel
Add coordinated sampling for Exception Debugging
dabdaa7 
if the first stack level generates a snapshot after sampling
 we keep continuing to generate snapshot for next levels by forcing
sampling (not calling the sampler).
For each evaluation of exception probe we query the state by throwable
 instance and based on this state (list of snapshots) we take the
decision keep sampling or drop)
@jpbempel jpbempel force-pushed the jpbempel/exception-sampling-sync branch from 0604e84 to dabdaa7 Compare April 30, 2024 12:00
@pr-commenter
Copy link

pr-commenter bot commented Apr 30, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jpbempel/exception-sampling-sync
git_commit_date 1714472597 1714478435
git_commit_sha 2b0502c dabdaa7
release_version 1.34.0-SNAPSHOT~2b0502cacf 1.34.0-SNAPSHOT~dabdaa736a
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1714481003 1714481003
ci_job_id 500692058 500692058
ci_pipeline_id 33243131 33243131
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 50 metrics, 13 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.34.0-SNAPSHOT~dabdaa736a, baseline=1.34.0-SNAPSHOT~2b0502cacf

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.076 s) : 0, 1075828
Total [baseline] (8.564 s) : 0, 8563800
Agent [candidate] (1.076 s) : 0, 1076363
Total [candidate] (8.548 s) : 0, 8548402
section iast
Agent [baseline] (1.2 s) : 0, 1200159
Total [baseline] (9.025 s) : 0, 9024803
Agent [candidate] (1.206 s) : 0, 1205618
Total [candidate] (9.047 s) : 0, 9046847
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.199 s) : 0, 1198614
Total [baseline] (8.972 s) : 0, 8972106
Agent [candidate] (1.198 s) : 0, 1198371
Total [candidate] (8.943 s) : 0, 8943214
section iast_TELEMETRY_OFF
Agent [baseline] (1.204 s) : 0, 1203690
Total [baseline] (9.032 s) : 0, 9032387
Agent [candidate] (1.196 s) : 0, 1196436
Total [candidate] (8.996 s) : 0, 8995909
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.076 s -
Agent iast 1.2 s 124.33 ms (11.6%)
Agent iast_HARDCODED_SECRET_DISABLED 1.199 s 122.786 ms (11.4%)
Agent iast_TELEMETRY_OFF 1.204 s 127.861 ms (11.9%)
Total tracing 8.564 s -
Total iast 9.025 s 461.002 ms (5.4%)
Total iast_HARDCODED_SECRET_DISABLED 8.972 s 408.306 ms (4.8%)
Total iast_TELEMETRY_OFF 9.032 s 468.587 ms (5.5%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.076 s -
Agent iast 1.206 s 129.255 ms (12.0%)
Agent iast_HARDCODED_SECRET_DISABLED 1.198 s 122.008 ms (11.3%)
Agent iast_TELEMETRY_OFF 1.196 s 120.073 ms (11.2%)
Total tracing 8.548 s -
Total iast 9.047 s 498.445 ms (5.8%)
Total iast_HARDCODED_SECRET_DISABLED 8.943 s 394.812 ms (4.6%)
Total iast_TELEMETRY_OFF 8.996 s 447.508 ms (5.2%) 
gantt
    title insecure-bank - break down per module: candidate=1.34.0-SNAPSHOT~dabdaa736a, baseline=1.34.0-SNAPSHOT~2b0502cacf

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (673.897 ms) : 0, 673897
BytebuddyAgent [candidate] (674.643 ms) : 0, 674643
GlobalTracer [baseline] (309.808 ms) : 0, 309808
GlobalTracer [candidate] (309.585 ms) : 0, 309585
AppSec [baseline] (49.539 ms) : 0, 49539
AppSec [candidate] (49.545 ms) : 0, 49545
Remote Config [baseline] (661.092 µs) : 0, 661
Remote Config [candidate] (662.84 µs) : 0, 663
Telemetry [baseline] (7.557 ms) : 0, 7557
Telemetry [candidate] (7.623 ms) : 0, 7623
section iast
BytebuddyAgent [baseline] (794.652 ms) : 0, 794652
BytebuddyAgent [candidate] (798.997 ms) : 0, 798997
GlobalTracer [baseline] (288.417 ms) : 0, 288417
GlobalTracer [candidate] (289.363 ms) : 0, 289363
AppSec [baseline] (49.035 ms) : 0, 49035
AppSec [candidate] (51.268 ms) : 0, 51268
IAST [baseline] (26.481 ms) : 0, 26481
IAST [candidate] (23.506 ms) : 0, 23506
Remote Config [baseline] (596.655 µs) : 0, 597
Remote Config [candidate] (1.259 ms) : 0, 1259
Telemetry [baseline] (6.665 ms) : 0, 6665
Telemetry [candidate] (6.666 ms) : 0, 6666
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (793.692 ms) : 0, 793692
BytebuddyAgent [candidate] (793.646 ms) : 0, 793646
GlobalTracer [baseline] (288.086 ms) : 0, 288086
GlobalTracer [candidate] (287.652 ms) : 0, 287652
AppSec [baseline] (52.191 ms) : 0, 52191
AppSec [candidate] (51.37 ms) : 0, 51370
IAST [baseline] (23.163 ms) : 0, 23163
IAST [candidate] (24.121 ms) : 0, 24121
Remote Config [baseline] (562.821 µs) : 0, 563
Remote Config [candidate] (643.992 µs) : 0, 644
Telemetry [baseline] (6.633 ms) : 0, 6633
Telemetry [candidate] (6.594 ms) : 0, 6594
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (796.518 ms) : 0, 796518
BytebuddyAgent [candidate] (792.083 ms) : 0, 792083
GlobalTracer [baseline] (290.047 ms) : 0, 290047
GlobalTracer [candidate] (287.944 ms) : 0, 287944
AppSec [baseline] (51.464 ms) : 0, 51464
AppSec [candidate] (49.751 ms) : 0, 49751
IAST [baseline] (23.096 ms) : 0, 23096
IAST [candidate] (23.661 ms) : 0, 23661
Remote Config [baseline] (581.244 µs) : 0, 581
Remote Config [candidate] (574.561 µs) : 0, 575
Telemetry [baseline] (7.363 ms) : 0, 7363
Telemetry [candidate] (7.287 ms) : 0, 7287
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.34.0-SNAPSHOT~dabdaa736a, baseline=1.34.0-SNAPSHOT~2b0502cacf

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.078 s) : 0, 1077759
Total [baseline] (10.377 s) : 0, 10376735
Agent [candidate] (1.081 s) : 0, 1080889
Total [candidate] (10.428 s) : 0, 10428324
section appsec
Agent [baseline] (1.193 s) : 0, 1192803
Total [baseline] (10.469 s) : 0, 10468826
Agent [candidate] (1.188 s) : 0, 1188411
Total [candidate] (10.436 s) : 0, 10435859
section iast
Agent [baseline] (1.2 s) : 0, 1199543
Total [baseline] (10.75 s) : 0, 10750473
Agent [candidate] (1.198 s) : 0, 1197760
Total [candidate] (10.739 s) : 0, 10738623
section profiling
Agent [baseline] (1.274 s) : 0, 1274464
Total [baseline] (10.593 s) : 0, 10592724
Agent [candidate] (1.268 s) : 0, 1268306
Total [candidate] (10.606 s) : 0, 10606028
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.078 s -
Agent appsec 1.193 s 115.043 ms (10.7%)
Agent iast 1.2 s 121.783 ms (11.3%)
Agent profiling 1.274 s 196.704 ms (18.3%)
Total tracing 10.377 s -
Total appsec 10.469 s 92.091 ms (0.9%)
Total iast 10.75 s 373.737 ms (3.6%)
Total profiling 10.593 s 215.988 ms (2.1%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.081 s -
Agent appsec 1.188 s 107.522 ms (9.9%)
Agent iast 1.198 s 116.871 ms (10.8%)
Agent profiling 1.268 s 187.417 ms (17.3%)
Total tracing 10.428 s -
Total appsec 10.436 s 7.535 ms (0.1%)
Total iast 10.739 s 310.299 ms (3.0%)
Total profiling 10.606 s 177.704 ms (1.7%) 
gantt
    title petclinic - break down per module: candidate=1.34.0-SNAPSHOT~dabdaa736a, baseline=1.34.0-SNAPSHOT~2b0502cacf

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (674.936 ms) : 0, 674936
BytebuddyAgent [candidate] (678.558 ms) : 0, 678558
GlobalTracer [baseline] (310.401 ms) : 0, 310401
GlobalTracer [candidate] (309.914 ms) : 0, 309914
AppSec [baseline] (49.741 ms) : 0, 49741
AppSec [candidate] (49.49 ms) : 0, 49490
Remote Config [baseline] (656.365 µs) : 0, 656
Remote Config [candidate] (664.212 µs) : 0, 664
Telemetry [baseline] (7.589 ms) : 0, 7589
Telemetry [candidate] (7.628 ms) : 0, 7628
section appsec
BytebuddyAgent [baseline] (697.2 ms) : 0, 697200
BytebuddyAgent [candidate] (695.137 ms) : 0, 695137
GlobalTracer [baseline] (292.434 ms) : 0, 292434
GlobalTracer [candidate] (291.203 ms) : 0, 291203
AppSec [baseline] (149.674 ms) : 0, 149674
AppSec [candidate] (149.062 ms) : 0, 149062
Remote Config [baseline] (622.3 µs) : 0, 622
Remote Config [candidate] (615.593 µs) : 0, 616
Telemetry [baseline] (8.785 ms) : 0, 8785
Telemetry [candidate] (8.492 ms) : 0, 8492
IAST [baseline] (19.358 ms) : 0, 19358
IAST [candidate] (19.19 ms) : 0, 19190
section iast
BytebuddyAgent [baseline] (795.24 ms) : 0, 795240
BytebuddyAgent [candidate] (792.958 ms) : 0, 792958
GlobalTracer [baseline] (288.329 ms) : 0, 288329
GlobalTracer [candidate] (287.942 ms) : 0, 287942
AppSec [baseline] (50.697 ms) : 0, 50697
AppSec [candidate] (50.946 ms) : 0, 50946
Remote Config [baseline] (2.188 ms) : 0, 2188
Remote Config [candidate] (578.632 µs) : 0, 579
Telemetry [baseline] (6.711 ms) : 0, 6711
Telemetry [candidate] (6.717 ms) : 0, 6717
IAST [baseline] (22.011 ms) : 0, 22011
IAST [candidate] (24.356 ms) : 0, 24356
section profiling
BytebuddyAgent [baseline] (681.326 ms) : 0, 681326
BytebuddyAgent [candidate] (677.751 ms) : 0, 677751
GlobalTracer [baseline] (381.661 ms) : 0, 381661
GlobalTracer [candidate] (380.382 ms) : 0, 380382
AppSec [baseline] (50.148 ms) : 0, 50148
AppSec [candidate] (50.223 ms) : 0, 50223
Remote Config [baseline] (721.265 µs) : 0, 721
Remote Config [candidate] (716.034 µs) : 0, 716
Telemetry [baseline] (7.569 ms) : 0, 7569
Telemetry [candidate] (7.509 ms) : 0, 7509
ProfilingAgent [baseline] (96.282 ms) : 0, 96282
ProfilingAgent [candidate] (95.414 ms) : 0, 95414
Profiling [baseline] (96.306 ms) : 0, 96306
Profiling [candidate] (95.438 ms) : 0, 95438
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-04-30T12:16:20 2024-04-30T12:23:09
git_branch master jpbempel/exception-sampling-sync
git_commit_date 1714472597 1714478435
git_commit_sha 2b0502c dabdaa7
release_version 1.34.0-SNAPSHOT~2b0502cacf 1.34.0-SNAPSHOT~dabdaa736a
start_time 2024-04-30T12:16:07 2024-04-30T12:22:56
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1714480132 1714480132
ci_job_id 500692059 500692059
ci_pipeline_id 33243131 33243131
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 15 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.34.0-SNAPSHOT~dabdaa736a, baseline=1.34.0-SNAPSHOT~2b0502cacf
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.344 ms) : 1323, 1364
.   : milestone, 1344,
appsec (1.706 ms) : 1682, 1731
.   : milestone, 1706,
appsec_no_iast (1.725 ms) : 1700, 1751
.   : milestone, 1725,
iast (1.482 ms) : 1459, 1505
.   : milestone, 1482,
profiling (1.517 ms) : 1491, 1543
.   : milestone, 1517,
tracing (1.479 ms) : 1454, 1504
.   : milestone, 1479,
section candidate
no_agent (1.346 ms) : 1326, 1365
.   : milestone, 1346,
appsec (1.717 ms) : 1693, 1742
.   : milestone, 1717,
appsec_no_iast (1.728 ms) : 1702, 1753
.   : milestone, 1728,
iast (1.489 ms) : 1466, 1512
.   : milestone, 1489,
profiling (1.48 ms) : 1455, 1504
.   : milestone, 1480,
tracing (1.494 ms) : 1470, 1517
.   : milestone, 1494,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.344 ms [1.323 ms, 1.364 ms] -
appsec 1.706 ms [1.682 ms, 1.731 ms] 362.478 µs (27.0%)
appsec_no_iast 1.725 ms [1.7 ms, 1.751 ms] 381.444 µs (28.4%)
iast 1.482 ms [1.459 ms, 1.505 ms] 138.403 µs (10.3%)
profiling 1.517 ms [1.491 ms, 1.543 ms] 173.267 µs (12.9%)
tracing 1.479 ms [1.454 ms, 1.504 ms] 134.993 µs (10.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.346 ms [1.326 ms, 1.365 ms] -
appsec 1.717 ms [1.693 ms, 1.742 ms] 371.682 µs (27.6%)
appsec_no_iast 1.728 ms [1.702 ms, 1.753 ms] 381.907 µs (28.4%)
iast 1.489 ms [1.466 ms, 1.512 ms] 143.187 µs (10.6%)
profiling 1.48 ms [1.455 ms, 1.504 ms] 133.902 µs (10.0%)
tracing 1.494 ms [1.47 ms, 1.517 ms] 147.885 µs (11.0%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.34.0-SNAPSHOT~dabdaa736a, baseline=1.34.0-SNAPSHOT~2b0502cacf
    dateFormat X
    axisFormat %s
section baseline
no_agent (369.514 µs) : 350, 389
.   : milestone, 370,
iast (478.186 µs) : 458, 499
.   : milestone, 478,
iast_FULL (549.424 µs) : 529, 570
.   : milestone, 549,
iast_GLOBAL (507.841 µs) : 485, 530
.   : milestone, 508,
iast_HARDCODED_SECRET_DISABLED (479.972 µs) : 458, 502
.   : milestone, 480,
iast_INACTIVE (455.187 µs) : 434, 476
.   : milestone, 455,
iast_TELEMETRY_OFF (469.365 µs) : 448, 490
.   : milestone, 469,
tracing (448.51 µs) : 428, 469
.   : milestone, 449,
section candidate
no_agent (370.897 µs) : 351, 390
.   : milestone, 371,
iast (468.247 µs) : 448, 489
.   : milestone, 468,
iast_FULL (537.602 µs) : 516, 559
.   : milestone, 538,
iast_GLOBAL (497.264 µs) : 477, 518
.   : milestone, 497,
iast_HARDCODED_SECRET_DISABLED (474.365 µs) : 453, 496
.   : milestone, 474,
iast_INACTIVE (449.274 µs) : 428, 470
.   : milestone, 449,
iast_TELEMETRY_OFF (469.847 µs) : 449, 491
.   : milestone, 470,
tracing (447.046 µs) : 427, 468
.   : milestone, 447,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 369.514 µs [349.654 µs, 389.373 µs] -
iast 478.186 µs [457.824 µs, 498.549 µs] 108.673 µs (29.4%)
iast_FULL 549.424 µs [528.692 µs, 570.156 µs] 179.91 µs (48.7%)
iast_GLOBAL 507.841 µs [485.247 µs, 530.434 µs] 138.327 µs (37.4%)
iast_HARDCODED_SECRET_DISABLED 479.972 µs [458.049 µs, 501.895 µs] 110.459 µs (29.9%)
iast_INACTIVE 455.187 µs [434.337 µs, 476.037 µs] 85.673 µs (23.2%)
iast_TELEMETRY_OFF 469.365 µs [448.248 µs, 490.483 µs] 99.852 µs (27.0%)
tracing 448.51 µs [427.679 µs, 469.342 µs] 78.997 µs (21.4%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 370.897 µs [351.463 µs, 390.331 µs] -
iast 468.247 µs [447.917 µs, 488.577 µs] 97.35 µs (26.2%)
iast_FULL 537.602 µs [516.426 µs, 558.779 µs] 166.706 µs (44.9%)
iast_GLOBAL 497.264 µs [476.637 µs, 517.892 µs] 126.367 µs (34.1%)
iast_HARDCODED_SECRET_DISABLED 474.365 µs [452.69 µs, 496.04 µs] 103.468 µs (27.9%)
iast_INACTIVE 449.274 µs [428.132 µs, 470.416 µs] 78.377 µs (21.1%)
iast_TELEMETRY_OFF 469.847 µs [448.956 µs, 490.738 µs] 98.95 µs (26.7%)
tracing 447.046 µs [426.543 µs, 467.548 µs] 76.149 µs (20.5%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jpbempel/exception-sampling-sync
git_commit_date 1714472597 1714478435
git_commit_sha 2b0502c dabdaa7
release_version 1.34.0-SNAPSHOT~2b0502cacf 1.34.0-SNAPSHOT~dabdaa736a
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1714480647 1714480647
ci_job_id 500692060 500692060
ci_pipeline_id 33243131 33243131
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.34.0-SNAPSHOT~dabdaa736a, baseline=1.34.0-SNAPSHOT~2b0502cacf
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.389 s) : 15389000, 15389000
.   : milestone, 15389000,
appsec (15.13 s) : 15130000, 15130000
.   : milestone, 15130000,
iast (18.849 s) : 18849000, 18849000
.   : milestone, 18849000,
iast_GLOBAL (17.897 s) : 17897000, 17897000
.   : milestone, 17897000,
profiling (15.284 s) : 15284000, 15284000
.   : milestone, 15284000,
tracing (14.848 s) : 14848000, 14848000
.   : milestone, 14848000,
section candidate
no_agent (15.136 s) : 15136000, 15136000
.   : milestone, 15136000,
appsec (15.004 s) : 15004000, 15004000
.   : milestone, 15004000,
iast (18.985 s) : 18985000, 18985000
.   : milestone, 18985000,
iast_GLOBAL (17.808 s) : 17808000, 17808000
.   : milestone, 17808000,
profiling (15.044 s) : 15044000, 15044000
.   : milestone, 15044000,
tracing (15.109 s) : 15109000, 15109000
.   : milestone, 15109000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.389 s [15.389 s, 15.389 s] -
appsec 15.13 s [15.13 s, 15.13 s] -259.0 ms (-1.7%)
iast 18.849 s [18.849 s, 18.849 s] 3.46 s (22.5%)
iast_GLOBAL 17.897 s [17.897 s, 17.897 s] 2.508 s (16.3%)
profiling 15.284 s [15.284 s, 15.284 s] -105.0 ms (-0.7%)
tracing 14.848 s [14.848 s, 14.848 s] -541.0 ms (-3.5%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.136 s [15.136 s, 15.136 s] -
appsec 15.004 s [15.004 s, 15.004 s] -132.0 ms (-0.9%)
iast 18.985 s [18.985 s, 18.985 s] 3.849 s (25.4%)
iast_GLOBAL 17.808 s [17.808 s, 17.808 s] 2.672 s (17.7%)
profiling 15.044 s [15.044 s, 15.044 s] -92.0 ms (-0.6%)
tracing 15.109 s [15.109 s, 15.109 s] -27.0 ms (-0.2%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.34.0-SNAPSHOT~dabdaa736a, baseline=1.34.0-SNAPSHOT~2b0502cacf
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.456 ms) : 1444, 1467
.   : milestone, 1456,
appsec (2.182 ms) : 2148, 2216
.   : milestone, 2182,
iast (1.865 ms) : 1831, 1900
.   : milestone, 1865,
iast_GLOBAL (1.914 ms) : 1879, 1950
.   : milestone, 1914,
profiling (1.84 ms) : 1806, 1874
.   : milestone, 1840,
tracing (1.821 ms) : 1789, 1853
.   : milestone, 1821,
section candidate
no_agent (1.455 ms) : 1444, 1466
.   : milestone, 1455,
appsec (2.192 ms) : 2158, 2226
.   : milestone, 2192,
iast (1.878 ms) : 1842, 1913
.   : milestone, 1878,
iast_GLOBAL (1.916 ms) : 1880, 1952
.   : milestone, 1916,
profiling (1.822 ms) : 1789, 1856
.   : milestone, 1822,
tracing (1.825 ms) : 1793, 1857
.   : milestone, 1825,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.456 ms [1.444 ms, 1.467 ms] -
appsec 2.182 ms [2.148 ms, 2.216 ms] 726.727 µs (49.9%)
iast 1.865 ms [1.831 ms, 1.9 ms] 409.835 µs (28.2%)
iast_GLOBAL 1.914 ms [1.879 ms, 1.95 ms] 458.688 µs (31.5%)
profiling 1.84 ms [1.806 ms, 1.874 ms] 384.806 µs (26.4%)
tracing 1.821 ms [1.789 ms, 1.853 ms] 365.518 µs (25.1%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.455 ms [1.444 ms, 1.466 ms] -
appsec 2.192 ms [2.158 ms, 2.226 ms] 736.854 µs (50.6%)
iast 1.878 ms [1.842 ms, 1.913 ms] 422.842 µs (29.1%)
iast_GLOBAL 1.916 ms [1.88 ms, 1.952 ms] 460.989 µs (31.7%)
profiling 1.822 ms [1.789 ms, 1.856 ms] 367.211 µs (25.2%)
tracing 1.825 ms [1.793 ms, 1.857 ms] 370.02 µs (25.4%)

ojung
ojung approved these changes May 6, 2024
View reviewed changes
Copy link
Member

@ojung ojung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@jpbempel jpbempel merged commit 154b90a into master May 6, 2024
80 checks passed
@jpbempel jpbempel deleted the jpbempel/exception-sampling-sync branch May 6, 2024 12:55
@github-actions github-actions bot added this to the 1.34.0 milestone May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ojung ojung ojung approved these changes

Assignees
No one assigned
Labels
comp: debugger Dynamic Instrumentation
Projects
None yet
Milestone
1.34.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jpbempel @ojung