Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make tasks wrapped by grpc-context unwrappable #6977

Merged
merged 1 commit into from
May 1, 2024
Merged

make tasks wrapped by grpc-context unwrappable #6977

merged 1 commit into from
May 1, 2024

Conversation

richardstartin
Copy link
Member

@richardstartin richardstartin commented May 1, 2024 •
edited by jira bot
Loading

What Does This Do

Makes Runnables and Callables wrapped by grpc-context unwrappable, so we can report any time they spend queueing against the user's task name.

Motivation

Additional Notes

Jira ticket: PROF-9698

@richardstartin richardstartin added the comp: profiling Profiling label May 1, 2024
@pr-commenter
Copy link

pr-commenter bot commented May 1, 2024

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master rgs/unwrap-grpc-context
git_commit_date 1714499775 1714559789
git_commit_sha 16c56bf 9955cc8
release_version 1.34.0-SNAPSHOT~16c56bf74f 1.34.0-SNAPSHOT~9955cc8f3d
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1714562329 1714562329
ci_job_id 501590797 501590797
ci_pipeline_id 33330797 33330797
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 49 metrics, 14 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.34.0-SNAPSHOT~9955cc8f3d, baseline=1.34.0-SNAPSHOT~16c56bf74f

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.084 s) : 0, 1083920
Total [baseline] (10.457 s) : 0, 10456614
Agent [candidate] (1.076 s) : 0, 1076297
Total [candidate] (10.419 s) : 0, 10418798
section appsec
Agent [baseline] (1.191 s) : 0, 1190820
Total [baseline] (10.497 s) : 0, 10497425
Agent [candidate] (1.187 s) : 0, 1187221
Total [candidate] (10.488 s) : 0, 10488340
section iast
Agent [baseline] (1.199 s) : 0, 1198873
Total [baseline] (10.743 s) : 0, 10743200
Agent [candidate] (1.207 s) : 0, 1207183
Total [candidate] (10.758 s) : 0, 10757550
section profiling
Agent [baseline] (1.283 s) : 0, 1282903
Total [baseline] (10.592 s) : 0, 10592118
Agent [candidate] (1.266 s) : 0, 1265823
Total [candidate] (10.615 s) : 0, 10615351
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.084 s -
Agent appsec 1.191 s 106.9 ms (9.9%)
Agent iast 1.199 s 114.954 ms (10.6%)
Agent profiling 1.283 s 198.984 ms (18.4%)
Total tracing 10.457 s -
Total appsec 10.497 s 40.812 ms (0.4%)
Total iast 10.743 s 286.586 ms (2.7%)
Total profiling 10.592 s 135.504 ms (1.3%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.076 s -
Agent appsec 1.187 s 110.925 ms (10.3%)
Agent iast 1.207 s 130.886 ms (12.2%)
Agent profiling 1.266 s 189.526 ms (17.6%)
Total tracing 10.419 s -
Total appsec 10.488 s 69.542 ms (0.7%)
Total iast 10.758 s 338.752 ms (3.3%)
Total profiling 10.615 s 196.553 ms (1.9%) 
gantt
    title petclinic - break down per module: candidate=1.34.0-SNAPSHOT~9955cc8f3d, baseline=1.34.0-SNAPSHOT~16c56bf74f

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (678.917 ms) : 0, 678917
BytebuddyAgent [candidate] (673.958 ms) : 0, 673958
GlobalTracer [baseline] (312.054 ms) : 0, 312054
GlobalTracer [candidate] (310.232 ms) : 0, 310232
AppSec [baseline] (49.848 ms) : 0, 49848
AppSec [candidate] (49.445 ms) : 0, 49445
Remote Config [baseline] (670.723 µs) : 0, 671
Remote Config [candidate] (656.304 µs) : 0, 656
Telemetry [baseline] (7.703 ms) : 0, 7703
Telemetry [candidate] (7.51 ms) : 0, 7510
section appsec
BytebuddyAgent [baseline] (697.06 ms) : 0, 697060
BytebuddyAgent [candidate] (694.859 ms) : 0, 694859
GlobalTracer [baseline] (291.464 ms) : 0, 291464
GlobalTracer [candidate] (291.768 ms) : 0, 291768
AppSec [baseline] (149.243 ms) : 0, 149243
AppSec [candidate] (148.78 ms) : 0, 148780
IAST [baseline] (19.137 ms) : 0, 19137
IAST [candidate] (19.313 ms) : 0, 19313
Remote Config [baseline] (624.637 µs) : 0, 625
Remote Config [candidate] (619.432 µs) : 0, 619
Telemetry [baseline] (8.459 ms) : 0, 8459
Telemetry [candidate] (7.224 ms) : 0, 7224
section iast
BytebuddyAgent [baseline] (795.003 ms) : 0, 795003
BytebuddyAgent [candidate] (799.772 ms) : 0, 799772
GlobalTracer [baseline] (288.517 ms) : 0, 288517
GlobalTracer [candidate] (290.352 ms) : 0, 290352
AppSec [baseline] (48.885 ms) : 0, 48885
AppSec [candidate] (50.611 ms) : 0, 50611
IAST [baseline] (23.384 ms) : 0, 23384
IAST [candidate] (23.514 ms) : 0, 23514
Remote Config [baseline] (2.099 ms) : 0, 2099
Remote Config [candidate] (1.977 ms) : 0, 1977
Telemetry [baseline] (6.72 ms) : 0, 6720
Telemetry [candidate] (6.586 ms) : 0, 6586
section profiling
BytebuddyAgent [baseline] (686.456 ms) : 0, 686456
BytebuddyAgent [candidate] (676.71 ms) : 0, 676710
GlobalTracer [baseline] (383.964 ms) : 0, 383964
GlobalTracer [candidate] (379.304 ms) : 0, 379304
AppSec [baseline] (50.446 ms) : 0, 50446
AppSec [candidate] (50.006 ms) : 0, 50006
Remote Config [baseline] (727.951 µs) : 0, 728
Remote Config [candidate] (698.302 µs) : 0, 698
Telemetry [baseline] (7.613 ms) : 0, 7613
Telemetry [candidate] (7.477 ms) : 0, 7477
ProfilingAgent [baseline] (96.414 ms) : 0, 96414
ProfilingAgent [candidate] (95.458 ms) : 0, 95458
Profiling [baseline] (96.438 ms) : 0, 96438
Profiling [candidate] (95.482 ms) : 0, 95482
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.34.0-SNAPSHOT~9955cc8f3d, baseline=1.34.0-SNAPSHOT~16c56bf74f

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.076 s) : 0, 1075725
Total [baseline] (8.567 s) : 0, 8567299
Agent [candidate] (1.076 s) : 0, 1076250
Total [candidate] (8.541 s) : 0, 8541197
section iast
Agent [baseline] (1.196 s) : 0, 1196093
Total [baseline] (9.017 s) : 0, 9017309
Agent [candidate] (1.198 s) : 0, 1197607
Total [candidate] (8.988 s) : 0, 8987782
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.201 s) : 0, 1201380
Total [baseline] (8.988 s) : 0, 8988189
Agent [candidate] (1.21 s) : 0, 1210169
Total [candidate] (9.03 s) : 0, 9030030
section iast_TELEMETRY_OFF
Agent [baseline] (1.205 s) : 0, 1204614
Total [baseline] (9.035 s) : 0, 9034696
Agent [candidate] (1.205 s) : 0, 1204668
Total [candidate] (9.087 s) : 0, 9087267
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.076 s -
Agent iast 1.196 s 120.369 ms (11.2%)
Agent iast_HARDCODED_SECRET_DISABLED 1.201 s 125.655 ms (11.7%)
Agent iast_TELEMETRY_OFF 1.205 s 128.889 ms (12.0%)
Total tracing 8.567 s -
Total iast 9.017 s 450.009 ms (5.3%)
Total iast_HARDCODED_SECRET_DISABLED 8.988 s 420.89 ms (4.9%)
Total iast_TELEMETRY_OFF 9.035 s 467.397 ms (5.5%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.076 s -
Agent iast 1.198 s 121.356 ms (11.3%)
Agent iast_HARDCODED_SECRET_DISABLED 1.21 s 133.918 ms (12.4%)
Agent iast_TELEMETRY_OFF 1.205 s 128.418 ms (11.9%)
Total tracing 8.541 s -
Total iast 8.988 s 446.586 ms (5.2%)
Total iast_HARDCODED_SECRET_DISABLED 9.03 s 488.833 ms (5.7%)
Total iast_TELEMETRY_OFF 9.087 s 546.07 ms (6.4%) 
gantt
    title insecure-bank - break down per module: candidate=1.34.0-SNAPSHOT~9955cc8f3d, baseline=1.34.0-SNAPSHOT~16c56bf74f

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (673.515 ms) : 0, 673515
BytebuddyAgent [candidate] (674.87 ms) : 0, 674870
GlobalTracer [baseline] (309.83 ms) : 0, 309830
GlobalTracer [candidate] (309.138 ms) : 0, 309138
AppSec [baseline] (49.65 ms) : 0, 49650
AppSec [candidate] (49.408 ms) : 0, 49408
Remote Config [baseline] (663.471 µs) : 0, 663
Remote Config [candidate] (661.569 µs) : 0, 662
Telemetry [baseline] (7.638 ms) : 0, 7638
Telemetry [candidate] (7.585 ms) : 0, 7585
section iast
BytebuddyAgent [baseline] (792.188 ms) : 0, 792188
BytebuddyAgent [candidate] (793.489 ms) : 0, 793489
GlobalTracer [baseline] (287.684 ms) : 0, 287684
GlobalTracer [candidate] (287.683 ms) : 0, 287683
AppSec [baseline] (50.938 ms) : 0, 50938
AppSec [candidate] (50.036 ms) : 0, 50036
IAST [baseline] (23.952 ms) : 0, 23952
IAST [candidate] (24.953 ms) : 0, 24953
Remote Config [baseline] (587.038 µs) : 0, 587
Remote Config [candidate] (668.323 µs) : 0, 668
Telemetry [baseline] (6.604 ms) : 0, 6604
Telemetry [candidate] (6.604 ms) : 0, 6604
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (794.409 ms) : 0, 794409
BytebuddyAgent [candidate] (801.39 ms) : 0, 801390
GlobalTracer [baseline] (288.993 ms) : 0, 288993
GlobalTracer [candidate] (290.829 ms) : 0, 290829
AppSec [baseline] (50.228 ms) : 0, 50228
AppSec [candidate] (52.247 ms) : 0, 52247
IAST [baseline] (23.079 ms) : 0, 23079
IAST [candidate] (22.143 ms) : 0, 22143
Remote Config [baseline] (2.813 ms) : 0, 2813
Remote Config [candidate] (2.075 ms) : 0, 2075
Telemetry [baseline] (7.556 ms) : 0, 7556
Telemetry [candidate] (6.815 ms) : 0, 6815
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (797.6 ms) : 0, 797600
BytebuddyAgent [candidate] (797.658 ms) : 0, 797658
GlobalTracer [baseline] (290.02 ms) : 0, 290020
GlobalTracer [candidate] (289.816 ms) : 0, 289816
AppSec [baseline] (52.12 ms) : 0, 52120
AppSec [candidate] (50.63 ms) : 0, 50630
IAST [baseline] (22.27 ms) : 0, 22270
IAST [candidate] (23.982 ms) : 0, 23982
Remote Config [baseline] (606.846 µs) : 0, 607
Remote Config [candidate] (589.56 µs) : 0, 590
Telemetry [baseline] (7.403 ms) : 0, 7403
Telemetry [candidate] (7.422 ms) : 0, 7422
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-05-01T10:49:25 2024-05-01T10:56:18
git_branch master rgs/unwrap-grpc-context
git_commit_date 1714499775 1714559789
git_commit_sha 16c56bf 9955cc8
release_version 1.34.0-SNAPSHOT~16c56bf74f 1.34.0-SNAPSHOT~9955cc8f3d
start_time 2024-05-01T10:49:11 2024-05-01T10:56:04
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1714561326 1714561326
ci_job_id 501590798 501590798
ci_pipeline_id 33330797 33330797
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.34.0-SNAPSHOT~9955cc8f3d, baseline=1.34.0-SNAPSHOT~16c56bf74f
    dateFormat X
    axisFormat %s
section baseline
no_agent (383.992 µs) : 364, 404
.   : milestone, 384,
iast (486.333 µs) : 465, 507
.   : milestone, 486,
iast_FULL (551.145 µs) : 531, 572
.   : milestone, 551,
iast_GLOBAL (508.357 µs) : 487, 530
.   : milestone, 508,
iast_HARDCODED_SECRET_DISABLED (478.573 µs) : 458, 499
.   : milestone, 479,
iast_INACTIVE (459.328 µs) : 438, 480
.   : milestone, 459,
iast_TELEMETRY_OFF (484.104 µs) : 463, 505
.   : milestone, 484,
tracing (462.271 µs) : 441, 484
.   : milestone, 462,
section candidate
no_agent (376.327 µs) : 357, 396
.   : milestone, 376,
iast (484.269 µs) : 463, 505
.   : milestone, 484,
iast_FULL (555.197 µs) : 534, 577
.   : milestone, 555,
iast_GLOBAL (502.591 µs) : 482, 523
.   : milestone, 503,
iast_HARDCODED_SECRET_DISABLED (485.885 µs) : 465, 507
.   : milestone, 486,
iast_INACTIVE (458.598 µs) : 438, 479
.   : milestone, 459,
iast_TELEMETRY_OFF (477.91 µs) : 457, 499
.   : milestone, 478,
tracing (461.172 µs) : 439, 483
.   : milestone, 461,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 383.992 µs [363.738 µs, 404.245 µs] -
iast 486.333 µs [465.376 µs, 507.29 µs] 102.342 µs (26.7%)
iast_FULL 551.145 µs [530.715 µs, 571.574 µs] 167.153 µs (43.5%)
iast_GLOBAL 508.357 µs [486.683 µs, 530.031 µs] 124.365 µs (32.4%)
iast_HARDCODED_SECRET_DISABLED 478.573 µs [458.243 µs, 498.903 µs] 94.581 µs (24.6%)
iast_INACTIVE 459.328 µs [438.365 µs, 480.29 µs] 75.336 µs (19.6%)
iast_TELEMETRY_OFF 484.104 µs [462.809 µs, 505.399 µs] 100.112 µs (26.1%)
tracing 462.271 µs [440.93 µs, 483.612 µs] 78.279 µs (20.4%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 376.327 µs [356.796 µs, 395.858 µs] -
iast 484.269 µs [463.13 µs, 505.408 µs] 107.942 µs (28.7%)
iast_FULL 555.197 µs [533.627 µs, 576.767 µs] 178.87 µs (47.5%)
iast_GLOBAL 502.591 µs [482.156 µs, 523.026 µs] 126.264 µs (33.6%)
iast_HARDCODED_SECRET_DISABLED 485.885 µs [465.101 µs, 506.668 µs] 109.558 µs (29.1%)
iast_INACTIVE 458.598 µs [437.764 µs, 479.432 µs] 82.271 µs (21.9%)
iast_TELEMETRY_OFF 477.91 µs [456.918 µs, 498.902 µs] 101.583 µs (27.0%)
tracing 461.172 µs [439.36 µs, 482.984 µs] 84.845 µs (22.5%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.34.0-SNAPSHOT~9955cc8f3d, baseline=1.34.0-SNAPSHOT~16c56bf74f
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.344 ms) : 1325, 1363
.   : milestone, 1344,
appsec (1.729 ms) : 1705, 1753
.   : milestone, 1729,
appsec_no_iast (1.713 ms) : 1688, 1738
.   : milestone, 1713,
iast (1.514 ms) : 1492, 1537
.   : milestone, 1514,
profiling (1.54 ms) : 1514, 1566
.   : milestone, 1540,
tracing (1.495 ms) : 1471, 1520
.   : milestone, 1495,
section candidate
no_agent (1.347 ms) : 1328, 1367
.   : milestone, 1347,
appsec (1.748 ms) : 1725, 1772
.   : milestone, 1748,
appsec_no_iast (1.749 ms) : 1724, 1773
.   : milestone, 1749,
iast (1.496 ms) : 1473, 1519
.   : milestone, 1496,
profiling (1.532 ms) : 1506, 1557
.   : milestone, 1532,
tracing (1.504 ms) : 1479, 1528
.   : milestone, 1504,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.344 ms [1.325 ms, 1.363 ms] -
appsec 1.729 ms [1.705 ms, 1.753 ms] 384.793 µs (28.6%)
appsec_no_iast 1.713 ms [1.688 ms, 1.738 ms] 368.567 µs (27.4%)
iast 1.514 ms [1.492 ms, 1.537 ms] 169.97 µs (12.6%)
profiling 1.54 ms [1.514 ms, 1.566 ms] 195.692 µs (14.6%)
tracing 1.495 ms [1.471 ms, 1.52 ms] 150.955 µs (11.2%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.347 ms [1.328 ms, 1.367 ms] -
appsec 1.748 ms [1.725 ms, 1.772 ms] 400.813 µs (29.7%)
appsec_no_iast 1.749 ms [1.724 ms, 1.773 ms] 401.469 µs (29.8%)
iast 1.496 ms [1.473 ms, 1.519 ms] 148.584 µs (11.0%)
profiling 1.532 ms [1.506 ms, 1.557 ms] 184.221 µs (13.7%)
tracing 1.504 ms [1.479 ms, 1.528 ms] 156.378 µs (11.6%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master rgs/unwrap-grpc-context
git_commit_date 1714499775 1714559789
git_commit_sha 16c56bf 9955cc8
release_version 1.34.0-SNAPSHOT~16c56bf74f 1.34.0-SNAPSHOT~9955cc8f3d
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1714561830 1714561830
ci_job_id 501590799 501590799
ci_pipeline_id 33330797 33330797
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.34.0-SNAPSHOT~9955cc8f3d, baseline=1.34.0-SNAPSHOT~16c56bf74f
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.456 ms) : 1445, 1468
.   : milestone, 1456,
appsec (2.194 ms) : 2160, 2228
.   : milestone, 2194,
iast (1.868 ms) : 1833, 1903
.   : milestone, 1868,
iast_GLOBAL (1.899 ms) : 1864, 1933
.   : milestone, 1899,
profiling (1.826 ms) : 1793, 1860
.   : milestone, 1826,
tracing (1.815 ms) : 1784, 1847
.   : milestone, 1815,
section candidate
no_agent (1.449 ms) : 1438, 1460
.   : milestone, 1449,
appsec (2.19 ms) : 2157, 2224
.   : milestone, 2190,
iast (1.875 ms) : 1840, 1910
.   : milestone, 1875,
iast_GLOBAL (1.909 ms) : 1874, 1944
.   : milestone, 1909,
profiling (1.834 ms) : 1800, 1868
.   : milestone, 1834,
tracing (1.82 ms) : 1788, 1852
.   : milestone, 1820,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.456 ms [1.445 ms, 1.468 ms] -
appsec 2.194 ms [2.16 ms, 2.228 ms] 737.796 µs (50.7%)
iast 1.868 ms [1.833 ms, 1.903 ms] 412.006 µs (28.3%)
iast_GLOBAL 1.899 ms [1.864 ms, 1.933 ms] 442.458 µs (30.4%)
profiling 1.826 ms [1.793 ms, 1.86 ms] 370.068 µs (25.4%)
tracing 1.815 ms [1.784 ms, 1.847 ms] 359.13 µs (24.7%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.449 ms [1.438 ms, 1.46 ms] -
appsec 2.19 ms [2.157 ms, 2.224 ms] 741.349 µs (51.2%)
iast 1.875 ms [1.84 ms, 1.91 ms] 425.919 µs (29.4%)
iast_GLOBAL 1.909 ms [1.874 ms, 1.944 ms] 459.845 µs (31.7%)
profiling 1.834 ms [1.8 ms, 1.868 ms] 385.155 µs (26.6%)
tracing 1.82 ms [1.788 ms, 1.852 ms] 370.994 µs (25.6%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.34.0-SNAPSHOT~9955cc8f3d, baseline=1.34.0-SNAPSHOT~16c56bf74f
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.291 s) : 15291000, 15291000
.   : milestone, 15291000,
appsec (15.244 s) : 15244000, 15244000
.   : milestone, 15244000,
iast (18.775 s) : 18775000, 18775000
.   : milestone, 18775000,
iast_GLOBAL (18.012 s) : 18012000, 18012000
.   : milestone, 18012000,
profiling (15.464 s) : 15464000, 15464000
.   : milestone, 15464000,
tracing (15.151 s) : 15151000, 15151000
.   : milestone, 15151000,
section candidate
no_agent (15.041 s) : 15041000, 15041000
.   : milestone, 15041000,
appsec (15.071 s) : 15071000, 15071000
.   : milestone, 15071000,
iast (19.009 s) : 19009000, 19009000
.   : milestone, 19009000,
iast_GLOBAL (17.885 s) : 17885000, 17885000
.   : milestone, 17885000,
profiling (15.15 s) : 15150000, 15150000
.   : milestone, 15150000,
tracing (14.88 s) : 14880000, 14880000
.   : milestone, 14880000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.291 s [15.291 s, 15.291 s] -
appsec 15.244 s [15.244 s, 15.244 s] -47.0 ms (-0.3%)
iast 18.775 s [18.775 s, 18.775 s] 3.484 s (22.8%)
iast_GLOBAL 18.012 s [18.012 s, 18.012 s] 2.721 s (17.8%)
profiling 15.464 s [15.464 s, 15.464 s] 173.0 ms (1.1%)
tracing 15.151 s [15.151 s, 15.151 s] -140.0 ms (-0.9%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.041 s [15.041 s, 15.041 s] -
appsec 15.071 s [15.071 s, 15.071 s] 30.0 ms (0.2%)
iast 19.009 s [19.009 s, 19.009 s] 3.968 s (26.4%)
iast_GLOBAL 17.885 s [17.885 s, 17.885 s] 2.844 s (18.9%)
profiling 15.15 s [15.15 s, 15.15 s] 109.0 ms (0.7%)
tracing 14.88 s [14.88 s, 14.88 s] -161.0 ms (-1.1%)

@richardstartin richardstartin requested a review from a team May 1, 2024 11:47
@richardstartin richardstartin marked this pull request as ready for review May 1, 2024 11:47
@richardstartin richardstartin requested a review from a team as a code owner May 1, 2024 11:47
@richardstartin richardstartin merged commit 860baa9 into master May 1, 2024
82 checks passed
@richardstartin richardstartin deleted the rgs/unwrap-grpc-context branch May 1, 2024 12:24
@github-actions github-actions bot added this to the 1.34.0 milestone May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbachorik jbachorik jbachorik approved these changes

@dougqh dougqh Awaiting requested review from dougqh dougqh was automatically assigned from DataDog/apm-java

@am312 am312 Awaiting requested review from am312 am312 was automatically assigned from DataDog/apm-java

Assignees
No one assigned
Labels
comp: profiling Profiling
Projects
None yet
Milestone
1.34.0
Development

Successfully merging this pull request may close these issues.
2 participants
@richardstartin @jbachorik