Skip to content

Conversation

manuel-alvarez-alvarez
Copy link
Member

@manuel-alvarez-alvarez manuel-alvarez-alvarez commented Oct 3, 2025

What does this PR do?

Ensures the APP_KEY is not captured or transmitted through telemetry.

Motivation

The APP_KEY must be handled like the API_KEY and must never be shared or transmitted via telemetry.

Plugin Checklist

Additional Notes

Copy link

github-actions bot commented Oct 3, 2025

Overall package size

Self size: 12.57 MB
Deduped: 112.79 MB
No deduping: 113.19 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.7.0 | 35.02 MB | 35.02 MB | | @datadog/native-appsec | 10.2.1 | 20.64 MB | 20.65 MB | | @datadog/native-iast-taint-tracking | 4.0.0 | 11.72 MB | 11.73 MB | | @datadog/pprof | 5.10.0 | 9.91 MB | 10.3 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.5.4 | 2.95 MB | 5.73 MB | | @datadog/wasm-js-rewriter | 4.0.1 | 2.85 MB | 3.58 MB | | @datadog/native-metrics | 3.1.1 | 1.02 MB | 1.43 MB | | @opentelemetry/api | 1.9.0 | 1.22 MB | 1.22 MB | | jsonpath-plus | 10.3.0 | 617.18 kB | 1.08 MB | | import-in-the-middle | 1.14.4 | 123.18 kB | 851.76 kB | | lru-cache | 10.4.3 | 804.3 kB | 804.3 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | source-map | 0.7.6 | 185.63 kB | 185.63 kB | | pprof-format | 2.2.1 | 163.06 kB | 163.06 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 7.0.5 | 63.38 kB | 63.38 kB | | istanbul-lib-coverage | 3.2.2 | 34.37 kB | 34.37 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | shell-quote | 1.8.3 | 23.74 kB | 23.74 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | mutexify | 1.4.0 | 5.71 kB | 8.74 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | module-details-from-path | 1.0.4 | 3.96 kB | 3.96 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

Copy link

codecov bot commented Oct 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.31%. Comparing base (6b5670c) to head (2f2f6be).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6593      +/-   ##
==========================================
- Coverage   83.97%   83.31%   -0.67%     
==========================================
  Files         489      476      -13     
  Lines       20470    20193     -277     
==========================================
- Hits        17190    16824     -366     
- Misses       3280     3369      +89     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@manuel-alvarez-alvarez manuel-alvarez-alvarez force-pushed the malvarez/remove-app-key-telemetry branch 2 times, most recently from c4f117c to a957cfa Compare October 3, 2025 09:52
@manuel-alvarez-alvarez manuel-alvarez-alvarez force-pushed the malvarez/remove-app-key-telemetry branch from a957cfa to 2f2f6be Compare October 3, 2025 09:53
@manuel-alvarez-alvarez manuel-alvarez-alvarez marked this pull request as ready for review October 3, 2025 09:54
@manuel-alvarez-alvarez manuel-alvarez-alvarez requested review from a team as code owners October 3, 2025 09:54
@manuel-alvarez-alvarez manuel-alvarez-alvarez requested review from BridgeAR and removed request for a team October 3, 2025 09:54
@pr-commenter
Copy link

pr-commenter bot commented Oct 3, 2025

Benchmarks

Benchmark execution time: 2025-10-03 10:00:46

Comparing candidate commit 2f2f6be in PR branch malvarez/remove-app-key-telemetry with baseline commit 6b5670c in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1601 metrics, 69 unstable metrics.

@simon-id simon-id enabled auto-merge (squash) October 3, 2025 10:09
@simon-id simon-id merged commit ab95474 into master Oct 3, 2025
1089 of 1093 checks passed
@simon-id simon-id deleted the malvarez/remove-app-key-telemetry branch October 3, 2025 10:10
@dd-octo-sts dd-octo-sts bot mentioned this pull request Oct 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants