chore(ci_visibility): restore log level for Test Optimization log messages #14151
Conversation
|
|
vitor-de-araujo
added
the
changelog/no-changelog
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 279 ± 3 ms. The average import time from base is: 281 ± 3 ms. The import time difference between this PR and base is: -1.7 ± 0.1 ms. Import time breakdownThe following import paths have shrunk:
|
Performance SLOsCandidate: vitor-de-araujo/APMS-16576/restore-logger (7c7e48a) 🔵 No Baseline Data (24 suites)🔵 coreapiscenario - 12/12 (2 unstable)🔵 No baseline data available for this suite
|
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-3.11 3.11
# Navigate to the new working tree
cd .worktrees/backport-3.11
# Create a new branch
git switch --create backport-14151-to-3.11
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 26eb6528d91fce56468545a2d2a089a27f0dfae3
# Push it to GitHub
git push --set-upstream origin backport-14151-to-3.11
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-3.11Then, create a pull request where the |
Ensure test logs are propagated to the root logger so `caplog` can see them. This is necessary because #14151 sets the log level of the `ddtrace` tracer during tests, and with that debug logs from `ddtrace` are not propagated anymore. ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) --------- Co-authored-by: Brett Langdon <brett.langdon@datadoghq.com>
With PR #14121, we stopped propagating logs to the root logger, so the root logging level is not used by Test Optimization messages anymore; we need to explicitly set the log level for the ddtrace logger as well.
Checklist
Reviewer Checklist