Skip to content

chore(profiling): disable profiling on python 3.14 #14669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 22, 2025
Merged

chore(profiling): disable profiling on python 3.14 #14669

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dea64f0
skip profiling on python 3.14 for now
emmettbutler Sep 22, 2025
bdf9958
more complete disablement
emmettbutler Sep 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 14 additions & 7 deletions ddtrace/settings/profiling.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import itertools
import math
import os
import sys
import typing as t

from ddtrace.ext.git import COMMIT_SHA
Expand Down Expand Up @@ -64,6 +65,9 @@ def _check_for_stack_v2_available():


def _parse_profiling_enabled(raw: str) -> bool:
if sys.version_info >= (3, 14):
return False

# Try to derive whether we're enabled via DD_INJECTION_ENABLED
# - Are we injected (DD_INJECTION_ENABLED set)
# - Is profiling enabled ("profiler" in the list)
Expand Down Expand Up @@ -257,7 +261,8 @@ class ProfilingConfigStack(DDConfig):
_v2_enabled = DDConfig.v(
bool,
"v2_enabled",
default=True,
# Not yet supported on 3.14
default=sys.version_info < (3, 14),
help_type="Boolean",
help="Whether to enable the v2 stack profiler. Also enables the libdatadog collector.",
)
Expand Down Expand Up @@ -370,12 +375,14 @@ class ProfilingConfigPytorch(DDConfig):

# We need to check if ddup is available, and turn off profiling if it is not.
if not ddup_is_available:
msg = ddup_failure_msg or "libdd not available"
logger.warning("Failed to load ddup module (%s), disabling profiling", msg)
telemetry_writer.add_log(
TELEMETRY_LOG_LEVEL.ERROR,
"Failed to load ddup module (%s), disabling profiling" % ddup_failure_msg,
)
# We know it is not supported on 3.14, so don't report the error, but still disable
if sys.version_info < (3, 14):
msg = ddup_failure_msg or "libdd not available"
logger.warning("Failed to load ddup module (%s), disabling profiling", msg)
telemetry_writer.add_log(
TELEMETRY_LOG_LEVEL.ERROR,
"Failed to load ddup module (%s), disabling profiling" % ddup_failure_msg,
)
config.enabled = False

# We also need to check if stack_v2 module is available, and turn if off
Expand Down
Loading