fix(botocore): exclude params.Records from tags #2204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jd
previously approved these changes
Mar 22, 2021
releasenotes/notes/botocore-exclude-records--74ac3e5d4d4fdc95.yaml
Outdated
Show resolved
Hide resolved
The params.Records argument could be big and therefore generate big trace payloads when added to the span tags. This change marks this argument for exclusion.
P403n1x87
force-pushed
the
botocore-exclude-big-arg
branch
from
9a6e38b
to
312d54d
Compare
…yaml Co-authored-by: Julien Danjou <julien@danjou.info>
Kyle-Verhoog
approved these changes
Mar 22, 2021
Codecov Report
@@ Coverage Diff @@
## master #2204 +/- ##
==========================================
- Coverage 91.60% 91.59% -0.01%
==========================================
Files 568 568
Lines 40767 40767
==========================================
- Hits 37343 37342 -1
- Misses 3424 3425 +1
Continue to review full report at Codecov.
|
jd
approved these changes
Mar 23, 2021
P403n1x87
added a commit
to P403n1x87/dd-trace-py
that referenced
this pull request
Mar 25, 2021
This change adds a test case for DataDog#2204 to ensure that the params.Records argument is excluded from the span tags.
4 tasks
mergify bot
added a commit
that referenced
this pull request
Mar 25, 2021
This change adds a test case for #2204 to ensure that the params.Records argument is excluded from the span tags. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Kyle-Verhoog
added a commit
that referenced
this pull request
Apr 1, 2021
* fix typo in filter debug line (#2213) Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> * feat: support space separated DD_TAGS value (#2196) Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> * Add sync mode to AgentWriter (#2206) * feat(agent): support aws lambda extension * chore: fix flake8 issue with test * chore: add release note for datadog lambda extension * chore: fix import order * chore: fix flake8 issue * [serverless] fix broken test * remove unused import * separate out sync writer changes * add integration tests for sync writer Co-authored-by: DarcyRaynerDD <darcy.rayner@datadoghq.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> * ci: run django test suite with ddtrace enabled (#2203) * Run django test suite with ddtrace enabled * Added pylibmc install to fix build error * Added django/ddtrace install commands to separate blocks * Fixed annotation * Installed generic version of ddtrace instead of checking out * Added documentation * Changed working directory, removed inherently failing test * Reverted working directory change * Reverted skipping specific test, added pythonpath * Added more docs Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> * ci: run flask test suite with ddtrace enabled (#2190) * ci: run flask test suite with ddtrace enabled * Update .github/workflows/flask.yml Co-authored-by: Brett Langdon <me@brett.is> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Brett Langdon <brett.langdon@datadoghq.com> Co-authored-by: Brett Langdon <me@brett.is> Co-authored-by: Kyle Verhoog <kyle@verhoog.ca> * docs: add note about pip version requirement (#2220) * handle logwriter configure (#2219) Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> * test: move __init__ to utils (#2217) Having code in tests/__init__ makes ddtrace being imported before we have a chance to do anything, such as calling gevent.monkey.patch_all. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> * refactor: distributed_tracing_enabled usages to trace_utils helper (#2216) * Modified trace util helper to account for inconsistencies in distributed_tracing config key, refactored usages * Refactored traceutils helper * Made int_config optional in the trace_util helper, updated affected integration files * Removed erroneous code addition to pyramid/trace.py * Make tracer tests less noisy (#2221) monkeypatch.setenv warns if the value given is not an instance of the base string type. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> * refactor(worker): replace regular thread by PeriodicThread (#2205) Co-authored-by: Tahir H. Butt <tahir.butt@datadoghq.com> * Disable known failing Django tests (#2224) * Disable known failing Django tests * fix yaml multiline string Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> * test(botocore): add test case for firehose args (#2227) This change adds a test case for #2204 to ensure that the params.Records argument is excluded from the span tags. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> * refactor: move ddtrace.profiling._attr to ddtrace.utils (#2230) Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> * Adding urllib3 integration (#1148) * draft of urllib3 integration * black formatting * set request tags on the span before the call is made in case of errors * rename span name and support retry tags based on CR feedback * add tests and fix a few small bugs * fix flake8 * add tests and circleci config * flake8 fixes * Update ddtrace/contrib/urllib3/__init__.py Co-Authored-By: Tahir H. Butt <tahir.butt@datadoghq.com> * use dd compat for urlparse and unparse * use SpanType constants for type of span use SpanTypes.HTTP * fix tests * fix flake8 from merge conflict resolution * adapt to latest changes on master * adopt latest standards for integrations Use Pin to add patch information to urllib3 requests. Also use riot for configuring the test environment * apply checklist points * wip: make tests pass * set tags on exception also fixed the tests to override HTTP configuration where required * docs(urllib3): add urllib3 integration docs * fix service name handling * fix copy-pasta errors and improve documentation * Update ddtrace/contrib/urllib3/__init__.py Co-authored-by: Kyle Verhoog <kyle@verhoog.ca> * Update riotfile.py Co-authored-by: Kyle Verhoog <kyle@verhoog.ca> * remove unused imports from test sources * use the new get_argument_value utility * Update tests/contrib/urllib3/test_urllib3.py Co-authored-by: Kyle Verhoog <kyle@verhoog.ca> * Update ddtrace/contrib/urllib3/patch.py Co-authored-by: Kyle Verhoog <kyle@verhoog.ca> * commit Tahir's suggestions * fix TracerTestCase import Co-authored-by: Tahir H. Butt <tahir.butt@datadoghq.com> Co-authored-by: Gabriele N. Tornetta <gabriele.tornetta@datadoghq.com> Co-authored-by: Gabriele N. Tornetta <P403n1x87@users.noreply.github.com> Co-authored-by: Kyle Verhoog <kyle@verhoog.ca> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Yun Kim <35776586+Yun-Kim@users.noreply.github.com> * Revert writer.write argument change (#2232) This is a breaking change which we're going to make at a later date. * Make processor private on Tracer (#2233) This isn't something we want to make public yet. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> * fix(profiling): make sure PeriodicCollector start withing service lock (#2214) This makes sure the periodic collectors are started while the service lock is held to avoid race conditions while starting the services. This has no impact in practice since the Profiler class was made thread safe with #2179. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> * refactor(forksafe): simplify code (#2222) This simplifies the code to use a banal decorator approach rather than a weird lambda-passed-as-argument-based 😉 It also adds typing and an `unregister` function to allow for… unregistering a function! Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> * chore: correct typing hints for span.meta (#2237) Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> * Lambda extension support (#2092) * feat(agent): support aws lambda extension * chore: fix flake8 issue with test * chore: add release note for datadog lambda extension * chore: fix import order * chore: fix flake8 issue * [serverless] fix broken test * remove unused import * Add docs, type hints Co-authored-by: Kyle Verhoog <kyle.verhoog@datadoghq.com> Co-authored-by: Kyle Verhoog <kyle@verhoog.ca> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Yun Kim <35776586+Yun-Kim@users.noreply.github.com> * fix(span): ensure ID args have the correct type (#2243) Among all the arguments of the Span constructor, the ones bearing IDs are the most important type-wise. This change adds checks to ensure that span_id, trace_id and parent_id all have the expected type. The rationale for adding the check at construction time is so that this error could be caught as soon as possible, rather than defer it to later processing stages, thus avoiding invalid entries in the processing queue. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> * fix: only warn if using uwsgi with ddtrace-run (#2202) * fix: only warn if using uwsgi with ddtrace-run * remove DeprecationWarning prefix * update message Co-authored-by: Brett Langdon <brett.langdon@datadoghq.com> * Update ISSUE_TEMPLATE.md (#2248) * Use multiproject pipeline to deploy to reliability env (#2249) * Use multiproject pipeline for reliability env deploy * Use default branch Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> * style(pymongo): format pymongo (#2250) * fix: handle text types in _set_str_tag (#2218) * chore: correct typing hints for span.meta * fix: handle text types in _set_str_tag * chore: correct typing hints for span.meta * fix: handle text types in _set_str_tag * fix: handle text types in _set_str_tag * flake8 * add doc string, fix test * fix grpc traceback tag Co-authored-by: Brett Langdon <brett.langdon@datadoghq.com> Co-authored-by: Gabriele N. Tornetta <P403n1x87@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Tahir H. Butt <tahir.butt@datadoghq.com> Co-authored-by: DarcyRaynerDD <darcy.rayner@datadoghq.com> Co-authored-by: Yun Kim <35776586+Yun-Kim@users.noreply.github.com> Co-authored-by: Julien Danjou <julien.danjou@datadoghq.com> Co-authored-by: Brett Langdon <brett.langdon@datadoghq.com> Co-authored-by: Brett Langdon <me@brett.is> Co-authored-by: Gabriele N. Tornetta <P403n1x87@users.noreply.github.com> Co-authored-by: Justin <justin.james.iso@gmail.com> Co-authored-by: Gabriele N. Tornetta <gabriele.tornetta@datadoghq.com> Co-authored-by: Darcy Rayner <50632605+DarcyRaynerDD@users.noreply.github.com> Co-authored-by: Laplie Anderson <randomanderson@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The params.Records argument could be big and therefore generate big trace payloads when added to the span tags. This change marks this argument for exclusion.
Checklist