Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert http route tagging #3539

Merged
merged 25 commits into from
Mar 19, 2024
Merged

Revert http route tagging #3539

merged 25 commits into from
Mar 19, 2024

Conversation

lloeki
Copy link
Contributor

@lloeki lloeki commented Mar 19, 2024 •
edited
Loading

2.0 Upgrade Guide notes

What does this PR do?

Revert http route tagging: #3345

Motivation:

#3526

Additional Notes:

git revert f7eb87278 6d0f1186c 128ce7d39 c7301d3c2 40fd7bb18 1f89257c2 4ad8a6d23 ce0db69c3 696a3d082 84196547c 82aaa029c 16e3cb308 2f901db5d 78fe38d93 e4aa83ae8  b335dd591 604f07b49 118bc826d 9353f02de 898e9590c 016df1141 02761bb76 8e3973340 2a26d9c95 d3dfe3239

How to test the change?

  • CI should not be broken
  • rails 7.0 should be covered by system tests
  • manually test rails 7.1

For Datadog employees:

  • If this PR touches code that signs or publishes builds or packages, or handles
    credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

@lloeki
Revert "remove unnecessary comment"
b48c971 
This reverts commit f7eb872.
@lloeki
Revert "rewrites as trace tag"
ba2f9bb 
This reverts commit 6d0f118.
@lloeki
Revert "fixed rakefile"
8783768 
This reverts commit 128ce7d.
@lloeki
Revert "adds jruby tests and lint"
55707c4 
This reverts commit c7301d3.
@lloeki
Revert "update appraisal files"
f068006 
This reverts commit 40fd7bb.
@lloeki
Revert "adds tests"
09be905 
This reverts commit 1f89257.
@lloeki
Revert "fixed sinatra route when using script name"
0022430 
This reverts commit 4ad8a6d.
@lloeki
Revert "fixes leak and potential errors"
ec7d7af 
This reverts commit ce0db69.
@lloeki
Revert "added comment and fixed nested rack routes"
b6c4c9c 
This reverts commit 696a3d0.
@lloeki
Revert "removes unnecessary constants"
888ad74 
This reverts commit 8419654.
@lloeki
Revert "Try to fix Spring test failure"
b6ebaa6 
This reverts commit 82aaa02.
@lloeki
Revert "linter fixes"
e508f33 
This reverts commit 16e3cb3.
@lloeki
Revert "Skip for Rails < 4.2"
b97213c 
This reverts commit 2f901db.
@lloeki
Revert "Skip patching for Rails 3"
7b6dd68 
This reverts commit 78fe38d.
@lloeki
Revert "Skip patching for Rails 3"
336a859 
This reverts commit e4aa83a.
@lloeki
Revert "remove kwargs to fix tests"
384fc03 
This reverts commit b335dd5.
@lloeki
Revert "fixes grape flaky test"
b235f78 
This reverts commit 604f07b.
@lloeki
Revert "adds tracing to rack requests and basic testing"
0afae0c 
This reverts commit 118bc82.
@lloeki
Revert "removes unnecessary rails tracing"
f97ab18 
This reverts commit 9353f02.
@lloeki
Revert "cleaned up and addressed most todos"
3f4a41c 
This reverts commit 898e959.
@lloeki
Revert "Handle all sorts of nesting"
335026f 
This reverts commit 016df11.
@lloeki
Revert "linter fixes"
12273c3 
This reverts commit 02761bb.
@lloeki
Revert "added routes to sinatra/grape and fixes up rails"
79cd5ad 
This reverts commit 8e39733.
@lloeki
Revert "Move span creation to Routing::RouteSet"
3beff3e 
This reverts commit 2a26d9c.
@lloeki
Revert "Add crude span for Rails routing"
8cff34b 
This reverts commit d3dfe32.
@lloeki lloeki requested review from a team as code owners March 19, 2024 15:49
@github-actions github-actions bot added integrations Involves tracing integrations tracing labels Mar 19, 2024
@TonyCTHsu TonyCTHsu added this to the 1.21.1 milestone Mar 19, 2024
This was linked to issues Mar 19, 2024
v1.21.0 causes outages due to a nil error in rack middleware #3538
Closed
http.route tag causes exception when interacting with engine route path helpers #3526
Closed
ivoanjo
ivoanjo approved these changes Mar 19, 2024
View reviewed changes
Copy link
Member

@ivoanjo ivoanjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good. I've compared it thoroughly with #3345.

In practice we don't need to revert as many things, but in the interest of time, let's go with this and regroup later.

@ivoanjo ivoanjo mentioned this pull request Mar 19, 2024
Closed
@lloeki lloeki merged commit d5b36e7 into master Mar 19, 2024
220 checks passed
@lloeki lloeki deleted the revert-http-route-tagging branch March 19, 2024 17:42
@TonyCTHsu TonyCTHsu mentioned this pull request Mar 20, 2024
Merged
This was referenced Aug 19, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivoanjo ivoanjo ivoanjo approved these changes

@TonyCTHsu TonyCTHsu TonyCTHsu approved these changes

Assignees
No one assigned
Labels
integrations Involves tracing integrations tracing
Projects
None yet
Milestone
1.21.1
3 participants
@lloeki @ivoanjo @TonyCTHsu