Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHA to ensure milestone #3570

Merged
merged 4 commits into from
Apr 12, 2024
Merged

GHA to ensure milestone #3570

merged 4 commits into from
Apr 12, 2024

Conversation

TonyCTHsu
Copy link
Contributor

@TonyCTHsu TonyCTHsu commented Apr 2, 2024

What

  1. Remove draft notes GHA -> migrate to release script, https://github.com/DataDog/ruby-guild/pull/139
  2. Remove milestone creation GHA -> migrate to release script, https://github.com/DataDog/ruby-guild/pull/140
  3. Change adding milestone the pull request by guessing the milestone title starts with the major version from the gemspec of the merged branch.

@github-actions github-actions bot added the dev/github Github repository maintenance and automation label Apr 2, 2024
@TonyCTHsu TonyCTHsu added this to the 1.22.0 milestone Apr 2, 2024
@TonyCTHsu TonyCTHsu force-pushed the tonycthsu/ensure-milestone branch from 27a4c3f to 0039c73 Compare April 2, 2024 23:50
@TonyCTHsu TonyCTHsu modified the milestone: 1.22.0 Apr 3, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.24%. Comparing base (ffc2546) to head (fabd2b2).
Report is 13 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3570      +/-   ##
==========================================
- Coverage   98.27%   98.24%   -0.04%     
==========================================
  Files        1274     1254      -20     
  Lines       75233    74338     -895     
  Branches     3545     3527      -18     
==========================================
- Hits        73934    73030     -904     
- Misses       1299     1308       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TonyCTHsu TonyCTHsu force-pushed the tonycthsu/ensure-milestone branch from 0039c73 to 49656f3 Compare April 4, 2024 07:54
@TonyCTHsu TonyCTHsu force-pushed the tonycthsu/ensure-milestone branch from c8a7227 to fabd2b2 Compare April 4, 2024 09:20
@TonyCTHsu TonyCTHsu marked this pull request as ready for review April 4, 2024 09:29
@TonyCTHsu TonyCTHsu requested a review from a team as a code owner April 4, 2024 09:29
@TonyCTHsu TonyCTHsu merged commit a0bc470 into master Apr 12, 2024
207 checks passed
@TonyCTHsu TonyCTHsu deleted the tonycthsu/ensure-milestone branch April 12, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/github Github repository maintenance and automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants