Add more 2.x deprecation warnings #3647
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delner
added
feature
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 1.x-stable #3647 +/- ##
===========================================
Coverage 98.24% 98.24%
===========================================
Files 1255 1255
Lines 74651 74659 +8
Branches 3544 3548 +4
===========================================
+ Hits 73342 73352 +10
+ Misses 1309 1307 -2 ☔ View full report in Codecov by Sentry. |
delner
force-pushed
the
delner/add_2x_deprecation_warnings
branch
from
8f1430e to
7ddccc5
Compare
|
I'd like to rebase this on the changes implemented in #3675, so that these deprecation warnings can utilize the limit feature. |
delner
force-pushed
the
delner/add_2x_deprecation_warnings
branch
from
7ddccc5 to
4b44893
Compare
|
I've rebased the changes on top of the "log limit" functionality backported via #3780. This should prevent verbosity on the configuration path. We could go further with changes here, but I think I want to stop here for now; I need to move onto other changes, and want to get this merged before it gets either too large or stale. Should be ready for review. |
|
Hey @delner is this still relevant? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds some more deprecation warnings for changes outlined in the upgrade guide. Includes:
Use of non-strings for 'env' configuration is deprecated. Use a string instead.Use of non-strings for 'service' configuration is deprecated. Use a string instead.Motivation:
To help users more easily through the 2.x upgrade process. These warnings should make it easier for users to identify breaking changes on existing 1.x deployments, and update their code in a 1.x/2.x compatible way, before undertaking a 2.x upgrade.
Additional Notes:
There are many changes in the upgrade guide. Some may be worth warning about, others may be more trouble than they are worth. I'm mostly focusing on actionable.
We also should be careful with how verbose some of these warnings could be, especially when they are in the instrumentation path (and could be triggered many times.) Perhaps we should add some more explicit "print once" behavior?