-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEBUG-2657 DRY benchmarks #3787
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-datadog
force-pushed
the
benchmark-dry
branch
5 times, most recently
from
July 17, 2024 13:58
5290776
to
0bf60cd
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3787 +/- ##
==========================================
- Coverage 97.91% 97.91% -0.01%
==========================================
Files 1246 1246
Lines 74999 74999
Branches 3627 3627
==========================================
- Hits 73435 73434 -1
- Misses 1564 1565 +1 ☔ View full report in Codecov by Sentry. |
github-actions
bot
removed
the
dev/testing
Involves testing processes (e.g. RSpec)
label
Jul 24, 2024
p-datadog
force-pushed
the
benchmark-dry
branch
from
August 5, 2024 16:48
846a40c
to
c76829a
Compare
…s subdir)" This reverts commit 2840239.
Extract repetitive configuration of benchmarks into a helper module, refactor benchmarks to use the new configuration DSL.
p-datadog
force-pushed
the
benchmark-dry
branch
from
August 6, 2024 14:55
c76829a
to
eec85cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract repetitive configuration of benchmarks into a helper module, refactor benchmarks to use the new configuration DSL.
What does this PR do?
Extract repetitive configuration of benchmarks into a helper module, refactor benchmarks to use the new configuration DSL.
Motivation:
Benchmarks have a lot of duplicated code and they do not all consistently use the tooling available, like the dogstatsd reporter. This PR removes code duplication and unifies benchmarks' behavior.
Additional Notes:
Tracing benchmark not converted yet because I think it should be split into separate files to follow the profiling benchmark's pattern.
How to test the change?
Unsure? Have a question? Request a review!