Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEBUG-2657 DRY benchmarks #3787

Closed
wants to merge 20 commits into from
Closed

DEBUG-2657 DRY benchmarks #3787

wants to merge 20 commits into from

Conversation

p-datadog
Copy link
Member

Extract repetitive configuration of benchmarks into a helper module, refactor benchmarks to use the new configuration DSL.

What does this PR do?

Extract repetitive configuration of benchmarks into a helper module, refactor benchmarks to use the new configuration DSL.

Motivation:

Benchmarks have a lot of duplicated code and they do not all consistently use the tooling available, like the dogstatsd reporter. This PR removes code duplication and unifies benchmarks' behavior.

Additional Notes:

Tracing benchmark not converted yet because I think it should be split into separate files to follow the profiling benchmark's pattern.

How to test the change?

Unsure? Have a question? Request a review!

@p-datadog p-datadog requested a review from a team as a code owner July 16, 2024 18:53
@github-actions github-actions bot added the dev/testing Involves testing processes (e.g. RSpec) label Jul 16, 2024
@p-datadog p-datadog marked this pull request as draft July 16, 2024 18:58
@p-datadog p-datadog force-pushed the benchmark-dry branch 5 times, most recently from 5290776 to 0bf60cd Compare July 17, 2024 13:58
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.91%. Comparing base (161e3eb) to head (0bf60cd).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3787      +/-   ##
==========================================
- Coverage   97.91%   97.91%   -0.01%     
==========================================
  Files        1246     1246              
  Lines       74999    74999              
  Branches     3627     3627              
==========================================
- Hits        73435    73434       -1     
- Misses       1564     1565       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot removed the dev/testing Involves testing processes (e.g. RSpec) label Jul 24, 2024
@pr-commenter
Copy link

pr-commenter bot commented Jul 24, 2024

Benchmarks

Benchmark execution time: 2024-07-25 20:17:19

Comparing candidate commit 846a40c in PR branch benchmark-dry with baseline commit 8fdf5a3 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics.

@p-datadog p-datadog changed the title DRY benchmarks DEBUG-2657 DRY benchmarks Jul 30, 2024
@github-actions github-actions bot added the dev/testing Involves testing processes (e.g. RSpec) label Aug 6, 2024
@p-datadog p-datadog closed this Aug 7, 2024
@p-datadog p-datadog deleted the benchmark-dry branch December 19, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/testing Involves testing processes (e.g. RSpec)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants