Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress startup logs in test and development environments #3836

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Conversation

marcotc
Copy link
Member

@marcotc marcotc commented Aug 8, 2024

Fixes #3807

This PR aligns the development environment detection for remote configuration, telemetry and, now, startup logs.

The development environment detection for startup logs now includes test environments and local development environments.

@marcotc marcotc requested review from a team as code owners August 8, 2024 21:23
@github-actions github-actions bot added the core Involves Datadog core libraries label Aug 8, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.88%. Comparing base (acd9271) to head (53a3900).
Report is 51 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3836      +/-   ##
==========================================
- Coverage   97.88%   97.88%   -0.01%     
==========================================
  Files        1261     1261              
  Lines       75624    75605      -19     
  Branches     3706     3706              
==========================================
- Hits        74025    74006      -19     
  Misses       1599     1599              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Aug 8, 2024

Benchmarks

Benchmark execution time: 2024-08-08 21:55:31

Comparing candidate commit 53a3900 in PR branch dev-env with baseline commit acd9271 in branch master.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 2 unstable metrics.

scenario:trace.to_digest

  • 🟩 throughput [+3398.689op/s; +4009.518op/s] or [+2.093%; +2.470%]

Copy link
Member

@anmarchenko anmarchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Copy link
Member

@ivoanjo ivoanjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM, thanks for picking this one up!

@marcotc marcotc merged commit aa6550c into master Aug 9, 2024
181 checks passed
@marcotc marcotc deleted the dev-env branch August 9, 2024 19:51
@github-actions github-actions bot added this to the 2.3.0 milestone Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Involves Datadog core libraries
Projects
None yet
Development

Successfully merging this pull request may close these issues.

suppress logs by default when running minitest tests
4 participants