Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new debug mode for Go Tracer #19293

Merged
merged 8 commits into from
Sep 6, 2023
Merged

Add new debug mode for Go Tracer #19293

merged 8 commits into from
Sep 6, 2023

Conversation

hannahkm
Copy link
Contributor

@hannahkm hannahkm commented Aug 8, 2023

What does this PR do?

This updates the public docs to reflect a new debug mode added to the Go Tracer in this PR.

Motivation

Keep the public docs accurate with the Go Tracer.

Additional Notes


Reviewer checklist

  • Review the changed files.
  • Review the URLs listed in the Preview section.
  • Check images for PII
  • Review any mentions of "Contact Datadog support" for internal support documentation.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2023

Preview links (active after the build_preview check completes)

Modified Files

@hannahkm hannahkm marked this pull request as ready for review August 18, 2023 14:18
@hannahkm hannahkm requested a review from a team as a code owner August 18, 2023 14:18
@hannahkm hannahkm changed the title [WIP] Add new debug mode for Go Tracer Add new debug mode for Go Tracer Aug 18, 2023
Copy link
Contributor

@brett0000FF brett0000FF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just two small suggestions. Let me know if you need me to merge this. 😄

content/en/tracing/troubleshooting/tracer_debug_logs.md Outdated Show resolved Hide resolved
content/en/tracing/troubleshooting/tracer_debug_logs.md Outdated Show resolved Hide resolved
@hannahkm hannahkm added the Do Not Merge Just do not merge this PR :) label Aug 18, 2023
hannahkm and others added 2 commits August 18, 2023 10:45
Co-authored-by: Brett Blue <84536271+brett0000FF@users.noreply.github.com>
Co-authored-by: Brett Blue <84536271+brett0000FF@users.noreply.github.com>
@hannahkm
Copy link
Contributor Author

LGTM! Just two small suggestions. Let me know if you need me to merge this. 😄

Thank you! 🎉 Let's wait for the Go Tracer to be updated before changing the public docs. Someone on the Go team will be back to let the docs team know when this can be merged. Thanks!

@darccio
Copy link
Member

darccio commented Sep 6, 2023

@brett0000FF The feature was merged into main, and it will be released in the next v1.55.0. Are we good to go?

@brett0000FF brett0000FF merged commit 37866ac into master Sep 6, 2023
7 checks passed
@brett0000FF brett0000FF deleted the hannahkm/go-debug-mode branch September 6, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Do Not Merge Just do not merge this PR :)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants