Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOCS-7802 Network Analytics Edit #23025

Merged
merged 8 commits into from
Jun 24, 2024
Merged

DOCS-7802 Network Analytics Edit #23025

merged 8 commits into from
Jun 24, 2024

Conversation

alai97
Copy link
Contributor

@alai97 alai97 commented May 6, 2024 •
edited
Loading

What does this PR do? What is the motivation?

Updates the TCP metrics table for Failed Connections private beta feature on the Network Analytics doc page + add a section about Failed Connections on the Setup doc page.

Merge instructions

  • Please merge after reviewing

Additional notes

@alai97 alai97 requested a review from catyaoddog May 6, 2024 23:06
@alai97 alai97 requested a review from a team as a code owner May 6, 2024 23:06
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 6, 2024 •
edited
Loading

Preview links (active after the build_preview check completes)

Modified Files

maycmlee
maycmlee approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@maycmlee maycmlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of small suggestions, but approving!

content/en/network_monitoring/performance/network_analytics.md Outdated Show resolved Hide resolved
@alai97 @maycmlee
Wording Nit
66e3bb4 
Co-authored-by: May Lee <may.lee@datadoghq.com>
@alai97 alai97 added the okr1 label May 23, 2024
@alai97 alai97 requested a review from akarpz June 20, 2024 23:24
@alai97 alai97 merged commit dd6e4e2 into master Jun 24, 2024
13 checks passed
@alai97 alai97 deleted the alai97/npm-metric-doc-edit branch June 24, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maycmlee maycmlee maycmlee approved these changes

@akarpz akarpz akarpz approved these changes

@catyaoddog catyaoddog Awaiting requested review from catyaoddog

Assignees
No one assigned
Labels
okr1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alai97 @akarpz @maycmlee