Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DDSQL Editor docs #23538

Merged
merged 61 commits into from
Jun 24, 2024
Merged

DDSQL Editor docs #23538

merged 61 commits into from
Jun 24, 2024

Conversation

jhgilbert
Copy link
Contributor

What does this PR do? What is the motivation?

DOCS-7524

Merge instructions

  • Please merge after reviewing

Additional notes

@jhgilbert jhgilbert added WORK IN PROGRESS No review needed, it's a wip ;) Do Not Merge Just do not merge this PR :) okr1 labels Jun 6, 2024
@jhgilbert jhgilbert requested a review from a team as a code owner June 6, 2024 18:31
@github-actions github-actions bot added Architecture Everything related to the Doc backend Images Images are added/removed with this PR labels Jun 6, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 6, 2024 •
edited
Loading

Preview links (active after the build_preview check completes)

New or renamed files

@jhgilbert jhgilbert removed the WORK IN PROGRESS No review needed, it's a wip ;) label Jun 21, 2024
hestonhoffman
hestonhoffman approved these changes Jun 24, 2024
View reviewed changes
Copy link
Contributor

@hestonhoffman hestonhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Left some suggestions, but mostly small style changes.

content/en/dashboards/ddsql_editor/getting_started.md Outdated Show resolved Hide resolved
content/en/dashboards/ddsql_editor/getting_started.md Outdated Show resolved Hide resolved
content/en/dashboards/ddsql_editor/reference/_index.md
title: DDSQL Reference
---

{{< callout url="https://datadoghq.com/private-beta/ddsql-editor">}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a heads up that this currently 404s

content/en/dashboards/ddsql_editor/reference/_index.md Outdated Show resolved Hide resolved
content/en/dashboards/ddsql_editor/reference/aggregation_functions.md Outdated Show resolved Hide resolved
content/en/dashboards/ddsql_editor/reference/statements.md Outdated Show resolved Hide resolved
content/en/dashboards/ddsql_editor/reference/statements.md Outdated Show resolved Hide resolved
content/en/dashboards/ddsql_editor/reference/tags.md Outdated Show resolved Hide resolved
content/en/dashboards/ddsql_editor/reference/window_functions.md Outdated Show resolved Hide resolved
static/images/dashboards/ddsql/inventories-explore-view.png Outdated Show resolved Hide resolved
jhgilbert and others added 13 commits June 24, 2024 13:40
@jhgilbert @hestonhoffman
Update content/en/dashboards/ddsql_editor/reference/tags.md
c32d0cd 
Co-authored-by: Heston Hoffman <heston.hoffman@datadoghq.com>
@jhgilbert @hestonhoffman
Update content/en/dashboards/ddsql_editor/reference/window_functions.md
82df3c2 
Co-authored-by: Heston Hoffman <heston.hoffman@datadoghq.com>
@jhgilbert @hestonhoffman
Update content/en/dashboards/ddsql_editor/getting_started.md
0d214b1 
Co-authored-by: Heston Hoffman <heston.hoffman@datadoghq.com>
@jhgilbert @hestonhoffman
Update content/en/dashboards/ddsql_editor/reference/statements.md
5406787 
Co-authored-by: Heston Hoffman <heston.hoffman@datadoghq.com>
@jhgilbert @hestonhoffman
Update content/en/dashboards/ddsql_editor/reference/expressions_and_o…
7267a78 
…perators.md

Co-authored-by: Heston Hoffman <heston.hoffman@datadoghq.com>
@jhgilbert @hestonhoffman
Update content/en/dashboards/ddsql_editor/reference/statements.md
1781f3b 
Co-authored-by: Heston Hoffman <heston.hoffman@datadoghq.com>
@jhgilbert @hestonhoffman
Update content/en/dashboards/ddsql_editor/reference/aggregation_funct…
40995c0 
…ions.md

Co-authored-by: Heston Hoffman <heston.hoffman@datadoghq.com>
@jhgilbert @hestonhoffman
Update content/en/dashboards/ddsql_editor/getting_started.md
f566b5f 
Co-authored-by: Heston Hoffman <heston.hoffman@datadoghq.com>
@jhgilbert
Integrate editorial review feedback
d6ba551
@jhgilbert @hestonhoffman
Update content/en/dashboards/ddsql_editor/reference/scalar_functions.md
4afca9a 
Co-authored-by: Heston Hoffman <heston.hoffman@datadoghq.com>
@jhgilbert @hestonhoffman
Update content/en/dashboards/ddsql_editor/reference/scalar_functions.md
518d9df 
Co-authored-by: Heston Hoffman <heston.hoffman@datadoghq.com>
@jhgilbert
Fix broken link
ffc8509
@jhgilbert
Style tweak
51682ae
@jhgilbert jhgilbert removed the Do Not Merge Just do not merge this PR :) label Jun 24, 2024
@jhgilbert jhgilbert merged commit 9971925 into master Jun 24, 2024
15 of 16 checks passed
@jhgilbert jhgilbert deleted the jen.gilbert/DOCS-7524-inventories-sql branch June 24, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dd-annarose dd-annarose dd-annarose left review comments

@joparisot joparisot joparisot left review comments

@cangencer cangencer cangencer left review comments

@hestonhoffman hestonhoffman hestonhoffman approved these changes

Assignees
No one assigned
Labels
Architecture Everything related to the Doc backend editorial review Waiting on a more in-depth review Images Images are added/removed with this PR okr1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jhgilbert @cangencer @hestonhoffman @joparisot @dd-annarose