Add podLabels value to allow setting labels that only appear on the pods managed by the deployment.
#1358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@loutPhilipps Changed some indenting to make more readable. |
|
@loutPhilipps Not sure what is up with the labeler but I did not touch anything with that. I did find at least one other pull request with same error. |
|
Me neither :/ |
loutPhilipps
approved these changes
Mar 29, 2024
dmcdii
force-pushed
the
main
branch
2 times, most recently
from
ea875f0
to
90ef5d7
Compare
|
@loutPhilipps Sorry missed there were changes rebase complete. |
loutPhilipps
approved these changes
Mar 29, 2024
… pods managed by the deployment.
|
@loutPhilipps Had to rebase again. I noticed it did not merge, is there something else I need to do in order to get it merged? |
Just merged it for you 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add
podLabelsvalue to allow setting labels that only appear on the pods managed by the deployment.Need pod label for monitoring that value changes regularly with version upgrades. Cannot use
commonLabelsbecause they are used as match labels which are immutable.Which issue this PR fixes
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
.github/helm-docs.sh)CHANGELOG.mdhas been updatedREADME.md