Add multiple_ips option and address tag #10868
Conversation
ghost
added
| check.check(None) | ||
| check.check(None) |
There was a problem hiding this comment.
| check.check(None) | |
| check.check(None) | |
| dd_run_check(check) | |
| dd_run_check(check) |
small nit
There was a problem hiding this comment.
I saw that tcp_check still uses check.check(None) for its other non-e2e tests, so it's up to you if you want to apply this change or keep things consistent for a separate PR.
There was a problem hiding this comment.
Let's do this in another PR
coignetp
changed the title
Can we just always call gethostbyname_ex rather than adding a new config option? |
That would break monitors and dashboards by default for customers aggregating by |
* Add multiple_ips option * Use gethostbyname_ex * Add test * Rename to resolve_ips * Add address service check group
What does this PR do?
Add
multiple_ipsconfiguration optionWhen enabled, integration calls
gethostbyname_ex(https://docs.python.org/3/library/socket.html#socket.gethostbyname_ex) instead ofgethostbyname(https://docs.python.org/3/library/socket.html#socket.gethostbyname)A domain can have multiple IPs attached, and
gethostbynamereturns only one of the IPs, whereasgethostbyname_exreturns all of them.So when
multiple_ipsis enabled, we run the check against all the IPs attached to the domain instead of oneMotivation
Support case
Additional Notes
Review checklist (to be filled by reviewers)
changelog/andintegration/labels attached