Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add token_path config option #11160

Merged
merged 5 commits into from
Jan 21, 2022
Merged

Add token_path config option #11160

merged 5 commits into from
Jan 21, 2022

Conversation

coignetp
Copy link
Contributor

@coignetp coignetp commented Jan 18, 2022

What does this PR do?

Add token_path config option so the token can be refreshed at each check run

Motivation

Feature request to be able to rotate tokens, vault integration does something similar

def renew_client_token(self):

Additional Notes

Password is actually not required

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

alai97
alai97 previously approved these changes Jan 18, 2022
Copy link
Contributor

@alai97 alai97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good pending three copy nits!

snowflake/assets/configuration/spec.yaml Outdated Show resolved Hide resolved
snowflake/assets/configuration/spec.yaml Outdated Show resolved Hide resolved
snowflake/assets/configuration/spec.yaml Outdated Show resolved Hide resolved
Co-authored-by: Austin Lai <76412946+alai97@users.noreply.github.com>
@github-actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@coignetp coignetp mentioned this pull request Jan 20, 2022
4 tasks
Copy link
Contributor

@sarah-witt sarah-witt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I had one more comment

snowflake/datadog_checks/snowflake/config.py Show resolved Hide resolved
@coignetp coignetp merged commit 119bbcc into master Jan 21, 2022
@coignetp coignetp deleted the paul/sf-token-path branch January 21, 2022 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants