-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add token_path config option #11160
Add token_path config option #11160
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good pending three copy nits!
Co-authored-by: Austin Lai <76412946+alai97@users.noreply.github.com>
The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I had one more comment
What does this PR do?
Add
token_path
config option so the token can be refreshed at each check runMotivation
Feature request to be able to rotate tokens, vault integration does something similar
integrations-core/vault/datadog_checks/vault/vault.py
Line 320 in 3616496
Additional Notes
Password is actually not required
Review checklist (to be filled by reviewers)
changelog/
andintegration/
labels attached