Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update system state log line wording #11577

Merged
merged 2 commits into from
Feb 28, 2022
Merged

Update system state log line wording #11577

merged 2 commits into from
Feb 28, 2022

Conversation

sarah-witt
Copy link
Contributor

What does this PR do?

  • Update the wording of a log line regarding failure to collect system state.
  • Also adds a test for this scenario, as well as updates the other system state test to assert the tags returned

Motivation

More clear instructions to users, QA

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@ghost ghost added the integration/silk label Feb 25, 2022
@codecov
Copy link

codecov bot commented Feb 25, 2022 •
edited
Loading

Codecov Report

Merging #11577 (b1121dc) into master (0dacf81) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Flag Coverage Δ
silk 93.37% <100.00%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@sarah-witt sarah-witt marked this pull request as ready for review February 25, 2022 20:22
@sarah-witt sarah-witt requested a review from a team as a code owner February 25, 2022 20:22
@sarah-witt sarah-witt merged commit 66cfbef into master Feb 28, 2022
@sarah-witt sarah-witt deleted the sarah/silk-imrpove-log-line branch February 28, 2022 16:56
ofek pushed a commit that referenced this pull request Mar 1, 2022
@sarah-witt @ofek
Update system state log line wording (#11577)
dfdc4f5 
* improve log line, add a test for system state

* Remove check id
@ofek ofek added the category/bugfix For use during Agent Release period label Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yzhan289 yzhan289 yzhan289 approved these changes

Assignees
No one assigned
Labels
category/bugfix For use during Agent Release period integration/silk
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sarah-witt @yzhan289 @ofek