Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Silk service check tagging #13816

Merged
merged 10 commits into from
Feb 7, 2023
Merged

Improve Silk service check tagging #13816

merged 10 commits into from
Feb 7, 2023

Conversation

yzhan289
Copy link
Contributor

What does this PR do?

This PR updates tags for the Silk system state service check and also improves Silk testing for it.

Motivation

Improve the testing to make adding new features easier.

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached
  • If the PR doesn't need to be tested during QA, please add a qa/skip-qa label.

@yzhan289 yzhan289 requested a review from a team as a code owner January 26, 2023 21:16
@github-actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@github-actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

FlorentClarret
FlorentClarret requested changes Jan 27, 2023
View reviewed changes
Copy link
Member

@FlorentClarret FlorentClarret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Left some nits

silk/tests/test_integration.py Outdated Show resolved Hide resolved
silk/tests/test_integration.py Outdated Show resolved Hide resolved
silk/tests/test_integration.py Outdated Show resolved Hide resolved
silk/tests/test_integration.py Outdated Show resolved Hide resolved
@github-actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@FlorentClarret
Copy link
Member

Looks like we have some py2 compatibility issues 😓

@codecov
Copy link

codecov bot commented Feb 6, 2023 •
edited
Loading

Codecov Report

Merging #13816 (fa9a079) into master (979eed3) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Flag Coverage Δ
silk 93.51% <100.00%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@yzhan289 yzhan289 merged commit 93f5c20 into master Feb 7, 2023
@yzhan289 yzhan289 deleted the az/silk-refactor-tests branch February 7, 2023 14:39
@hithwen hithwen mentioned this pull request Apr 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FlorentClarret FlorentClarret FlorentClarret approved these changes

Assignees
No one assigned
Labels
integration/silk
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yzhan289 @FlorentClarret