Collect stored procedure metrics from dm_exec_procedure_stats #15805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
joelmarcotte
changed the title
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
jmeunier28
reviewed
Sep 13, 2023
lu-zhengda
reviewed
Sep 13, 2023
jmeunier28
reviewed
Sep 13, 2023
jmeunier28
reviewed
Sep 13, 2023
jmeunier28
reviewed
Sep 13, 2023
joelmarcotte
force-pushed
the
joel.marcotte/sprocs
branch
from
e2d0f5a
to
35101bd
Compare
jmeunier28
previously approved these changes
Sep 25, 2023
| 'min_collection_interval': self.collection_interval, | ||
| 'tags': self.tags, | ||
| 'cloud_metadata': self.check.cloud_metadata, | ||
| 'payload_type': 'procedure_metrics', |
There was a problem hiding this comment.
Just a thought since we're at the stage where we can still consider changes: should we call this kind instead of payload_type? That's what we use for the metadata payloads and I was looking at this and thinking of adopting similar patterns for the new metric type.
joelmarcotte
dismissed stale reviews from jmeunier28 and cswatt
via
6f1157f
jmeunier28
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When DBM is enabled, starts collecting stored procedure metrics from sys.dm_exec_procedure_stats at 60s interval (configurable). Also adds the corresponding
procedure_metricssection to the config file. The new DBM-only metrics aresqlserver.procedures.count,sqlserver.procedures.time,sqlserver.procedures.worker_time,sqlserver.procedures.physical_reads,sqlserver.procedures.logical_reads,sqlserver.procedures.logical_writesandsqlserver.procedures.spills.Motivation
Improve the SQL Server monitoring posture of DBM (Database Monitoring) by adding stored procedure metrics to the collected telemetry.
Additional Notes
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.