Update gitlab_runner to use the new OpenMetricsBaseCheck #1978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rishabh
force-pushed
the
rish/prometheus_rework
branch
from
e7b150c
to
55edc20
Compare
rishabh
force-pushed
the
rish/gitlab_runner-prometheus-rework
branch
from
53b4791
to
22a9175
Compare
4 tasks
rishabh
force-pushed
the
rish/prometheus_rework
branch
from
b3180b7
to
579904a
Compare
rishabh
force-pushed
the
rish/gitlab_runner-prometheus-rework
branch
from
48d5d8f
to
3bdfed6
Compare
rishabh
force-pushed
the
rish/prometheus_rework
branch
from
934661a
to
be99352
Compare
rishabh
force-pushed
the
rish/gitlab_runner-prometheus-rework
branch
2 times, most recently
from
425a979
to
ab7f6c9
Compare
rishabh
force-pushed
the
rish/prometheus_rework
branch
from
be99352
to
d5b1cdb
Compare
rishabh
force-pushed
the
rish/gitlab_runner-prometheus-rework
branch
from
ab7f6c9
to
f0643d3
Compare
rishabh
changed the title
rishabh
force-pushed
the
rish/prometheus_rework
branch
from
d5b1cdb
to
f2b1ba9
Compare
mfpierre
reviewed
Aug 21, 2018
| # Mapping from Prometheus metrics names to Datadog ones | ||
| # For now it's a 1:1 mapping | ||
| # TODO: mark some metrics as rate | ||
| allowed_metrics = init_config.get('allowed_metrics') |
There was a problem hiding this comment.
We should probably move this away from init_config WDYT? (same for gitlab)
There was a problem hiding this comment.
Yes, we should, that will also allow us to actually support multiple endpoints.
We could add a deprecation warning and then adjust the docs to get users to instead define the metrics config option. What do you think?
There was a problem hiding this comment.
Let's do this in some follow-up work
rishabh
force-pushed
the
rish/prometheus_rework
branch
from
222cee3
to
7bde919
Compare
rishabh
force-pushed
the
rish/gitlab_runner-prometheus-rework
branch
2 times, most recently
from
f829daf
to
b3bc8c8
Compare
Codecov Report
@@ Coverage Diff @@
## master #1978 +/- ##
==========================================
- Coverage 86.24% 84.04% -2.21%
==========================================
Files 190 4 -186
Lines 13901 94 -13807
Branches 1491 10 -1481
==========================================
- Hits 11989 79 -11910
+ Misses 1499 8 -1491
+ Partials 413 7 -406 |
rishabh
force-pushed
the
rish/gitlab_runner-prometheus-rework
branch
from
b3bc8c8
to
59505b4
Compare
mfpierre
force-pushed
the
rish/gitlab_runner-prometheus-rework
branch
from
59505b4
to
0d6fc47
Compare
mfpierre
previously approved these changes
Sep 17, 2018
gzussa
previously approved these changes
Sep 17, 2018
| """ | ||
| # Mapping from Prometheus metrics names to Datadog ones | ||
| # For now it's a 1:1 mapping | ||
| # TODO: mark some metrics as rate |
There was a problem hiding this comment.
Could you please, remove this TODO or address it.
ofek
approved these changes
Sep 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates gitlab_runner to use the new OpenMetricsBaseCheck class.
Motivation
This fixes the check for when we use the new OpenMetricsBaseCheck class.
Review checklist
no-changeloglabel attachedAdditional Notes