Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add active defragmentation gauges for redis #5022

Merged
merged 1 commit into from
Nov 22, 2019
Merged

add active defragmentation gauges for redis #5022

merged 1 commit into from
Nov 22, 2019

Conversation

tanner-bruce
Copy link
Contributor

What does this PR do?

The active defrag gauges are missing from the redis integration and will be useful for monitoring the effects on CPU usage and overhead while active defrag is running

Motivation

Investigating active defragmentation and would like to view the metrics supplied by redis in DataDog

Additional Notes

Adds a few standard redis metrics from the INFO call

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@tanner-bruce tanner-bruce requested a review from a team as a code owner November 15, 2019 13:33
redisdb/metadata.csv Outdated Show resolved Hide resolved
redisdb/metadata.csv Outdated Show resolved Hide resolved
redisdb/metadata.csv Outdated Show resolved Hide resolved
redisdb/metadata.csv Outdated Show resolved Hide resolved
redisdb/tests/test_e2e.py Show resolved Hide resolved
Co-Authored-By: Julia <611228+hithwen@users.noreply.github.com>
@tanner-bruce
Copy link
Contributor Author

@hithwen thanks for the review, I've updated the PR now.

@codecov
Copy link

codecov bot commented Nov 21, 2019

Codecov Report

Merging #5022 into master will decrease coverage by 10.03%.
The diff coverage is 0%.

Impacted Files Coverage Δ
redisdb/datadog_checks/redisdb/redisdb.py 73.82% <ø> (ø) ⬆️
redisdb/tests/test_e2e.py 10.97% <0%> (-1.53%) ⬇️
redisdb/tests/conftest.py 85.71% <0%> (-4.77%) ⬇️
redisdb/tests/test_default.py 95.76% <0%> (ø) ⬆️
redisdb/tests/test_unit.py 100% <0%> (ø) ⬆️
redisdb/tests/common.py 100% <0%> (ø) ⬆️
redisdb/datadog_checks/redisdb/__about__.py 100% <0%> (ø) ⬆️
redisdb/tests/test_replication.py 100% <0%> (ø) ⬆️
redisdb/tests/test_auth.py 92.59% <0%> (ø) ⬆️
... and 826 more

@hithwen hithwen merged commit 347298e into DataDog:master Nov 22, 2019
@tanner-bruce tanner-bruce deleted the redis-add-defrag-gauges branch November 22, 2019 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants