-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'redis.net.connections' metric to count connections by client #6495
Add 'redis.net.connections' metric to count connections by client #6495
Conversation
1b00cb4
to
e475e98
Compare
Codecov Report
|
e475e98
to
de888f0
Compare
I think the CI is failing because I opened the PR from a fork |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff, thanks for submitting this! I only have a few nits. :-)
071c82e
to
b1aeda9
Compare
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Feel free to merge the PR as I don't have the permissions myself since the label job is failing |
What does this PR do?
Adds a new metric to the redisdb check counting the number of connection by client name
Motivation
We have a internal check at datadog reporting this metric and we think it could be useful to a lot of people
Additional Notes
Review checklist (to be filled by reviewers)
changelog/
andintegration/
labels attached