Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'redis.net.connections' metric to count connections by client #6495

Merged
merged 4 commits into from
Apr 28, 2020

Conversation

remicalixte
Copy link
Contributor

@remicalixte remicalixte commented Apr 27, 2020

What does this PR do?

Adds a new metric to the redisdb check counting the number of connection by client name

Motivation

We have a internal check at datadog reporting this metric and we think it could be useful to a lot of people

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@remicalixte remicalixte requested a review from a team as a code owner April 27, 2020 08:27
@remicalixte
Copy link
Contributor Author

I think the CI is failing because I opened the PR from a fork

@florimondmanca
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

Copy link
Contributor

@florimondmanca florimondmanca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff, thanks for submitting this! I only have a few nits. :-)

redisdb/datadog_checks/redisdb/redisdb.py Outdated Show resolved Hide resolved
redisdb/datadog_checks/redisdb/redisdb.py Outdated Show resolved Hide resolved
redisdb/tests/test_default.py Outdated Show resolved Hide resolved
@florimondmanca florimondmanca changed the title Add a connections count by client to the redisdb check Add 'redisdb.net.connections' metric to count connections by client Apr 27, 2020
@florimondmanca florimondmanca changed the title Add 'redisdb.net.connections' metric to count connections by client Add 'redis.net.connections' metric to count connections by client Apr 27, 2020
@hithwen
Copy link
Contributor

hithwen commented Apr 27, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

Copy link
Contributor

@florimondmanca florimondmanca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@remicalixte
Copy link
Contributor Author

Feel free to merge the PR as I don't have the permissions myself since the label job is failing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants