Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix style for the latest release of Black #7438

Merged
merged 4 commits into from
Aug 27, 2020
Merged

Conversation

coignetp
Copy link
Contributor

What does this PR do?

The new release of black broke master style https://pypi.org/project/black/#history

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@codecov
Copy link

codecov bot commented Aug 27, 2020

Codecov Report

Merging #7438 into master will increase coverage by 2.22%.
The diff coverage is 50.00%.

Impacted Files Coverage Δ
cisco_aci/tests/common.py 100.00% <ø> (ø)
hivemq/tests/conftest.py 61.53% <ø> (ø)
kubelet/tests/test_kubelet.py 97.44% <ø> (ø)
nfsstat/tests/conftest.py 71.42% <0.00%> (ø)
..._fargate/datadog_checks/eks_fargate/eks_fargate.py 100.00% <100.00%> (ø)
disk/tests/common.py 64.28% <0.00%> (-35.72%) ⬇️
disk/tests/conftest.py 85.71% <0.00%> (-11.43%) ⬇️
disk/datadog_checks/disk/disk.py 83.66% <0.00%> (-3.59%) ⬇️
disk/tests/test_filter.py 96.45% <0.00%> (-3.55%) ⬇️
hdfs_namenode/tests/test_integration.py
... and 604 more

hithwen
hithwen previously approved these changes Aug 27, 2020
FlorianVeaux
FlorianVeaux previously approved these changes Aug 27, 2020
florimondmanca
florimondmanca previously approved these changes Aug 27, 2020
@florimondmanca
Copy link
Contributor

florimondmanca commented Aug 27, 2020

There seems to be a bug where Black doesn't handle \t characters in the docstrings in wmi/counter_type.py - pushing a commit that removes these tabs, but maybe there is / should be an issue about this in the Black repo.

Edit: psf/black#1601

@ofek ofek changed the title Fix style on master Fix style for the latest release of Black Aug 27, 2020
@coignetp coignetp merged commit 673fe61 into master Aug 27, 2020
@coignetp coignetp deleted the paul/all-fix-style branch August 27, 2020 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment